Re: [Xen-devel] [PATCH 2/2] xenalyze: remove cr3_compare_total

2016-01-26 Thread George Dunlap
On 22/01/16 14:27, Ian Campbell wrote:
> gcc-6 complains:
> xenalyze.c:4132:9: error: 'cr3_compare_total' defined but not used 
> [-Werror=unused-function]
>  int cr3_compare_total(const void *_a, const void *_b) {
>  ^
> 
> I believe it is correct.
> 
> Signed-off-by: Ian Campbell 

Thanks,

Reviewed-by: George Dunlap 


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


[Xen-devel] [PATCH 2/2] xenalyze: remove cr3_compare_total

2016-01-22 Thread Ian Campbell
gcc-6 complains:
xenalyze.c:4132:9: error: 'cr3_compare_total' defined but not used 
[-Werror=unused-function]
 int cr3_compare_total(const void *_a, const void *_b) {
 ^

I believe it is correct.

Signed-off-by: Ian Campbell 
---
 tools/xentrace/xenalyze.c | 17 -
 1 file changed, 17 deletions(-)

diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
index 4bcaf83..6520790 100644
--- a/tools/xentrace/xenalyze.c
+++ b/tools/xentrace/xenalyze.c
@@ -4129,23 +4129,6 @@ void cr3_dump_list(struct cr3_value_struct *head){
 struct cr3_value_struct **qsort_array;
 int i, N=0;
 
-int cr3_compare_total(const void *_a, const void *_b) {
-struct cr3_value_struct *a=*(typeof())_a;
-struct cr3_value_struct *b=*(typeof())_b;
-
-if(a->total_time.cycles < b->total_time.cycles)
-return 1;
-else if(b->total_time.cycles == a->total_time.cycles) {
-if(a->total_time.count < b->total_time.count)
-return 1;
-else if(a->total_time.count == b->total_time.count)
-return 0;
-else
-return -1;
-} else
-return -1;
-}
-
 int cr3_compare_start(const void *_a, const void *_b) {
 struct cr3_value_struct *a=*(typeof())_a;
 struct cr3_value_struct *b=*(typeof())_b;
-- 
2.6.1


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel