Re: [Xen-devel] [PATCH 3/9] x86/mtrr: drop have_wrcomb() wrapper

[Jan Beulich]

>>> On 17.08.16 at 01:28,  wrote:
> The only call was always to the generic implementation.
> 
> Signed-off-by: Doug Goldstein 

Acked-by: Jan Beulich 


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH 3/9] x86/mtrr: drop have_wrcomb() wrapper

[Doug Goldstein]

The only call was always to the generic implementation.

Signed-off-by: Doug Goldstein 
---
 xen/arch/x86/cpu/mtrr/main.c | 8 +---
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/xen/arch/x86/cpu/mtrr/main.c b/xen/arch/x86/cpu/mtrr/main.c
index ff908ad..5dd1f5d 100644
--- a/xen/arch/x86/cpu/mtrr/main.c
+++ b/xen/arch/x86/cpu/mtrr/main.c
@@ -77,12 +77,6 @@ static const char *mtrr_attrib_to_str(int x)
return (x <= 6) ? mtrr_strings[x] : "?";
 }
 
-/*  Returns non-zero if we have the write-combining memory type  */
-static int have_wrcomb(void)
-{
-   return mtrr_generic_have_wrcomb();
-}
-
 /*  This function returns the number of variable MTRRs  */
 static void __init set_num_var_ranges(void)
 {
@@ -324,7 +318,7 @@ int mtrr_add_page(unsigned long base, unsigned long size,
}
 
/*  If the type is WC, check that this processor supports it  */
-   if ((type == MTRR_TYPE_WRCOMB) && !have_wrcomb()) {
+   if ((type == MTRR_TYPE_WRCOMB) && !mtrr_generic_have_wrcomb()) {
printk(KERN_WARNING
   "mtrr: your processor doesn't support 
write-combining\n");
return -ENOSYS;
-- 
2.7.3


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel