Re: [Xen-devel] [PATCH ARM v8 2/4] mini-os: arm: interrupt controller

2014-11-14 Thread Ian Campbell
On Fri, 2014-11-14 at 11:33 +, Julien Grall wrote:
  Though IIRC, mini-os for ARM is not yet SMP.
 
  It's difficult to see what needs to be done to support code that
  doesn't exist yet. For example, would gic_init be called once, or once
  per processor? Before or after the other processors are started?
 
 Some part of the code maybe necessary: setting PPIs/SGIs... You can give 
 a look to Linux/Xen GIC drivers to have an idea on what is necessary.

This would be necessary as part of the port of mini-os to support SMP. I
don't see why it should be necessary now, going to SMP is surely going
to require a bunch of refactoring in other places too (Xen itself
certainly did).

Ian.


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


Re: [Xen-devel] [PATCH ARM v8 2/4] mini-os: arm: interrupt controller

2014-11-14 Thread Julien Grall



On 14/11/2014 11:42, Ian Campbell wrote:

On Fri, 2014-11-14 at 11:33 +, Julien Grall wrote:

Though IIRC, mini-os for ARM is not yet SMP.


It's difficult to see what needs to be done to support code that
doesn't exist yet. For example, would gic_init be called once, or once
per processor? Before or after the other processors are started?


Some part of the code maybe necessary: setting PPIs/SGIs... You can give
a look to Linux/Xen GIC drivers to have an idea on what is necessary.


This would be necessary as part of the port of mini-os to support SMP. I
don't see why it should be necessary now, going to SMP is surely going
to require a bunch of refactoring in other places too (Xen itself
certainly did).


I just answered to his question. I didn't asked for changing this code 
right now.


--
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel