[Xen-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen.

2015-08-03 Thread Anthony PERARD
Hi,

We've spotted several regression which prevent migration with Xen using the
same version of QEMU or from a previous version of QEMU (tryied with 2.2).

Regression have been introduce by at least:
- df4b1024526cae3479da3492d6371fd4a7324a03
  migration: create new section to store global state
- 61964c23e5ddd5a33f15699e45ce126f879e3e33
  migration: Add configuration section

The last patch fix migration for 'xenfv' machine and for 'pc,accel=xen'
machine. 'xenpv' machine is not affected as there is no emulated device
state to save.

Change since in v2:
- replace memcpy() call by a strncpy().
- Move the skip_config_section and the like from 'xenfv' machine init to
  xen_init() which is called by accel_init_machine. (in 3rd patch)

Thanks,

Anthony PERARD (3):
  migration: Fix global state with Xen.
  migration: Add configuration section to vmstate with xen.
  migration: Fix regression for xenfv and pc,accel=xen machine.

 include/migration/migration.h | 1 +
 migration/migration.c | 7 +++
 migration/savevm.c| 6 ++
 xen-common.c  | 5 +
 4 files changed, 19 insertions(+)

-- 
Anthony PERARD


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


Re: [Xen-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen.

2015-08-03 Thread Amit Shah
On (Mon) 03 Aug 2015 [15:29:18], Anthony PERARD wrote:
 Hi,
 
 We've spotted several regression which prevent migration with Xen using the
 same version of QEMU or from a previous version of QEMU (tryied with 2.2).
 
 Regression have been introduce by at least:
 - df4b1024526cae3479da3492d6371fd4a7324a03
   migration: create new section to store global state
 - 61964c23e5ddd5a33f15699e45ce126f879e3e33
   migration: Add configuration section
 
 The last patch fix migration for 'xenfv' machine and for 'pc,accel=xen'
 machine. 'xenpv' machine is not affected as there is no emulated device
 state to save.
 
 Change since in v2:
 - replace memcpy() call by a strncpy().
 - Move the skip_config_section and the like from 'xenfv' machine init to
   xen_init() which is called by accel_init_machine. (in 3rd patch)

BTW I didn't see v2.  Was the previous series marked RFC v2?  The
changes seem to indicate there wasn't anything else in between.

Amit

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


Re: [Xen-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen.

2015-08-03 Thread Stefano Stabellini
On Mon, 3 Aug 2015, Amit Shah wrote:
 On (Mon) 03 Aug 2015 [15:29:18], Anthony PERARD wrote:
  Hi,
  
  We've spotted several regression which prevent migration with Xen using the
  same version of QEMU or from a previous version of QEMU (tryied with 2.2).
  
  Regression have been introduce by at least:
  - df4b1024526cae3479da3492d6371fd4a7324a03
migration: create new section to store global state
  - 61964c23e5ddd5a33f15699e45ce126f879e3e33
migration: Add configuration section
  
  The last patch fix migration for 'xenfv' machine and for 'pc,accel=xen'
  machine. 'xenpv' machine is not affected as there is no emulated device
  state to save.
  
  Change since in v2:
  - replace memcpy() call by a strncpy().
  - Move the skip_config_section and the like from 'xenfv' machine init to
xen_init() which is called by accel_init_machine. (in 3rd patch)
 
 BTW I didn't see v2.  Was the previous series marked RFC v2?  The
 changes seem to indicate there wasn't anything else in between.

I am pretty sure that Anthony simply made a mistake with the version
number.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


Re: [Xen-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen.

2015-08-03 Thread Anthony PERARD
On Mon, Aug 03, 2015 at 09:37:07PM +0530, Amit Shah wrote:
 On (Mon) 03 Aug 2015 [15:29:18], Anthony PERARD wrote:
  Hi,
  
  We've spotted several regression which prevent migration with Xen using the
  same version of QEMU or from a previous version of QEMU (tryied with 2.2).
  
  Regression have been introduce by at least:
  - df4b1024526cae3479da3492d6371fd4a7324a03
migration: create new section to store global state
  - 61964c23e5ddd5a33f15699e45ce126f879e3e33
migration: Add configuration section
  
  The last patch fix migration for 'xenfv' machine and for 'pc,accel=xen'
  machine. 'xenpv' machine is not affected as there is no emulated device
  state to save.
  
  Change since in v2:
  - replace memcpy() call by a strncpy().
  - Move the skip_config_section and the like from 'xenfv' machine init to
xen_init() which is called by accel_init_machine. (in 3rd patch)
 
 BTW I didn't see v2.  Was the previous series marked RFC v2?  The
 changes seem to indicate there wasn't anything else in between.

That's suppose to be the v2. And I change my mind while writing Change
since v1 and decide to write Change in v2 but since is still there...

-- 
Anthony PERARD

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel