[Xen-devel] [PATCH for-4.5 0/2] xl/libxl: return and print partial config

2014-11-12 Thread Wei Liu
This small series change the behavior of libxl_retrieve_domain_configuration,
to make it continue to retrieve information from xenstore even if JSON template
is not available.

This change of API behaviour is only internal. Conceptually speaking, any
non-zero return value means d_config is partially filled. The chanage just
makes it fill in more information (xenstore entries) than before (empty).
Caller can still expect zero on success and non-zero on error and act
accordingly.

xl list -l is now changed to print out the partial configuration, since it
needs to be consistent with the short output.

Wei.

Wei Liu (2):
  libxl: continue when encounter ERROR_JSON_CONFIG_EMPTY
  xl: print out partial configuration in long mode of list command

 tools/libxl/libxl.c  |6 +-
 tools/libxl/xl_cmdimpl.c |6 ++
 2 files changed, 7 insertions(+), 5 deletions(-)

-- 
1.7.10.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


Re: [Xen-devel] [PATCH for-4.5 0/2] xl/libxl: return and print partial config

2014-11-12 Thread Wei Liu
On Wed, Nov 12, 2014 at 02:54:00PM -0500, Zhigang Wang wrote:
 On 11/12/2014 12:04 PM, Wei Liu wrote:
  This small series change the behavior of 
  libxl_retrieve_domain_configuration,
  to make it continue to retrieve information from xenstore even if JSON 
  template
  is not available.
  
  This change of API behaviour is only internal. Conceptually speaking, any
  non-zero return value means d_config is partially filled. The chanage just
  makes it fill in more information (xenstore entries) than before (empty).
  Caller can still expect zero on success and non-zero on error and act
  accordingly.
  
  xl list -l is now changed to print out the partial configuration, since it
  needs to be consistent with the short output.
  
  Wei.
  
  Wei Liu (2):
libxl: continue when encounter ERROR_JSON_CONFIG_EMPTY
xl: print out partial configuration in long mode of list command
  
   tools/libxl/libxl.c  |6 +-
   tools/libxl/xl_cmdimpl.c |6 ++
   2 files changed, 7 insertions(+), 5 deletions(-)
  
 
 It seem some other places may need fix too. Here is the test result:
 
 # xl list -l
 libxl: error: libxl.c:4844:libxl__get_memory_target: cannot get target memory 
 info from /local/domain/1/memory/target
 : No such file or directory
 libxl: error: libxl.c:6582:libxl_retrieve_domain_configuration: fail to get 
 memory target for domain 1

Well, there's no such node in xenstore. There's nothing I can do about
it.

Wei.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel