Re: [Xen-devel] [PATCH for-4.7] docs: update xl manpage about {block, network}-attach command

2016-05-25 Thread Wei Liu 
On Wed, May 25, 2016 at 03:31:19PM +0100, Wei Liu wrote:
> On Wed, May 25, 2016 at 03:28:50PM +0100, Ian Jackson wrote:
> > Wei Liu writes ("Re: [PATCH for-4.7] docs: update xl manpage about 
> > {block,network}-attach command"):
> > > On Wed, May 25, 2016 at 03:15:23PM +0100, Ian Jackson wrote:
> > ...
> > > > But the vdev field specifies more than just the device type.  So I
> > > > think this is wrong.
> > > 
> > > I guess to make things simpler I can just delete the "" part?
> > > 
> > > "Note that only attaching PV block device is supported"
> > 
> > How about
> > 
> >   Note that only PV block devices are supported by block-attach.
> >   Requests to attach emulated devices (eg, vdev=hdc) will result in
> >   only the PV view being available to the guest.
> > 
> 
> LGTM. I will update the patch.
> 

This is the updated patch.

I will commit it soon.

---8<--
From 1bca93e2326e5a644f00de80a72bcab181587489 Mon Sep 17 00:00:00 2001
From: Wei Liu 
Date: Mon, 23 May 2016 12:07:20 +0100
Subject: [PATCH for-4.7 v2] docs: update xl manpage about 
{block,network}-attach command

State that only attaching PV interface is supported.

Signed-off-by: Wei Liu 
Signed-off-by: Ian Jackson 
---
Use Ian's wording about block-attach and add his S-o-B.
---
 docs/man/xl.pod.1 | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/docs/man/xl.pod.1 b/docs/man/xl.pod.1
index 9887f1b..f4dc32c 100644
--- a/docs/man/xl.pod.1
+++ b/docs/man/xl.pod.1
@@ -1286,6 +1286,10 @@ effect to the guest OS is much the same as any hotplug 
event.
 Create a new virtual block device.  This will trigger a hotplug event
 for the guest.
 
+Note that only PV block devices are supported by block-attach.
+Requests to attach emulated devices (eg, vdev=hdc) will result in only
+the PV view being available to the guest.
+
 B
 
 =over 4
@@ -1369,6 +1373,8 @@ B string in the domain config file. See L and
 L
 for more informations.
 
+Note that only attaching PV network interface is supported.
+
 =item B I I
 
 Removes the network device from the domain specified by I.
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.7] docs: update xl manpage about {block, network}-attach command

2016-05-25 Thread Wei Liu 
On Wed, May 25, 2016 at 03:28:50PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH for-4.7] docs: update xl manpage about 
> {block,network}-attach command"):
> > On Wed, May 25, 2016 at 03:15:23PM +0100, Ian Jackson wrote:
> ...
> > > But the vdev field specifies more than just the device type.  So I
> > > think this is wrong.
> > 
> > I guess to make things simpler I can just delete the "" part?
> > 
> > "Note that only attaching PV block device is supported"
> 
> How about
> 
>   Note that only PV block devices are supported by block-attach.
>   Requests to attach emulated devices (eg, vdev=hdc) will result in
>   only the PV view being available to the guest.
> 

LGTM. I will update the patch.

Wei.

> Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.7] docs: update xl manpage about {block, network}-attach command

2016-05-25 Thread Ian Jackson 
Wei Liu writes ("Re: [PATCH for-4.7] docs: update xl manpage about 
{block,network}-attach command"):
> On Wed, May 25, 2016 at 03:15:23PM +0100, Ian Jackson wrote:
...
> > But the vdev field specifies more than just the device type.  So I
> > think this is wrong.
> 
> I guess to make things simpler I can just delete the "" part?
> 
> "Note that only attaching PV block device is supported"

How about

  Note that only PV block devices are supported by block-attach.
  Requests to attach emulated devices (eg, vdev=hdc) will result in
  only the PV view being available to the guest.

Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.7] docs: update xl manpage about {block, network}-attach command

2016-05-25 Thread Ian Jackson 
Wei Liu writes ("[PATCH for-4.7] docs: update xl manpage about 
{block,network}-attach command"):
> State that only attaching PV interface is supported.
...
>  Create a new virtual block device.  This will trigger a hotplug event
> -for the guest.
> +for the guest. Note that only attaching PV block device is supported,
> +the B field is ignored.

But the vdev field specifies more than just the device type.  So I
think this is wrong.

Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.7] docs: update xl manpage about {block, network}-attach command

2016-05-25 Thread Wei Liu 
On Wed, May 25, 2016 at 03:15:23PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH for-4.7] docs: update xl manpage about 
> {block,network}-attach command"):
> > State that only attaching PV interface is supported.
> ...
> >  Create a new virtual block device.  This will trigger a hotplug event
> > -for the guest.
> > +for the guest. Note that only attaching PV block device is supported,
> > +the B field is ignored.
> 
> But the vdev field specifies more than just the device type.  So I
> think this is wrong.

I guess to make things simpler I can just delete the "" part?

"Note that only attaching PV block device is supported"

> 
> Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[Xen-devel] [PATCH for-4.7] docs: update xl manpage about {block, network}-attach command

2016-05-23 Thread Wei Liu 
State that only attaching PV interface is supported.

Signed-off-by: Wei Liu 
---
It's probably safe to claim the same for other device types, but I will just
stick with the ones I tested at this stage of the release.

Cc: Ian Jackson 
---
 docs/man/xl.pod.1 | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/docs/man/xl.pod.1 b/docs/man/xl.pod.1
index 9887f1b..290d8ed 100644
--- a/docs/man/xl.pod.1
+++ b/docs/man/xl.pod.1
@@ -1284,7 +1284,8 @@ effect to the guest OS is much the same as any hotplug 
event.
 =item B I I ...
 
 Create a new virtual block device.  This will trigger a hotplug event
-for the guest.
+for the guest. Note that only attaching PV block device is supported,
+the B field is ignored.
 
 B
 
@@ -1367,7 +1368,8 @@ Creates a new network device in the domain specified by 
I.
 I describes the device to attach, using the same format as the
 B string in the domain config file. See L and
 L
-for more informations.
+for more informations. Note that only attaching PV network interface is
+supported.
 
 =item B I I
 
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel