Re: [Xen-devel] [PATCH v1 06/13] x86: implement get value interface for MBA

2017-08-17 Thread Chao Peng 
On Wed, 2017-08-16 at 14:43 +0800, Yi Sun wrote:
> On 17-08-16 14:38:28, Chao Peng wrote:
> > 
> > On Wed, 2017-08-09 at 15:41 +0800, Yi Sun wrote:
> > > 
> > > This patch implements get value domctl interface for MBA.
> > > 
> > > Signed-off-by: Yi Sun 
> > > ---
> > 
> > ...
> > 
> > > 
> > > --- a/xen/include/public/domctl.h
> > > +++ b/xen/include/public/domctl.h
> > > @@ -1144,6 +1144,7 @@ struct xen_domctl_psr_alloc_op {
> > >  #define XEN_DOMCTL_PSR_CAT_OP_GET_L3_DATA5
> > >  #define XEN_DOMCTL_PSR_CAT_OP_SET_L2_CBM 6
> > >  #define XEN_DOMCTL_PSR_CAT_OP_GET_L2_CBM 7
> > > +#define XEN_DOMCTL_PSR_MBA_OP_GET_THRTL  9
> > 
> > Why use 9 instead of 8?
> > 
> 8 is reserved for SET_THRTL. Follow the convention of CAT/CDP above.
> :)

Understand. Then probably SET_THRTL patch should come first.

Chao

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v1 06/13] x86: implement get value interface for MBA

2017-08-16 Thread Yi Sun 
On 17-08-16 14:38:28, Chao Peng wrote:
> On Wed, 2017-08-09 at 15:41 +0800, Yi Sun wrote:
> > This patch implements get value domctl interface for MBA.
> > 
> > Signed-off-by: Yi Sun 
> > ---
> 
> ...
> 
> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > @@ -1144,6 +1144,7 @@ struct xen_domctl_psr_alloc_op {
> >  #define XEN_DOMCTL_PSR_CAT_OP_GET_L3_DATA5
> >  #define XEN_DOMCTL_PSR_CAT_OP_SET_L2_CBM 6
> >  #define XEN_DOMCTL_PSR_CAT_OP_GET_L2_CBM 7
> > +#define XEN_DOMCTL_PSR_MBA_OP_GET_THRTL  9
> 
> Why use 9 instead of 8?
> 
8 is reserved for SET_THRTL. Follow the convention of CAT/CDP above. :)

> Chao

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v1 06/13] x86: implement get value interface for MBA

2017-08-16 Thread Chao Peng 
On Wed, 2017-08-09 at 15:41 +0800, Yi Sun wrote:
> This patch implements get value domctl interface for MBA.
> 
> Signed-off-by: Yi Sun 
> ---

...

> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -1144,6 +1144,7 @@ struct xen_domctl_psr_alloc_op {
>  #define XEN_DOMCTL_PSR_CAT_OP_GET_L3_DATA5
>  #define XEN_DOMCTL_PSR_CAT_OP_SET_L2_CBM 6
>  #define XEN_DOMCTL_PSR_CAT_OP_GET_L2_CBM 7
> +#define XEN_DOMCTL_PSR_MBA_OP_GET_THRTL  9

Why use 9 instead of 8?

Chao

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v1 06/13] x86: implement get value interface for MBA

2017-08-09 Thread Yi Sun 
This patch implements get value domctl interface for MBA.

Signed-off-by: Yi Sun 
---
 xen/arch/x86/domctl.c   | 7 +++
 xen/include/public/domctl.h | 1 +
 2 files changed, 8 insertions(+)

diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index 850742a..fa5e6d4 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -1496,6 +1496,13 @@ long arch_do_domctl(
 copyback = true;
 break;
 
+case XEN_DOMCTL_PSR_MBA_OP_GET_THRTL:
+ret = psr_get_val(d, domctl->u.psr_alloc_op.target,
+  , PSR_VAL_TYPE_MBA);
+domctl->u.psr_alloc_op.data = val32;
+copyback = true;
+break;
+
 default:
 ret = -EOPNOTSUPP;
 break;
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 4bb4399..a577a3e 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -1144,6 +1144,7 @@ struct xen_domctl_psr_alloc_op {
 #define XEN_DOMCTL_PSR_CAT_OP_GET_L3_DATA5
 #define XEN_DOMCTL_PSR_CAT_OP_SET_L2_CBM 6
 #define XEN_DOMCTL_PSR_CAT_OP_GET_L2_CBM 7
+#define XEN_DOMCTL_PSR_MBA_OP_GET_THRTL  9
 uint32_t cmd;   /* IN: XEN_DOMCTL_PSR_CAT_OP_* */
 uint32_t target;/* IN */
 uint64_t data;  /* IN/OUT */
-- 
1.9.1


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel