Re: [Xen-devel] [PATCH v15 0/3] VT-d Device-TLB flush issue

[Andrew Cooper]

On 08/07/16 07:39, Jan Beulich wrote:
> From: Quan Xu 
>
> these patches fix current timeout concern and also allow limited ATS support.
>
> these patches are the rest ones:
> 1. move the domain crash logic up to the generic IOMMU layer
>
> 2. If Device-TLB flush timed out, we hide the target ATS device
>immediately. By hiding the device, we make sure it can't be
>assigned to any domain any longer (see device_assigned).
>
> Quan Xu (3):
>   IOMMU/ATS: use a struct pci_dev * instead of SBDF
>   IOMMU: add domain crash logic
>   VT-d: fix Device-TLB flush timeout issue

Committed, thanks.

~Andrew

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v15 0/3] VT-d Device-TLB flush issue

[Xu, Quan]

On July 08, 2016 2:52 PM, Jan Beulich  wrote:
> >>> On 08.07.16 at 08:39,  wrote:
> > From: Quan Xu 
> >
> > these patches fix current timeout concern and also allow limited ATS
> > support.
> >
> > these patches are the rest ones:
> > 1. move the domain crash logic up to the generic IOMMU layer
> >
> > 2. If Device-TLB flush timed out, we hide the target ATS device
> >immediately. By hiding the device, we make sure it can't be
> >assigned to any domain any longer (see device_assigned).
> >
> > Quan Xu (3):
> >   IOMMU/ATS: use a struct pci_dev * instead of SBDF
> >   IOMMU: add domain crash logic
> >   VT-d: fix Device-TLB flush timeout issue
> 
> I should probably have said somewhere that obviously I didn't test this for 
> the
> actual ATS case, as I don't have access to any suitable device. Therefore,
> alongside the necessary ack-s, it would be nice if we could also get a 
> Tested-by
> from someone who does have an ATS device.
> 

(today I just come back to return my laptop and while test it) thanks for your 
work and education :):)...

Tested-by: Quan Xu 

Quan
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v15 0/3] VT-d Device-TLB flush issue

[Jan Beulich]

>>> On 08.07.16 at 08:39,  wrote:
> From: Quan Xu 
> 
> these patches fix current timeout concern and also allow limited ATS 
> support.
> 
> these patches are the rest ones:
> 1. move the domain crash logic up to the generic IOMMU layer
> 
> 2. If Device-TLB flush timed out, we hide the target ATS device
>immediately. By hiding the device, we make sure it can't be
>assigned to any domain any longer (see device_assigned).
> 
> Quan Xu (3):
>   IOMMU/ATS: use a struct pci_dev * instead of SBDF
>   IOMMU: add domain crash logic
>   VT-d: fix Device-TLB flush timeout issue

I should probably have said somewhere that obviously I didn't test
this for the actual ATS case, as I don't have access to any suitable
device. Therefore, alongside the necessary ack-s, it would be nice
if we could also get a Tested-by from someone who does have an
ATS device.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v15 0/3] VT-d Device-TLB flush issue

[Jan Beulich]

From: Quan Xu 

these patches fix current timeout concern and also allow limited ATS support.

these patches are the rest ones:
1. move the domain crash logic up to the generic IOMMU layer

2. If Device-TLB flush timed out, we hide the target ATS device
   immediately. By hiding the device, we make sure it can't be
   assigned to any domain any longer (see device_assigned).

Quan Xu (3):
  IOMMU/ATS: use a struct pci_dev * instead of SBDF
  IOMMU: add domain crash logic
  VT-d: fix Device-TLB flush timeout issue
---
v15: Carried out my own review comments now that Quan left Intel.
---
Not covered in this series:

a) Eliminate the panic() in IOMMU_WAIT_OP, used only in VT-d register 
read/write.
   Further discussion is required on whether and how to improve it.
b) Handle IOTLB/Context/IEC flush timeout.



___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel