Re: [Xen-devel] [PATCH v2] arm/gic-v3: Fix ACPI probe fail on GICv4 hardware

2016-05-27 Thread Julien Grall 

Hello Shanker,

On 27/05/16 16:30, Shanker Donthineni wrote:

On 05/27/2016 10:10 AM, Julien Grall wrote:

On 27/05/16 16:00, Shanker Donthineni wrote:

The current driver ACPI probe fails on hardware which has GICv4
version, even though it is fully compatible to GICv3. This patch
fixes the issue by registering the same probe function for GICv4
hardware.

Signed-off-by: Shanker Donthineni 
---
Changes since v1:
 - Edit commit text.
 - Fix BUG() in xen/arch/arm/domain.c


Please see my latest comment on the previous version [1].

To go further, the ACPI tables may not represent the actual hardware. It is 
possible to have ACPI tables describing a GICv2 whilst the real hardware is a 
GICv3.


Yes, it is absolutely valid and UEFI firmware can decide what to be exported to 
OS by changing the version number in ACPI MADT table.

On Qualcomm Technologies QDF2XXX platforms, GIC version set to 4.


To be clear, I am not against adding support of GICv4 in Xen. My concern 
is how the patch add it. Exposing GICv4 beyond the GICv3 driver is not 
necessary today.


Better to keep as small as possible until we figure out how Xen will 
support GICv4 features.


I.e, the following the code should be enough.

ACPI_DEVICE_START(acgicv4, "GICv4", DEVICE_GIC)
   .class_type = ACPI_MADT_GIC_VERSION_V4,
   .init = gicv3_acpi_preinit,
ACPI_DEVICE_END




Xen will use the GICv2 driver and not the GICv3. So the helper will return 
GIC_V2 (and not GIC_V3).



The current xen is supporting both the GICv2 and GICv3 for ACPI based boot.

ACPI_DEVICE_START(agicv3, "GICv3", DEVICE_GIC)
 .class_type = ACPI_MADT_GIC_VERSION_V3,
 .init = gicv3_acpi_preinit,
ACPI_DEVICE_END

ACPI_DEVICE_START(agicv2, "GICv2", DEVICE_GIC)
 .class_type = ACPI_MADT_GIC_VERSION_V2,
 .init = gicv2_acpi_preinit,
ACPI_DEVICE_END


Regards,

--
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2] arm/gic-v3: Fix ACPI probe fail on GICv4 hardware

2016-05-27 Thread Shanker Donthineni 


On 05/27/2016 10:10 AM, Julien Grall wrote:
> Hello Shanker,
>
> On 27/05/16 16:00, Shanker Donthineni wrote:
>> The current driver ACPI probe fails on hardware which has GICv4
>> version, even though it is fully compatible to GICv3. This patch
>> fixes the issue by registering the same probe function for GICv4
>> hardware.
>>
>> Signed-off-by: Shanker Donthineni 
>> ---
>> Changes since v1:
>> - Edit commit text.
>> - Fix BUG() in xen/arch/arm/domain.c
>
> Please see my latest comment on the previous version [1].
>
> To go further, the ACPI tables may not represent the actual hardware. It is 
> possible to have ACPI tables describing a GICv2 whilst the real hardware is a 
> GICv3.
>
Yes, it is absolutely valid and UEFI firmware can decide what to be exported to 
OS by changing the version number in ACPI MADT table.

On Qualcomm Technologies QDF2XXX platforms, GIC version set to 4. 

> Xen will use the GICv2 driver and not the GICv3. So the helper will return 
> GIC_V2 (and not GIC_V3).
>

The current xen is supporting both the GICv2 and GICv3 for ACPI based boot.

ACPI_DEVICE_START(agicv3, "GICv3", DEVICE_GIC)
.class_type = ACPI_MADT_GIC_VERSION_V3,
.init = gicv3_acpi_preinit,
ACPI_DEVICE_END

ACPI_DEVICE_START(agicv2, "GICv2", DEVICE_GIC)
.class_type = ACPI_MADT_GIC_VERSION_V2,
.init = gicv2_acpi_preinit,
ACPI_DEVICE_END

> Regards,
>
> [1] https://www.mail-archive.com/xen-devel@lists.xen.org/msg69273.html
>

-- 
Shanker Donthineni
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux 
Foundation Collaborative Project


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2] arm/gic-v3: Fix ACPI probe fail on GICv4 hardware

2016-05-27 Thread Julien Grall 

Hello Shanker,

On 27/05/16 16:00, Shanker Donthineni wrote:

The current driver ACPI probe fails on hardware which has GICv4
version, even though it is fully compatible to GICv3. This patch
fixes the issue by registering the same probe function for GICv4
hardware.

Signed-off-by: Shanker Donthineni 
---
Changes since v1:
- Edit commit text.
- Fix BUG() in xen/arch/arm/domain.c


Please see my latest comment on the previous version [1].

To go further, the ACPI tables may not represent the actual hardware. It 
is possible to have ACPI tables describing a GICv2 whilst the real 
hardware is a GICv3.


Xen will use the GICv2 driver and not the GICv3. So the helper will 
return GIC_V2 (and not GIC_V3).


Regards,

[1] https://www.mail-archive.com/xen-devel@lists.xen.org/msg69273.html

--
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[Xen-devel] [PATCH v2] arm/gic-v3: Fix ACPI probe fail on GICv4 hardware

2016-05-27 Thread Shanker Donthineni 
The current driver ACPI probe fails on hardware which has GICv4
version, even though it is fully compatible to GICv3. This patch
fixes the issue by registering the same probe function for GICv4
hardware.

Signed-off-by: Shanker Donthineni 
---
Changes since v1:
   - Edit commit text.
   - Fix BUG() in xen/arch/arm/domain.c

This patch tested on Qualcomm Technologies on QDF2XXX platforms.

 xen/arch/arm/domain.c |  5 +
 xen/arch/arm/gic-v3.c | 13 +
 xen/include/asm-arm/gic.h |  1 +
 3 files changed, 19 insertions(+)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 1365b4a..5647b80 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -571,6 +571,11 @@ int arch_domain_create(struct domain *d, unsigned int 
domcr_flags,
 d->arch.vgic.version = GIC_V3;
 break;
 
+   case GIC_V4:
+config->gic_version = XEN_DOMCTL_CONFIG_GIC_V3;
+d->arch.vgic.version = GIC_V3;
+break;
+
 default:
 BUG();
 }
diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index a095064..594cf6e 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -1604,10 +1604,23 @@ static int __init gicv3_acpi_preinit(const void *data)
 return 0;
 }
 
+static int __init gicv4_acpi_preinit(const void *data)
+{
+gicv3_info.hw_version = GIC_V4;
+register_gic_ops(_ops);
+
+return 0;
+}
+
 ACPI_DEVICE_START(agicv3, "GICv3", DEVICE_GIC)
 .class_type = ACPI_MADT_GIC_VERSION_V3,
 .init = gicv3_acpi_preinit,
 ACPI_DEVICE_END
+
+ACPI_DEVICE_START(agicv4, "GICv4", DEVICE_GIC)
+.class_type = ACPI_MADT_GIC_VERSION_V4,
+.init = gicv4_acpi_preinit,
+ACPI_DEVICE_END
 #endif
 
 /*
diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
index cd97bb2..5be814a 100644
--- a/xen/include/asm-arm/gic.h
+++ b/xen/include/asm-arm/gic.h
@@ -218,6 +218,7 @@ struct gic_lr {
 enum gic_version {
 GIC_V2,
 GIC_V3,
+GIC_V4,
 };
 
 extern enum gic_version gic_hw_version(void);
-- 
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
a Linux Foundation Collaborative Project


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel