Re: [Xen-devel] [PATCH v2 0/4] Intel Code/Data Prioritization(CDP) feature enabling

2015-09-09 Thread Chao Peng
On Wed, Sep 09, 2015 at 01:16:44PM +0800, He Chen wrote:
> Changes in v2:
> - x86: Enable CDP by boot parameter instead of enabling/disabling CDP at
> runtime (suggested by Andrew)

As you added a new boot option, you also need a patch for
docs/misc/xen-command-line.markdown.

Chao
> - tools: remove psr-cat-cdp-enable/disable xl commands
> - code style
> 
> Code/Data Prioritization(CDP) is offered in Intel Broadwell and later server
> platforms, which is an extension of CAT. CDP enables isolation and separate
> prioritization of code and data fetches to the L3 cache in a software
> configurable manner, which can enable workload prioritization and tuning of
> cache capacity to the characteristics of the workload. CDP extends Cache
> Allocation Technology (CAT) by providing separate code and data capacity bit
> masks(CBM) per Class of Service (COS). CDP is used on VM basis in the Xen
> implementation.
> 
> More information about CDP, please refer to Intel SDM, Volumn 3, section 17.16
> http://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-manual-325462.pdf
> 
> This patch series enables CDP feature in Xen based on CAT code, and extends
> CBM operation functions to support CDP. For all the changes, please see in
> each patch.
> 
> This patchset has been tested on Intel Broadwell server platform.
> 
> To make this patchset better, any comment or suggestion is welcomed, I would
> really appreciate it.
> 
> Thanks
> 
> He Chen (4):
>   x86: Support enable CDP by boot parameter and add get CDP status
>   x86: add domctl cmd to set/get CDP code/data CBM
>   tools: add tools support for Intel CDP
>   docs: add document to introduce CDP command
> 
>  docs/man/xl.pod.1   |  14 +++
>  docs/misc/xl-psr.markdown   |  44 +++-
>  tools/libxc/include/xenctrl.h   |   7 +-
>  tools/libxc/xc_psr.c|  17 ++-
>  tools/libxl/libxl.h |  10 ++
>  tools/libxl/libxl_psr.c |  32 +-
>  tools/libxl/libxl_types.idl |   3 +
>  tools/libxl/xl.h|   2 +
>  tools/libxl/xl_cmdimpl.c|  52 +++--
>  tools/libxl/xl_cmdtable.c   |   5 +
>  xen/arch/x86/domctl.c   |  32 +-
>  xen/arch/x86/psr.c  | 237 
> 
>  xen/arch/x86/sysctl.c   |   5 +-
>  xen/include/asm-x86/msr-index.h |   3 +
>  xen/include/asm-x86/psr.h   |  23 +++-
>  xen/include/public/domctl.h |   4 +
>  xen/include/public/sysctl.h |   2 +
>  17 files changed, 420 insertions(+), 72 deletions(-)
> 
> -- 
> 1.9.1
> 
> 
> ___
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


Re: [Xen-devel] [PATCH v2 0/4] Intel Code/Data Prioritization(CDP) feature enabling

2015-09-09 Thread Ian Campbell
On Wed, 2015-09-09 at 15:37 +0800, Chao Peng wrote:
> On Wed, Sep 09, 2015 at 01:16:44PM +0800, He Chen wrote:
> > Changes in v2:
> > - x86: Enable CDP by boot parameter instead of enabling/disabling CDP
> > at
> > runtime (suggested by Andrew)
> 
> As you added a new boot option, you also need a patch for
> docs/misc/xen-command-line.markdown.

FYI this is (usually) best done in the patch which adds the option, rather
than in a separate patch.

Ian.


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


[Xen-devel] [PATCH v2 0/4] Intel Code/Data Prioritization(CDP) feature enabling

2015-09-08 Thread He Chen
Changes in v2:
- x86: Enable CDP by boot parameter instead of enabling/disabling CDP at
runtime (suggested by Andrew)
- tools: remove psr-cat-cdp-enable/disable xl commands
- code style

Code/Data Prioritization(CDP) is offered in Intel Broadwell and later server
platforms, which is an extension of CAT. CDP enables isolation and separate
prioritization of code and data fetches to the L3 cache in a software
configurable manner, which can enable workload prioritization and tuning of
cache capacity to the characteristics of the workload. CDP extends Cache
Allocation Technology (CAT) by providing separate code and data capacity bit
masks(CBM) per Class of Service (COS). CDP is used on VM basis in the Xen
implementation.

More information about CDP, please refer to Intel SDM, Volumn 3, section 17.16
http://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-manual-325462.pdf

This patch series enables CDP feature in Xen based on CAT code, and extends
CBM operation functions to support CDP. For all the changes, please see in
each patch.

This patchset has been tested on Intel Broadwell server platform.

To make this patchset better, any comment or suggestion is welcomed, I would
really appreciate it.

Thanks

He Chen (4):
  x86: Support enable CDP by boot parameter and add get CDP status
  x86: add domctl cmd to set/get CDP code/data CBM
  tools: add tools support for Intel CDP
  docs: add document to introduce CDP command

 docs/man/xl.pod.1   |  14 +++
 docs/misc/xl-psr.markdown   |  44 +++-
 tools/libxc/include/xenctrl.h   |   7 +-
 tools/libxc/xc_psr.c|  17 ++-
 tools/libxl/libxl.h |  10 ++
 tools/libxl/libxl_psr.c |  32 +-
 tools/libxl/libxl_types.idl |   3 +
 tools/libxl/xl.h|   2 +
 tools/libxl/xl_cmdimpl.c|  52 +++--
 tools/libxl/xl_cmdtable.c   |   5 +
 xen/arch/x86/domctl.c   |  32 +-
 xen/arch/x86/psr.c  | 237 
 xen/arch/x86/sysctl.c   |   5 +-
 xen/include/asm-x86/msr-index.h |   3 +
 xen/include/asm-x86/psr.h   |  23 +++-
 xen/include/public/domctl.h |   4 +
 xen/include/public/sysctl.h |   2 +
 17 files changed, 420 insertions(+), 72 deletions(-)

-- 
1.9.1


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel