Re: [Xen-devel] [PATCH v2 0/9] Rework gcov support in Xen

[Jan Beulich]

>>> On 10.10.16 at 17:47,  wrote:
> Wei Liu writes ("[PATCH v2 0/9] Rework gcov support in Xen"):
>> Since the hypervisor interface is sysctl, we have the liberty to not
>> care about backward compatibility. This series completely rewrites the
>> gcov support inside Xen.
> 
> I have looked at these patches.  One of them seemed in my bailiwick -
> the libxc tools patch, which I have acked.
> 
> If you feel my ack is needed for any of the build system parts, please
> feel free to add it.  I've looked at those and they don't seem
> controversial to me.
> 
> Can someone hypervisor-side confirm that this functionality is really
> disabled when the Kconfig is off, and so we don't need to worry about
> its security status ?

Well, I think I've done so by acking most of the patches. But in
any event this

subdir-$(CONFIG_GCOV) += gcov

in xen/common/Makefile ensures none of the code in that directory
would get built.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 0/9] Rework gcov support in Xen

[Ian Jackson]

Wei Liu writes ("[PATCH v2 0/9] Rework gcov support in Xen"):
> Since the hypervisor interface is sysctl, we have the liberty to not
> care about backward compatibility. This series completely rewrites the
> gcov support inside Xen.

I have looked at these patches.  One of them seemed in my bailiwick -
the libxc tools patch, which I have acked.

If you feel my ack is needed for any of the build system parts, please
feel free to add it.  I've looked at those and they don't seem
controversial to me.

Can someone hypervisor-side confirm that this functionality is really
disabled when the Kconfig is off, and so we don't need to worry about
its security status ?

Thanks,
Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v2 0/9] Rework gcov support in Xen

[Wei Liu]

The original implementation of gcov support in Xen has several
limitations:

1. The internal data structures are tied to gcc 3.4 format.
2. The sysctl interface is tied to gcc 3.4 format.
3. The gcov type definition is wrong, doesn't work with 32 bit
   hypervisor, which means arm32 wouldn't work.

Since the hypervisor interface is sysctl, we have the liberty to not
care about backward compatibility. This series completely rewrites the
gcov support inside Xen.

1. Support both gcc 3.4 and 4.7 format, configurable via Kconfig.
2. The sysctl interface is not tied to particular gcc format version.
3. Should work with arm32.

I have tested using both formats on x86. I was able to get gcov to
recognise the extracted data. I haven't really analyse the data in
detail though.

The patch series mostly consists of two parts. The meat is in the
first few patches. A few other patches are added to make available
automatic format detection.

There are still some rough edges, but I feel that this is good enough to post
so that people can review the sysctl interface.

This series can be found at:

git://xenbits.xen.org/people/liuw/xen.git wip.rework-gcov-v$VERSION

Wei.

---
v2: see individual commits for changes.

Cc: Andrew Cooper 
Cc: George Dunlap 
Cc: Ian Jackson 
Cc: Jan Beulich 
Cc: Konrad Rzeszutek Wilk 
Cc: Stefano Stabellini 
Cc: Tim Deegan 
Cc: Wei Liu 

Wei Liu (9):
  Kconfig: use tab instead of space
  Kconfig: add BROKEN config
  xen: delete gcno files in clean target
  xen, tools: rip out old gcov implementation
  gcov: add new interface and 3.4 and 4.7 format support
  gcov: userspace tools to extract and split gcov data
  Config.mk: expand cc-ver a bit
  Config.mk: introduce cc-ifversion
  gcov: provide the capability to select gcov format automatically

 Config.mk   |  13 +-
 tools/misc/xencov.c | 111 +++---
 tools/misc/xencov_split | 288 ---
 xen/Kconfig |   3 +
 xen/Kconfig.debug   |  36 -
 xen/Makefile|   2 +-
 xen/common/gcov/Makefile|   7 +-
 xen/common/gcov/gcc_3_4.c   | 363 
 xen/common/gcov/gcc_4_7.c   | 201 
 xen/common/gcov/gcov.c  | 308 -
 xen/common/gcov/gcov.h  |  36 +
 xen/common/gcov/gcov_base.c |  64 
 xen/common/sysctl.c |   7 +-
 xen/include/public/gcov.h   | 115 --
 xen/include/public/sysctl.h |  61 
 xen/include/xen/gcov.h  |  94 +---
 16 files changed, 1076 insertions(+), 633 deletions(-)
 create mode 100644 xen/common/gcov/gcc_3_4.c
 create mode 100644 xen/common/gcov/gcc_4_7.c
 create mode 100644 xen/common/gcov/gcov.h
 create mode 100644 xen/common/gcov/gcov_base.c
 delete mode 100644 xen/include/public/gcov.h

-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel