Re: [Xen-devel] [PATCH v2 06/15] x86: implement get value interface for MBA

[Roger Pau Monné]

On Thu, Aug 24, 2017 at 09:14:40AM +0800, Yi Sun wrote:
> This patch implements get value domctl interface for MBA.
> 
> Signed-off-by: Yi Sun 

Reviewed-by: Roger Pau Monné 

Just one minor comment...

> ---
>  xen/arch/x86/domctl.c   | 7 +++
>  xen/include/public/domctl.h | 1 +
>  2 files changed, 8 insertions(+)
> 
> diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
> index e1c7c70..4936bcb 100644
> --- a/xen/arch/x86/domctl.c
> +++ b/xen/arch/x86/domctl.c
> @@ -1496,6 +1496,13 @@ long arch_do_domctl(
>  copyback = true;
>  break;
>  
> +case XEN_DOMCTL_PSR_MBA_OP_GET_THRTL:
> +ret = psr_get_val(d, domctl->u.psr_alloc_op.target,
> +  , PSR_VAL_TYPE_MBA);
> +domctl->u.psr_alloc_op.data = val32;
> +copyback = true;
> +break;
> +
>  default:
>  ret = -EOPNOTSUPP;
>  break;
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index 4bb4399..a577a3e 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -1144,6 +1144,7 @@ struct xen_domctl_psr_alloc_op {
>  #define XEN_DOMCTL_PSR_CAT_OP_GET_L3_DATA5
>  #define XEN_DOMCTL_PSR_CAT_OP_SET_L2_CBM 6
>  #define XEN_DOMCTL_PSR_CAT_OP_GET_L2_CBM 7
> +#define XEN_DOMCTL_PSR_MBA_OP_GET_THRTL  9

I think the '_OP_' is not really meaningful here, but given the other
operations already have it...

>  uint32_t cmd;   /* IN: XEN_DOMCTL_PSR_CAT_OP_* */
>  uint32_t target;/* IN */
>  uint64_t data;  /* IN/OUT */
> -- 
> 1.9.1
> 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v2 06/15] x86: implement get value interface for MBA

[Yi Sun]

This patch implements get value domctl interface for MBA.

Signed-off-by: Yi Sun 
---
 xen/arch/x86/domctl.c   | 7 +++
 xen/include/public/domctl.h | 1 +
 2 files changed, 8 insertions(+)

diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index e1c7c70..4936bcb 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -1496,6 +1496,13 @@ long arch_do_domctl(
 copyback = true;
 break;
 
+case XEN_DOMCTL_PSR_MBA_OP_GET_THRTL:
+ret = psr_get_val(d, domctl->u.psr_alloc_op.target,
+  , PSR_VAL_TYPE_MBA);
+domctl->u.psr_alloc_op.data = val32;
+copyback = true;
+break;
+
 default:
 ret = -EOPNOTSUPP;
 break;
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 4bb4399..a577a3e 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -1144,6 +1144,7 @@ struct xen_domctl_psr_alloc_op {
 #define XEN_DOMCTL_PSR_CAT_OP_GET_L3_DATA5
 #define XEN_DOMCTL_PSR_CAT_OP_SET_L2_CBM 6
 #define XEN_DOMCTL_PSR_CAT_OP_GET_L2_CBM 7
+#define XEN_DOMCTL_PSR_MBA_OP_GET_THRTL  9
 uint32_t cmd;   /* IN: XEN_DOMCTL_PSR_CAT_OP_* */
 uint32_t target;/* IN */
 uint64_t data;  /* IN/OUT */
-- 
1.9.1


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel