Re: [Xen-devel] [PATCH v2 1/4] xen/arm: fix GIC_INVALID_LR

[Stefano Stabellini]

On Wed, 28 Dec 2016, Julien Grall wrote:
> Hi Stefano,
> 
> On 22/12/16 02:15, Stefano Stabellini wrote:
> > GIC_INVALID_LR should be 0xff, but actually, defined as ~(uint8_t)0, is
> > 0x. Fix the problem by placing the ~ operator before the cast.
> > 
> > Signed-off-by: Stefano Stabellini 
> 
> Reviewed-by: Julien Grall 

Thanks, I committed the fix

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 1/4] xen/arm: fix GIC_INVALID_LR

[Julien Grall]

Hi Stefano,

On 22/12/16 02:15, Stefano Stabellini wrote:

GIC_INVALID_LR should be 0xff, but actually, defined as ~(uint8_t)0, is
0x. Fix the problem by placing the ~ operator before the cast.

Signed-off-by: Stefano Stabellini 


Reviewed-by: Julien Grall 

Regards,

--
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v2 1/4] xen/arm: fix GIC_INVALID_LR

[Stefano Stabellini]

GIC_INVALID_LR should be 0xff, but actually, defined as ~(uint8_t)0, is
0x. Fix the problem by placing the ~ operator before the cast.

Signed-off-by: Stefano Stabellini 
---
 xen/include/asm-arm/vgic.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
index 672f649..467333c 100644
--- a/xen/include/asm-arm/vgic.h
+++ b/xen/include/asm-arm/vgic.h
@@ -69,7 +69,7 @@ struct pending_irq
 unsigned long status;
 struct irq_desc *desc; /* only set it the irq corresponds to a physical 
irq */
 unsigned int irq;
-#define GIC_INVALID_LR ~(uint8_t)0
+#define GIC_INVALID_LR (uint8_t)~0
 uint8_t lr;
 uint8_t priority;
 /* inflight is used to append instances of pending_irq to
-- 
1.9.1


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel