Re: [Xen-devel] [PATCH v2 16/16] xen/x86: mem_access: Fix mis-indented line

2017-09-21 Thread Jan Beulich 
>>> On 21.09.17 at 14:40,  wrote:
> --- a/xen/arch/x86/mm/mem_access.c
> +++ b/xen/arch/x86/mm/mem_access.c
> @@ -274,7 +274,7 @@ int p2m_set_altp2m_mem_access(struct domain *d, struct 
> p2m_domain *hp2m,
>  }
>  
>  return ap2m->set_entry(ap2m, gfn, mfn, PAGE_ORDER_4K, t, a,
> - (current->domain != d));
> +   (current->domain != d));

But once touching it, the stray parentheses could go away as well.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 16/16] xen/x86: mem_access: Fix mis-indented line

2017-09-21 Thread Razvan Cojocaru 
On 09/21/2017 03:40 PM, Julien Grall wrote:
> Signed-off-by: Julien Grall 
> 
> ---
> 
> Cc: Razvan Cojocaru 
> Cc: Tamas K Lengyel 
> Cc: George Dunlap 
> Cc: Jan Beulich 
> Cc: Andrew Cooper 

Acked-by: Razvan Cojocaru 


Thanks,
Razvan

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v2 16/16] xen/x86: mem_access: Fix mis-indented line

2017-09-21 Thread Julien Grall 
Signed-off-by: Julien Grall 

---

Cc: Razvan Cojocaru 
Cc: Tamas K Lengyel 
Cc: George Dunlap 
Cc: Jan Beulich 
Cc: Andrew Cooper 

Changes in v2:
- Patch added
---
 xen/arch/x86/mm/mem_access.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/mm/mem_access.c b/xen/arch/x86/mm/mem_access.c
index 948e377e69..5c1008890e 100644
--- a/xen/arch/x86/mm/mem_access.c
+++ b/xen/arch/x86/mm/mem_access.c
@@ -274,7 +274,7 @@ int p2m_set_altp2m_mem_access(struct domain *d, struct 
p2m_domain *hp2m,
 }
 
 return ap2m->set_entry(ap2m, gfn, mfn, PAGE_ORDER_4K, t, a,
- (current->domain != d));
+   (current->domain != d));
 }
 
 static int set_mem_access(struct domain *d, struct p2m_domain *p2m,
-- 
2.11.0


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel