Re: [Xen-devel] [PATCH v2 8/9] Config.mk: introduce cc-ifversion

2016-10-10 Thread Wei Liu 
On Mon, Oct 10, 2016 at 07:22:57AM -0600, Jan Beulich wrote:
> >>> On 10.10.16 at 15:18,  wrote:
> > On Mon, Oct 10, 2016 at 06:00:03AM -0600, Jan Beulich wrote:
> >> >>> On 10.10.16 at 11:40,  wrote:
> >> > It returns different string depending on compiler version.
> >> > 
> >> > No user yet.
> >> > 
> >> > Signed-off-by: Wei Liu 
> >> 
> >> Acked-by: Jan Beulich 
> >> albeit I wonder whether ...
> >> 
> >> > --- a/Config.mk
> >> > +++ b/Config.mk
> >> > @@ -128,6 +128,11 @@ define cc-ver-check-closure
> >> >  endif
> >> >  endef
> >> >  
> >> > +# cc-ifversion: Check compiler version and take branch accordingly
> >> > +# Usage $(call cc-ifversion,lt,0x040700,string_if_y,string_if_n)
> >> > +cc-ifversion = $(shell [ $(call cc-ver,$(CC),$(1),$(2)) = "y" ] \
> >> > +&& echo $(3) || echo $(4))
> >> 
> >> ... if-cc-version wouldn't be the better name.
> > 
> > Linux uses cc-ifversion. That's the naming scheme I followed.
> 
> Oh, I didn't realize you've taken it from elsewhere.
> 

The name, yes. Implementation, no.

I thought we always tried to stay close to Linux naming though...

Wei.

> Jan
> 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 8/9] Config.mk: introduce cc-ifversion

2016-10-10 Thread Jan Beulich 
>>> On 10.10.16 at 15:18,  wrote:
> On Mon, Oct 10, 2016 at 06:00:03AM -0600, Jan Beulich wrote:
>> >>> On 10.10.16 at 11:40,  wrote:
>> > It returns different string depending on compiler version.
>> > 
>> > No user yet.
>> > 
>> > Signed-off-by: Wei Liu 
>> 
>> Acked-by: Jan Beulich 
>> albeit I wonder whether ...
>> 
>> > --- a/Config.mk
>> > +++ b/Config.mk
>> > @@ -128,6 +128,11 @@ define cc-ver-check-closure
>> >  endif
>> >  endef
>> >  
>> > +# cc-ifversion: Check compiler version and take branch accordingly
>> > +# Usage $(call cc-ifversion,lt,0x040700,string_if_y,string_if_n)
>> > +cc-ifversion = $(shell [ $(call cc-ver,$(CC),$(1),$(2)) = "y" ] \
>> > +  && echo $(3) || echo $(4))
>> 
>> ... if-cc-version wouldn't be the better name.
> 
> Linux uses cc-ifversion. That's the naming scheme I followed.

Oh, I didn't realize you've taken it from elsewhere.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 8/9] Config.mk: introduce cc-ifversion

2016-10-10 Thread Wei Liu 
On Mon, Oct 10, 2016 at 06:00:03AM -0600, Jan Beulich wrote:
> >>> On 10.10.16 at 11:40,  wrote:
> > It returns different string depending on compiler version.
> > 
> > No user yet.
> > 
> > Signed-off-by: Wei Liu 
> 
> Acked-by: Jan Beulich 
> albeit I wonder whether ...
> 
> > --- a/Config.mk
> > +++ b/Config.mk
> > @@ -128,6 +128,11 @@ define cc-ver-check-closure
> >  endif
> >  endef
> >  
> > +# cc-ifversion: Check compiler version and take branch accordingly
> > +# Usage $(call cc-ifversion,lt,0x040700,string_if_y,string_if_n)
> > +cc-ifversion = $(shell [ $(call cc-ver,$(CC),$(1),$(2)) = "y" ] \
> > +   && echo $(3) || echo $(4))
> 
> ... if-cc-version wouldn't be the better name.
> 

Linux uses cc-ifversion. That's the naming scheme I followed.

Wei.

> Jan
> 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 8/9] Config.mk: introduce cc-ifversion

2016-10-10 Thread Jan Beulich 
>>> On 10.10.16 at 11:40,  wrote:
> It returns different string depending on compiler version.
> 
> No user yet.
> 
> Signed-off-by: Wei Liu 

Acked-by: Jan Beulich 
albeit I wonder whether ...

> --- a/Config.mk
> +++ b/Config.mk
> @@ -128,6 +128,11 @@ define cc-ver-check-closure
>  endif
>  endef
>  
> +# cc-ifversion: Check compiler version and take branch accordingly
> +# Usage $(call cc-ifversion,lt,0x040700,string_if_y,string_if_n)
> +cc-ifversion = $(shell [ $(call cc-ver,$(CC),$(1),$(2)) = "y" ] \
> + && echo $(3) || echo $(4))

... if-cc-version wouldn't be the better name.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v2 8/9] Config.mk: introduce cc-ifversion

2016-10-10 Thread Wei Liu 
It returns different string depending on compiler version.

No user yet.

Signed-off-by: Wei Liu 
---
Cc: Andrew Cooper 
Cc: George Dunlap 
Cc: Ian Jackson 
Cc: Jan Beulich 
Cc: Konrad Rzeszutek Wilk 
Cc: Stefano Stabellini 
Cc: Tim Deegan 
Cc: Wei Liu 
---
 Config.mk | 5 +
 1 file changed, 5 insertions(+)

diff --git a/Config.mk b/Config.mk
index af50137..844be0a 100644
--- a/Config.mk
+++ b/Config.mk
@@ -128,6 +128,11 @@ define cc-ver-check-closure
 endif
 endef
 
+# cc-ifversion: Check compiler version and take branch accordingly
+# Usage $(call cc-ifversion,lt,0x040700,string_if_y,string_if_n)
+cc-ifversion = $(shell [ $(call cc-ver,$(CC),$(1),$(2)) = "y" ] \
+   && echo $(3) || echo $(4))
+
 # Require GCC v4.1+
 check-$(gcc) = $(call cc-ver-check,CC,0x040100,"Xen requires at least gcc-4.1")
 $(eval $(check-y))
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel