Re: [Xen-devel] [Qemu-devel] [PATCH] xenpv: Fix qemu_uuid compiling error

2016-09-28 Thread Fam Zheng 
On Wed, 09/28 17:03, Stefano Stabellini wrote:
> On Tue, 27 Sep 2016, Eric Blake wrote:
> > On 09/27/2016 04:20 AM, Fam Zheng wrote:
> > > 9c5ce8db2 switched the type of qemu_uuid and this should have followed.
> > > Fix it.
> > > 
> > > Signed-off-by: Fam Zheng 
> > > ---
> > >  hw/xenpv/xen_domainbuild.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Reviewed-by: Eric Blake 
> 
> Acked-by: Stefano Stabellini 

Queued for next pull request, thanks.

Fam

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [Qemu-devel] [PATCH] xenpv: Fix qemu_uuid compiling error

2016-09-28 Thread Stefano Stabellini 
On Tue, 27 Sep 2016, Eric Blake wrote:
> On 09/27/2016 04:20 AM, Fam Zheng wrote:
> > 9c5ce8db2 switched the type of qemu_uuid and this should have followed.
> > Fix it.
> > 
> > Signed-off-by: Fam Zheng 
> > ---
> >  hw/xenpv/xen_domainbuild.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Eric Blake 

Acked-by: Stefano Stabellini 


> > 
> > diff --git a/hw/xenpv/xen_domainbuild.c b/hw/xenpv/xen_domainbuild.c
> > index b439b0e..457a897 100644
> > --- a/hw/xenpv/xen_domainbuild.c
> > +++ b/hw/xenpv/xen_domainbuild.c
> > @@ -232,7 +232,7 @@ int xen_domain_build_pv(const char *kernel, const char 
> > *ramdisk,
> >  unsigned long xenstore_mfn = 0, console_mfn = 0;
> >  int rc;
> >  
> > -memcpy(uuid, qemu_uuid, sizeof(uuid));
> > +memcpy(uuid, _uuid, sizeof(uuid));
> >  rc = xen_domain_create(xen_xc, ssidref, uuid, flags, _domid);
> >  if (rc < 0) {
> >  fprintf(stderr, "xen: xc_domain_create() failed\n");
> > 
> 
> -- 
> Eric Blake   eblake redhat com+1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 
> 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [Qemu-devel] [PATCH] xenpv: Fix qemu_uuid compiling error

2016-09-27 Thread Eric Blake 
On 09/27/2016 04:20 AM, Fam Zheng wrote:
> 9c5ce8db2 switched the type of qemu_uuid and this should have followed.
> Fix it.
> 
> Signed-off-by: Fam Zheng 
> ---
>  hw/xenpv/xen_domainbuild.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake 

> 
> diff --git a/hw/xenpv/xen_domainbuild.c b/hw/xenpv/xen_domainbuild.c
> index b439b0e..457a897 100644
> --- a/hw/xenpv/xen_domainbuild.c
> +++ b/hw/xenpv/xen_domainbuild.c
> @@ -232,7 +232,7 @@ int xen_domain_build_pv(const char *kernel, const char 
> *ramdisk,
>  unsigned long xenstore_mfn = 0, console_mfn = 0;
>  int rc;
>  
> -memcpy(uuid, qemu_uuid, sizeof(uuid));
> +memcpy(uuid, _uuid, sizeof(uuid));
>  rc = xen_domain_create(xen_xc, ssidref, uuid, flags, _domid);
>  if (rc < 0) {
>  fprintf(stderr, "xen: xc_domain_create() failed\n");
> 

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel