Re: [Xen-devel] Backport request for tools/hotplug: set mtu from bridge for tap interface - for Xen 4.4, 4.5, and unstable
Add quotes around $bridge and $dev to handle spaces in names. This should go into 4.4, 4.5 and unstable. Signed-off-by: Charles Arnold carn...@suse.com diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-bridge index 3d72ca4..8b67b0a 100644 --- a/tools/hotplug/Linux/vif-bridge +++ b/tools/hotplug/Linux/vif-bridge @@ -77,7 +77,7 @@ fi case $command in online) setup_virtual_bridge_port $dev -set_mtu $bridge $dev +set_mtu $bridge $dev add_to_bridge $bridge $dev ;; @@ -88,7 +88,7 @@ case $command in add) setup_virtual_bridge_port $dev -set_mtu $bridge $dev +set_mtu $bridge $dev add_to_bridge $bridge $dev ;; esac ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] Backport request for tools/hotplug: set mtu from bridge for tap interface - for Xen 4.4, 4.5, and unstable
Hello, On 12.01.2015 18:03, Ian Jackson wrote: Charles Arnold writes (Re: Backport request for tools/hotplug: set mtu from bridge for tap interface - for Xen 4.4, 4.5, and unstable): Add quotes around $bridge and $dev to handle spaces in names. This should go into 4.4, 4.5 and unstable. Is this really necessary for backporting ? Frankly I think if you put spaces in your network device names an awful lot of things are going to break. Luckily for you at least Linux does not allow space characters in interface names: net/core/dev.c:936 dev_valid_name On the other hand I find not caring about quoting somehow dangerous, as I already expeienced one desaster caused by missing quotes. Just my 2ยข. Philipp ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] Backport request for tools/hotplug: set mtu from bridge for tap interface - for Xen 4.4, 4.5, and unstable
Charles Arnold writes (Re: Backport request for tools/hotplug: set mtu from bridge for tap interface - for Xen 4.4, 4.5, and unstable): Add quotes around $bridge and $dev to handle spaces in names. This should go into 4.4, 4.5 and unstable. Is this really necessary for backporting ? Frankly I think if you put spaces in your network device names an awful lot of things are going to break. Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] Backport request for tools/hotplug: set mtu from bridge for tap interface - for Xen 4.4, 4.5, and unstable
On 1/12/2015 at 10:03 AM, Ian Jackson ian.jack...@eu.citrix.com wrote: Charles Arnold writes (Re: Backport request for tools/hotplug: set mtu from bridge for tap interface - for Xen 4.4, 4.5, and unstable): Add quotes around $bridge and $dev to handle spaces in names. This should go into 4.4, 4.5 and unstable. Is this really necessary for backporting ? Frankly I think if you put spaces in your network device names an awful lot of things are going to break. You are probably right. The change was also for consistency in how the variables are used elsewhere in the script. - Charles ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
