Re: [Xen-devel] [OSSTEST PATCH v3 20/25] mfi-common: create xtf build job for 4.4 onwards
Wei Liu writes ("Re: [OSSTEST PATCH v3 20/25] mfi-common: create xtf build job
for 4.4 onwards"):
> On Thu, Sep 08, 2016 at 06:41:26PM +0100, Ian Jackson wrote:
> > What is the deployment situation ? See my previous emails about
> > mg-branch-setup.
>
> I'm not sure I know what INITIAL-TESTED-VERSION does. Let's have a
> conversation IRL and I will write down something where appropriate.
mg-branch-setup is the tool which sets up an instance of the push gate
machinery.
We are creating a new push gate for xtf. That is, there will be both
a staging branch and an osstest-tested branch. If the osstest-tested
branch were to be missing, the push gate runs will bomb out during
flight construction.
So mg-branch-setup helpfully reminds its user (via its usage message)
that something should perhaps be pushed there. Ie, if one passes it
an INITIAL-TESTED-VERSION, which should usually be a git commit hash,
then that hash is pushed to the osstest-tested branch.
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
Re: [Xen-devel] [OSSTEST PATCH v3 20/25] mfi-common: create xtf build job for 4.4 onwards
On Thu, Sep 08, 2016 at 06:41:26PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [OSSTEST PATCH v3 20/25] mfi-common: create xtf build
> job for 4.4 onwards"):
> > The following fixup patch is required to properly filter out unnecessary
> > branches.
>
> Right.
>
> AFAICT the diff you present is of the results of the original v3 20/25
> plus your fixup patch ? If so, it looks good.
>
> > There will be one further fixup patch to another patch to switch to use
> > branch_wants_xtf_tests. I will post that separately.
>
Yes.
> What is the deployment situation ? See my previous emails about
> mg-branch-setup.
>
I'm not sure I know what INITIAL-TESTED-VERSION does. Let's have a
conversation IRL and I will write down something where appropriate.
Wei.
> Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
Re: [Xen-devel] [OSSTEST PATCH v3 20/25] mfi-common: create xtf build job for 4.4 onwards
Wei Liu writes ("Re: [OSSTEST PATCH v3 20/25] mfi-common: create xtf build job
for 4.4 onwards"):
> The following fixup patch is required to properly filter out unnecessary
> branches.
Right.
AFAICT the diff you present is of the results of the original v3 20/25
plus your fixup patch ? If so, it looks good.
> There will be one further fixup patch to another patch to switch to use
> branch_wants_xtf_tests. I will post that separately.
What is the deployment situation ? See my previous emails about
mg-branch-setup.
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
Re: [Xen-devel] [OSSTEST PATCH v3 20/25] mfi-common: create xtf build job for 4.4 onwards
On Tue, Sep 06, 2016 at 03:06:02PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[OSSTEST PATCH v3 20/25] mfi-common: create xtf build job
> for 4.4 onwards"):
> > Xen 4.4 is the oldest one that we still provide security support at this
> > point in time.
> >
> > Signed-off-by: Wei Liu
>
> This ought to come with a diff, showing the change to the output of
> standalone-generate-dump-flight-runvars. (Consider use of `eatmydata'
> and AP_FETCH_MEMO_KEEP=1, as discussed in 74d81dca.)
>
> Thanks,
> Ian.
The following fixup patch is required to properly filter out unnecessary
branches.
There will be one further fixup patch to another patch to switch to use
branch_wants_xtf_tests. I will post that separately.
From 074237a5b152d7f772b53594732bcc6946dc31ed Mon Sep 17 00:00:00 2001
From: Wei Liu
Date: Thu, 8 Sep 2016 17:50:14 +0100
Subject: [OSSTEST PATCH] fixup! mfi-common: create xtf build job for 4.4
onwards
Cc: ian.jack...@eu.citrix.com
---
mfi-common | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/mfi-common b/mfi-common
index 0864266..00921c4 100644
--- a/mfi-common
+++ b/mfi-common
@@ -67,15 +67,16 @@ xenbranch_xsm_variants () {
esac
}
-xenbranch_wants_xtf_tests () {
-case "$xenbranch" in
-xen-3.*-testing) return 1;;
-xen-4.0-testing) return 1;;
-xen-4.1-testing) return 1;;
-xen-4.2-testing) return 1;;
-xen-4.3-testing) return 1;;
-*) return 0;;
-esac
+branch_wants_xtf_tests () {
+ case "$branch" in
+xen-3.*-testing) return 1 ;;
+xen-4.0-testing) return 1 ;;
+xen-4.1-testing) return 1 ;;
+xen-4.2-testing) return 1 ;;
+xen-4.3-testing) return 1 ;;
+xen-*) return 0;;
+*) return 1 ;;
+ esac
}
job_create_build () {
@@ -276,7 +277,7 @@ create_build_jobs () {
fi
-if xenbranch_wants_xtf_tests; then
+if branch_wants_xtf_tests; then
# Only x86, build once for amd64 and use the same result for
# both amd64 and i386
if [ x$arch = xamd64 ] ; then
--
2.1.4
And now the diff of new stuff in database:
--- /proc/self/fd/112016-09-08 17:59:55.664055563 +0100
+++ /proc/self/fd/122016-09-08 17:59:55.664055563 +0100
@@ -18554,6 +18554,13 @@
xen-4.4-testingbuild-amd64-xend tree_qemu
git://xenbits.xen.org/qemu-xen-traditional.git
xen-4.4-testingbuild-amd64-xend
tree_qemuu git://xenbits.xen.org/qemu-xen.git
xen-4.4-testingbuild-amd64-xend tree_xen
git://xenbits.xen.org/xen.git
+xen-4.4-testingbuild-amd64-xtf
all_host_di_version current
+xen-4.4-testingbuild-amd64-xtf
all_host_suite wheezy
+xen-4.4-testingbuild-amd64-xtf arch
amd64
+xen-4.4-testingbuild-amd64-xtf
build_lvextend_max 50
+xen-4.4-testingbuild-amd64-xtf
host_hostflags
share-build-wheezy-amd64,arch-amd64,suite-wheezy,purpose-build
+xen-4.4-testingbuild-amd64-xtf
revision_xtf
+xen-4.4-testingbuild-amd64-xtf tree_xtf
git://xenbits.xen.org/people/liuw/xtf.git
xen-4.4-testingbuild-armhf
all_host_di_version current
xen-4.4-testingbuild-armhf
all_host_suite wheezy
xen-4.4-testingbuild-armhf arch
armhf
@@ -19441,6 +19448,13 @@
xen-4.5-testingbuild-amd64
tree_qemuu git://xenbits.xen.org/qemu-xen.git
xen-4.5-testingbuild-amd64
tree_seabios
xen-4.5-testingbuild-amd64 tree_xen
git://xenbits.xen.org/xen.git
Re: [Xen-devel] [OSSTEST PATCH v3 20/25] mfi-common: create xtf build job for 4.4 onwards
Wei Liu writes ("[OSSTEST PATCH v3 20/25] mfi-common: create xtf build job for
4.4 onwards"):
> Xen 4.4 is the oldest one that we still provide security support at this
> point in time.
>
> Signed-off-by: Wei Liu
This ought to come with a diff, showing the change to the output of
standalone-generate-dump-flight-runvars. (Consider use of `eatmydata'
and AP_FETCH_MEMO_KEEP=1, as discussed in 74d81dca.)
Thanks,
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
