Re: [Xen-devel] [PATCH] gitignore: Don't ignore *.rej

2015-08-13 Thread Ian Campbell
On Wed, 2015-08-12 at 16:21 +0100, Ian Jackson wrote:
 Konrad Rzeszutek Wilk writes (Re: [Xen-devel] [PATCH] gitignore: Don't 
 ignore *.rej):
  On Wed, Aug 12, 2015 at 10:07:37AM +0100, Ian Campbell wrote:
   These indicate a patch application went wrong, I want to see them in
   git status. This appears to have been imported from .hgignore where
   it has been since 2005.
   
   Signed-off-by: Ian Campbell ian.campb...@citrix.com
   Cc: Daniel Kiper daniel.ki...@oracle.com
  
  Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com
 
 Acked-by: Ian Jackson ian.jack...@eu.citrix.com
 
 (As an aside, I would normally apply a `usual' kind of trivial
 .gitignore update without waiting for any kind of ack.  But this one
 seems not entirely trivial.)

Right, I thought it might even be controversial, but it seems not. I've
applied.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


Re: [Xen-devel] [PATCH] gitignore: Don't ignore *.rej

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:07:37AM +0100, Ian Campbell wrote:
 These indicate a patch application went wrong, I want to see them in
 git status. This appears to have been imported from .hgignore where
 it has been since 2005.
 
 Signed-off-by: Ian Campbell ian.campb...@citrix.com
 Cc: Daniel Kiper daniel.ki...@oracle.com

Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com
 ---
 Spotted while accidentally reviewing Daniel's patch against grub's
 .gitignore.
 ---
  .gitignore | 1 -
  1 file changed, 1 deletion(-)
 
 diff --git a/.gitignore b/.gitignore
 index bccbd12..dafa3c4 100644
 --- a/.gitignore
 +++ b/.gitignore
 @@ -1,6 +1,5 @@
  .hg
  *.orig
 -*.rej
  *~
  *.swp
  *.o
 -- 
 2.1.4
 
 
 ___
 Xen-devel mailing list
 Xen-devel@lists.xen.org
 http://lists.xen.org/xen-devel

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


Re: [Xen-devel] [PATCH] gitignore: Don't ignore *.rej

2015-08-12 Thread Ian Jackson
Konrad Rzeszutek Wilk writes (Re: [Xen-devel] [PATCH] gitignore: Don't ignore 
*.rej):
 On Wed, Aug 12, 2015 at 10:07:37AM +0100, Ian Campbell wrote:
  These indicate a patch application went wrong, I want to see them in
  git status. This appears to have been imported from .hgignore where
  it has been since 2005.
  
  Signed-off-by: Ian Campbell ian.campb...@citrix.com
  Cc: Daniel Kiper daniel.ki...@oracle.com
 
 Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com

Acked-by: Ian Jackson ian.jack...@eu.citrix.com

(As an aside, I would normally apply a `usual' kind of trivial
.gitignore update without waiting for any kind of ack.  But this one
seems not entirely trivial.)

Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


Re: [Xen-devel] [PATCH] gitignore: Don't ignore *.rej

2015-08-12 Thread Daniel Kiper
On Wed, Aug 12, 2015 at 10:07:37AM +0100, Ian Campbell wrote:
 These indicate a patch application went wrong, I want to see them in
 git status. This appears to have been imported from .hgignore where
 it has been since 2005.

 Signed-off-by: Ian Campbell ian.campb...@citrix.com
 Cc: Daniel Kiper daniel.ki...@oracle.com
 ---
 Spotted while accidentally reviewing Daniel's patch against grub's
 .gitignore.

Reviewed-by: Daniel Kiper daniel.ki...@oracle.com

Daniel

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel