Re: [Xen-devel] [PATCH 00/13] tools: do cleanups related to libxc python bindings

[Juergen Gross]

On 16/11/15 13:09, Ian Campbell wrote:
> On Thu, 2015-11-12 at 13:01 +, Wei Liu wrote:
>> On Mon, Nov 09, 2015 at 04:19:24PM +0100, Juergen Gross wrote:
>>> On 10/23/2015 03:04 PM, Juergen Gross wrote:
 This series is a combination of my previous patches:

 "libxc: remove most of tools/libxc/xc_dom_compat_linux.c"
 "tools: remove unused wrappers for python"

 I have split it up as requested by Ian Campbell, thus it consists of
 13 patches instead just of 2, but the functionality is roughly the
 same. I have just kept more python bindings compared to the first
 version, as there have been reports of some out of tree uses. Asking
 for more such use case on xen-devel and xen-user didn't result in
 requests for more interfaces to be kept, so I delete them.
>>>
>>> There have been acks and critical responses regarding this series.
> 
> Have there? I don't have the stashed alongside the series as I would
> normally, so maybe I've missed them?

At least on #xendevel there was a rather clear statement towards not
removing code without any need, even if unused. This statement has not
been rejected by others.

I still think the python wrappers used by nobody are something we
should get rid of, OTOH I don't want to fight really hard for it. :-)

> 
>>> What should we do?
>>>
>>> - drop them all
>>> - apply the first two patches only to get rid of the extra interfaces
>>>   to the domain builder as requested by Ian Campbell
>>
>> I would go for this.
> 
> I've done this one.

Thanks.


Juergen


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 00/13] tools: do cleanups related to libxc python bindings

[Ian Campbell]

On Mon, 2015-11-16 at 13:30 +0100, Juergen Gross wrote:
> On 16/11/15 13:09, Ian Campbell wrote:
> > On Thu, 2015-11-12 at 13:01 +, Wei Liu wrote:
> > > On Mon, Nov 09, 2015 at 04:19:24PM +0100, Juergen Gross wrote:
> > > > On 10/23/2015 03:04 PM, Juergen Gross wrote:
> > > > > This series is a combination of my previous patches:
> > > > > 
> > > > > "libxc: remove most of tools/libxc/xc_dom_compat_linux.c"
> > > > > "tools: remove unused wrappers for python"
> > > > > 
> > > > > I have split it up as requested by Ian Campbell, thus it consists
> > > > > of
> > > > > 13 patches instead just of 2, but the functionality is roughly
> > > > > the
> > > > > same. I have just kept more python bindings compared to the first
> > > > > version, as there have been reports of some out of tree uses.
> > > > > Asking
> > > > > for more such use case on xen-devel and xen-user didn't result in
> > > > > requests for more interfaces to be kept, so I delete them.
> > > > 
> > > > There have been acks and critical responses regarding this series.
> > 
> > Have there? I don't have the stashed alongside the series as I would
> > normally, so maybe I've missed them?
> 
> At least on #xendevel there was a rather clear statement towards not
> removing code without any need, even if unused. This statement has not
> been rejected by others.

Part of me thinks that such statements made on #xendevel may as well not
have been made as far as the formal review process goes.

But...

> I still think the python wrappers used by nobody are something we
> should get rid of, OTOH I don't want to fight really hard for it. :-)

... I think this is the right approach when dealing with such removals,
i.e. to try and abort upon valid complaints.

Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 00/13] tools: do cleanups related to libxc python bindings

[Ian Campbell]

On Thu, 2015-11-12 at 13:01 +, Wei Liu wrote:
> On Mon, Nov 09, 2015 at 04:19:24PM +0100, Juergen Gross wrote:
> > On 10/23/2015 03:04 PM, Juergen Gross wrote:
> > > This series is a combination of my previous patches:
> > > 
> > > "libxc: remove most of tools/libxc/xc_dom_compat_linux.c"
> > > "tools: remove unused wrappers for python"
> > > 
> > > I have split it up as requested by Ian Campbell, thus it consists of
> > > 13 patches instead just of 2, but the functionality is roughly the
> > > same. I have just kept more python bindings compared to the first
> > > version, as there have been reports of some out of tree uses. Asking
> > > for more such use case on xen-devel and xen-user didn't result in
> > > requests for more interfaces to be kept, so I delete them.
> > 
> > There have been acks and critical responses regarding this series.

Have there? I don't have the stashed alongside the series as I would
normally, so maybe I've missed them?

> > What should we do?
> > 
> > - drop them all
> > - apply the first two patches only to get rid of the extra interfaces
> >   to the domain builder as requested by Ian Campbell
> 
> I would go for this.

I've done this one.

Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 00/13] tools: do cleanups related to libxc python bindings

[Wei Liu]

On Mon, Nov 09, 2015 at 04:19:24PM +0100, Juergen Gross wrote:
> On 10/23/2015 03:04 PM, Juergen Gross wrote:
> >This series is a combination of my previous patches:
> >
> >"libxc: remove most of tools/libxc/xc_dom_compat_linux.c"
> >"tools: remove unused wrappers for python"
> >
> >I have split it up as requested by Ian Campbell, thus it consists of
> >13 patches instead just of 2, but the functionality is roughly the
> >same. I have just kept more python bindings compared to the first
> >version, as there have been reports of some out of tree uses. Asking
> >for more such use case on xen-devel and xen-user didn't result in
> >requests for more interfaces to be kept, so I delete them.
> 
> There have been acks and critical responses regarding this series.
> 
> What should we do?
> 
> - drop them all
> - apply the first two patches only to get rid of the extra interfaces
>   to the domain builder as requested by Ian Campbell

I would go for this.

Wei.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 00/13] tools: do cleanups related to libxc python bindings

[Juergen Gross]

On 10/23/2015 03:04 PM, Juergen Gross wrote:

This series is a combination of my previous patches:

"libxc: remove most of tools/libxc/xc_dom_compat_linux.c"
"tools: remove unused wrappers for python"

I have split it up as requested by Ian Campbell, thus it consists of
13 patches instead just of 2, but the functionality is roughly the
same. I have just kept more python bindings compared to the first
version, as there have been reports of some out of tree uses. Asking
for more such use case on xen-devel and xen-user didn't result in
requests for more interfaces to be kept, so I delete them.


There have been acks and critical responses regarding this series.

What should we do?

- drop them all
- apply the first two patches only to get rid of the extra interfaces
  to the domain builder as requested by Ian Campbell
- apply all of them


Juergen



Juergen Gross (13):
   libxc: remove most of tools/libxc/xc_dom_compat_linux.c
   libxc: remove xc_get_bit_size() from tools/libxc/xc_dom_compat_linux.c
   python: remove flask related libxc python bindings
   python: remove cpupool related libxc python bindings
   python: remove cpuid related libxc python bindings
   python: remove device related libxc python bindings
   python: remove scheduler related libxc python bindings
   python: remove unused memory related libxc python bindings
   python: remove domain handling related libxc python bindings
   python: remove vcpu related libxc python bindings
   python: remove hvm related libxc python bindings
   python: remove  permission related libxc python bindings
   python: remove unused other libxc python bindings

  tools/libxc/include/xc_dom.h  |5 +
  tools/libxc/include/xenguest.h|   52 -
  tools/libxc/xc_dom_compat_linux.c |  142 +-
  tools/libxl/libxl_internal.h  |1 +
  tools/python/xen/lowlevel/xc/xc.c | 2624 +++--
  5 files changed, 170 insertions(+), 2654 deletions(-)




___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 00/13] tools: do cleanups related to libxc python bindings

[Wei Liu]

On Fri, Oct 23, 2015 at 03:04:59PM +0200, Juergen Gross wrote:
> This series is a combination of my previous patches:
> 
> "libxc: remove most of tools/libxc/xc_dom_compat_linux.c" 
> "tools: remove unused wrappers for python"
> 
> I have split it up as requested by Ian Campbell, thus it consists of
> 13 patches instead just of 2, but the functionality is roughly the
> same. I have just kept more python bindings compared to the first
> version, as there have been reports of some out of tree uses. Asking
> for more such use case on xen-devel and xen-user didn't result in
> requests for more interfaces to be kept, so I delete them.
> 
> Juergen Gross (13):
>   libxc: remove most of tools/libxc/xc_dom_compat_linux.c
>   libxc: remove xc_get_bit_size() from tools/libxc/xc_dom_compat_linux.c
>   python: remove flask related libxc python bindings
>   python: remove cpupool related libxc python bindings
>   python: remove cpuid related libxc python bindings
>   python: remove device related libxc python bindings
>   python: remove scheduler related libxc python bindings
>   python: remove unused memory related libxc python bindings
>   python: remove domain handling related libxc python bindings
>   python: remove vcpu related libxc python bindings
>   python: remove hvm related libxc python bindings
>   python: remove  permission related libxc python bindings
>   python: remove unused other libxc python bindings
> 

I think it's good riddance of dead code.  I only skim this series since
they look rather low risk to me.  If anyone shouts we can easily
resurrect necessary bits from git history.

So whole series:

Acked-by: Wei Liu 

Wei.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel