Re: [Xen-devel] [PATCH 5/6] common/gnttab: gnttab_query_size() cleanup

2017-08-15 Thread Andrew Cooper 
On 15/08/17 14:56, Jan Beulich wrote:
 On 15.08.17 at 14:30,  wrote:
>> --- a/xen/common/grant_table.c
>> +++ b/xen/common/grant_table.c
>> @@ -1731,31 +1731,25 @@ gnttab_query_size(
>>  XEN_GUEST_HANDLE_PARAM(gnttab_query_size_t) uop, unsigned int count)
>>  {
>>  struct gnttab_query_size op;
>> -struct domain *d;
>> -int rc;
>> +struct domain *d = NULL;
> There's no need to add an initializer here afaict.

Oh yes - so there isn't.

>  Other than that
> Reviewed-by: Jan Beulich 

Thanks.

~Andrew

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 5/6] common/gnttab: gnttab_query_size() cleanup

2017-08-15 Thread Jan Beulich 
>>> On 15.08.17 at 14:30,  wrote:
> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -1731,31 +1731,25 @@ gnttab_query_size(
>  XEN_GUEST_HANDLE_PARAM(gnttab_query_size_t) uop, unsigned int count)
>  {
>  struct gnttab_query_size op;
> -struct domain *d;
> -int rc;
> +struct domain *d = NULL;

There's no need to add an initializer here afaict. Other than that
Reviewed-by: Jan Beulich 

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel