Re: [Xen-devel] [PATCH v2 0/3] arm64: Add multiboot support (via fdt) for Xen boot

2015-07-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko 
On 13.07.2015 10:53, fu@linaro.org wrote:
 From: Fu Wei fu@linaro.org
 
   - This adds support for the Xen boot on ARM specification for arm64.
 
   - The implementation for Xen is following  Multiboot on ARM Specification:
 http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot
 and xen/docs/misc/arm/device-tree/booting.txt in Xen source code.
 
   - The multiboot/module commands have existed, so we use 
 xen_hypervisor/xen_module instead.
 
   - This Xen boot support is built into linux module for aarch64,
 and can not be used alone.
 
   - Adding this functionality to the existing linux module is for
 reusing the existing code of devicetree.
 
This is a misguided decision. Modules can depend on other modules.
Ideally shared functionality should be in a separate module but having
xen depend on linux is an OK stopgap solution. Putting everything in one
module is bad.
   - Add the support of xen_hypervisor/xen_module commands in 
 util/grub.d/20_linux_xen.in
 
   - Add the introduction of xen_hypervisor/xen_module commands in 
 docs/grub.texi
 
   - The example of this support is How to boot Xen with GRUB on AArch64 the 
 Foundation FVP model
 
 https://wiki.linaro.org/LEG/Engineering/Grub2/Xen_booting_on_Foundation_FVP_model_by_GRUB
 
 Changelog:
 v2: remove the patches which have been accepted.
 according to Vladimir's suggestion, change the command manes
 and relevant code:
 multiboot--xen_hypervisor
 module--xen_module
 improve the option parsing support for xen_hypervisor/xen_module commands.
 add a patch for adding xen_hypervisor/xen_module support
 in util/grub.d/20_linux_xen.in.
 update docs/grub.texi patch for the new command names.
 
 v1: The first version upstream patchset to grub-devel mailing list
 
 
 Fu Wei (3):
   arm64: Add Xen boot support file
   * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64
   arm64: Add the introduction of xen_hypervisor/xen_module command in
 docs/grub.texi
 
  docs/grub.texi|  27 ++
  grub-core/Makefile.core.def   |   1 +
  grub-core/loader/arm64/linux.c|   6 +
  grub-core/loader/arm64/xen_boot.c | 615 
 ++
  include/grub/arm64/xen_boot.h | 115 +++
  util/grub.d/20_linux_xen.in   |  14 +-
  6 files changed, 775 insertions(+), 3 deletions(-)
  create mode 100644 grub-core/loader/arm64/xen_boot.c
  create mode 100644 include/grub/arm64/xen_boot.h
 




signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 0/3] arm64: Add multiboot support (via fdt) for Xen boot

2015-07-14 Thread Ian Campbell 
On Mon, 2015-07-13 at 16:53 +0800, fu@linaro.org wrote:
 From: Fu Wei fu@linaro.org
 
   - This adds support for the Xen boot on ARM specification for arm64.

I have used this to PXE boot Xen on a mustang board. My (handcrafted)
grub.cfg was:

set default=0
set timeout=5
menuentry 'pxe multiboot xen' {
  echo xen_hypervisor /trap/xen.efi
  xen_hypervisor /trap/xen.efi conswitch=x watchdog console=dtuart 
dtuart=/soc/serial@1c02 dom0_mem=512M,max:512M
  echo xen_module /trap/vmlinuz
  xen_module /trap/vmlinuz root=/dev/mapper/trap--vg-root ro  
console=hvc0
  echo xen_module /trap/initrd.gz
  xen_module /trap/initrd.gz
  boot
}

Tested-by: Ian Campbell ian.campb...@citrix.com

I didn't yet try a local boot from hdd since I'm sure it would work
equivalently and there still seems to be some discussion around how the
update-grub side should fit together.

Thanks!

Ian.


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 0/3] arm64: Add multiboot support (via fdt) for Xen boot

2015-07-14 Thread Fu Wei 
Hi Ian,
Great thanks for your testing, will add your tested-by in my next patchset :-)

On 14 July 2015 at 17:29, Ian Campbell ian.campb...@citrix.com wrote:
 On Mon, 2015-07-13 at 16:53 +0800, fu@linaro.org wrote:
 From: Fu Wei fu@linaro.org

   - This adds support for the Xen boot on ARM specification for arm64.

 I have used this to PXE boot Xen on a mustang board. My (handcrafted)
 grub.cfg was:

 set default=0
 set timeout=5
 menuentry 'pxe multiboot xen' {
   echo xen_hypervisor /trap/xen.efi
   xen_hypervisor /trap/xen.efi conswitch=x watchdog console=dtuart 
 dtuart=/soc/serial@1c02 dom0_mem=512M,max:512M
   echo xen_module /trap/vmlinuz
   xen_module /trap/vmlinuz root=/dev/mapper/trap--vg-root ro  
 console=hvc0
   echo xen_module /trap/initrd.gz
   xen_module /trap/initrd.gz
   boot
 }

 Tested-by: Ian Campbell ian.campb...@citrix.com

 I didn't yet try a local boot from hdd since I'm sure it would work
 equivalently and there still seems to be some discussion around how the
 update-grub side should fit together.

 Thanks!

 Ian.




-- 
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel