Re: [Xen-devel] [PATCH v2 2/4] tools/xen-mceinj: Fix code style

[Haozhong Zhang]

On Wed, Sep 16, 2015 at 08:45:58AM +0100, Wei Liu wrote:
> On Wed, Sep 16, 2015 at 01:35:13PM +0800, Haozhong Zhang wrote:
> > Remove trailing whitespaces in xen-mceinj.c.
> > 
> > Signed-off-by: Haozhong Zhang 
> 
> Acked-by: Wei Liu 
> 
> Haozhong, normally you should carry all the tags you received from the
> last round unless there are substantive changes to your patch. If you're
> unclear whether you should keep those tags, just ask for clarification.
> 
> Reviewers will check those tags to help determine whether they would
> need to look at the patch.
> 
> Wei.

Got it. I'll resend this patchset w/ all tags soon. Thanks!

- Haozhong Zhang

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 2/4] tools/xen-mceinj: Fix code style

[Wei Liu]

On Wed, Sep 16, 2015 at 03:52:39PM +0800, Haozhong Zhang wrote:
> On Wed, Sep 16, 2015 at 08:45:58AM +0100, Wei Liu wrote:
> > On Wed, Sep 16, 2015 at 01:35:13PM +0800, Haozhong Zhang wrote:
> > > Remove trailing whitespaces in xen-mceinj.c.
> > > 
> > > Signed-off-by: Haozhong Zhang 
> > 
> > Acked-by: Wei Liu 
> > 
> > Haozhong, normally you should carry all the tags you received from the
> > last round unless there are substantive changes to your patch. If you're
> > unclear whether you should keep those tags, just ask for clarification.
> > 
> > Reviewers will check those tags to help determine whether they would
> > need to look at the patch.
> > 
> > Wei.
> 
> Got it. I'll resend this patchset w/ all tags soon. Thanks!
> 

There is no need to do that this time. :-)

It was just a reminder for you so that you know what to do next time.

Wei.

> - Haozhong Zhang

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 2/4] tools/xen-mceinj: Fix code style

[Haozhong Zhang]

On Wed, Sep 16, 2015 at 08:58:41AM +0100, Wei Liu wrote:
> On Wed, Sep 16, 2015 at 03:52:39PM +0800, Haozhong Zhang wrote:
> > On Wed, Sep 16, 2015 at 08:45:58AM +0100, Wei Liu wrote:
> > > On Wed, Sep 16, 2015 at 01:35:13PM +0800, Haozhong Zhang wrote:
> > > > Remove trailing whitespaces in xen-mceinj.c.
> > > > 
> > > > Signed-off-by: Haozhong Zhang 
> > > 
> > > Acked-by: Wei Liu 
> > > 
> > > Haozhong, normally you should carry all the tags you received from the
> > > last round unless there are substantive changes to your patch. If you're
> > > unclear whether you should keep those tags, just ask for clarification.
> > > 
> > > Reviewers will check those tags to help determine whether they would
> > > need to look at the patch.
> > > 
> > > Wei.
> > 
> > Got it. I'll resend this patchset w/ all tags soon. Thanks!
> > 
> 
> There is no need to do that this time. :-)
> 
> It was just a reminder for you so that you know what to do next time.
> 
> Wei.
> 
> > - Haozhong Zhang

Thanks! I'll keep this in mind.

- Haozhong Zhang

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 2/4] tools/xen-mceinj: Fix code style

[Wei Liu]

On Wed, Sep 16, 2015 at 01:35:13PM +0800, Haozhong Zhang wrote:
> Remove trailing whitespaces in xen-mceinj.c.
> 
> Signed-off-by: Haozhong Zhang 

Acked-by: Wei Liu 

Haozhong, normally you should carry all the tags you received from the
last round unless there are substantive changes to your patch. If you're
unclear whether you should keep those tags, just ask for clarification.

Reviewers will check those tags to help determine whether they would
need to look at the patch.

Wei.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 2/4] tools/xen-mceinj: Fix code style

[Egger, Christoph]

On 2015/09/16 7:35, Haozhong Zhang wrote:
> Remove trailing whitespaces in xen-mceinj.c.
> 
> Signed-off-by: Haozhong Zhang 

Acked-by: Christoph Egger 

> ---
>  tools/tests/mce-test/tools/xen-mceinj.c | 66 
> -
>  1 file changed, 33 insertions(+), 33 deletions(-)
> 
> diff --git a/tools/tests/mce-test/tools/xen-mceinj.c 
> b/tools/tests/mce-test/tools/xen-mceinj.c
> index e2e49cb..71813c6 100644
> --- a/tools/tests/mce-test/tools/xen-mceinj.c
> +++ b/tools/tests/mce-test/tools/xen-mceinj.c
> @@ -13,7 +13,7 @@
>   *
>   * You should have received a copy of the GNU General Public License along 
> with
>   * this program; If not, see .
> - * 
> + *
>   * Authors: Yunhong Jiang 
>   *  Haicheng Li 
>   *  Xudong Hao 
> @@ -217,18 +217,18 @@ static uint64_t bank_addr(int bank, int type)
>  
>  switch ( type )
>  {
> -case MCi_type_CTL:
> -case MCi_type_STATUS:
> -case MCi_type_ADDR:
> -case MCi_type_MISC:
> -addr = MSR_IA32_MC0_CTL + (bank * 4) + type;
> -break;
> -case MCi_type_CTL2:
> -addr = MSR_IA32_MC0_CTL2 + bank;
> -break;
> -default:
> -addr = INVALID_MSR;
> -break;
> +case MCi_type_CTL:
> +case MCi_type_STATUS:
> +case MCi_type_ADDR:
> +case MCi_type_MISC:
> +addr = MSR_IA32_MC0_CTL + (bank * 4) + type;
> +break;
> +case MCi_type_CTL2:
> +addr = MSR_IA32_MC0_CTL2 + bank;
> +break;
> +default:
> +addr = INVALID_MSR;
> +break;
>  }
>  
>  return addr;
> @@ -243,7 +243,7 @@ static int add_msr_intpose(xc_interface *xc_handle,
>  uint32_t count;
>  
>  if ( (msr_inj.mcinj_count &&
> - (cpu_nr != msr_inj.mcinj_cpunr || flags != msr_inj.mcinj_flags)) ||
> +  (cpu_nr != msr_inj.mcinj_cpunr || flags != msr_inj.mcinj_flags)) ||
>   msr_inj.mcinj_count == MC_MSRINJ_MAXMSRS )
>  {
>  flush_msr_inj(xc_handle);
> @@ -282,8 +282,8 @@ static int add_msr_bank_intpose(xc_interface *xc_handle,
>  #define mfn_valid(_mfn) (_mfn != MCE_INVALID_MFN)
>  #define mfn_to_pfn(_mfn) (live_m2p[(_mfn)])
>  static uint64_t guest_mfn(xc_interface *xc_handle,
> -   uint32_t domain,
> -   uint64_t gpfn)
> +  uint32_t domain,
> +  uint64_t gpfn)
>  {
>  xen_pfn_t *live_m2p = NULL;
>  int ret;
> @@ -300,8 +300,8 @@ static uint64_t guest_mfn(xc_interface *xc_handle,
>  return MCE_INVALID_MFN;
>  
>  /* Get max gpfn */
> -max_gpfn = do_memory_op(xc_handle, XENMEM_maximum_gpfn, , 
> -   sizeof(domain)) + 1;
> +max_gpfn = do_memory_op(xc_handle, XENMEM_maximum_gpfn, ,
> +sizeof(domain)) + 1;
>  if ( max_gpfn <= 0 )
>  err(xc_handle, "Failed to get max_gpfn 0x%lx", max_gpfn);
>  
> @@ -360,8 +360,8 @@ static uint64_t mca_gpfn_to_mfn(xc_interface *xc_handle,
>  if ( domain == DOMID_XEN )
>  return gfn;
>  
> -max_gpfn = do_memory_op(xc_handle, XENMEM_maximum_gpfn, , 
> -   sizeof(domain)) + 1;
> +max_gpfn = do_memory_op(xc_handle, XENMEM_maximum_gpfn, ,
> +sizeof(domain)) + 1;
>  if ( max_gpfn <= 0 )
>  err(xc_handle, "Failed to get max_gpfn 0x%lx", max_gpfn);
>  index = gfn % max_gpfn;
> @@ -374,7 +374,7 @@ static int inject_mcg_status(xc_interface *xc_handle,
>   uint64_t val)
>  {
>  return add_msr_intpose(xc_handle, cpu_nr, MC_MSRINJ_F_INTERPOSE,
> -   MSR_IA32_MCG_STATUS, val);
> +   MSR_IA32_MCG_STATUS, val);
>  }
>  
>  static int inject_mci_status(xc_interface *xc_handle,
> @@ -383,25 +383,25 @@ static int inject_mci_status(xc_interface *xc_handle,
>   uint64_t val)
>  {
>  return add_msr_bank_intpose(xc_handle, cpu_nr, MC_MSRINJ_F_INTERPOSE,
> -MCi_type_STATUS, bank, val); 
> +MCi_type_STATUS, bank, val);
>  }
>  
>  static int inject_mci_misc(xc_interface *xc_handle,
> - uint32_t cpu_nr,
> - uint64_t bank,
> - uint64_t val)
> +   uint32_t cpu_nr,
> +   uint64_t bank,
> +   uint64_t val)
>  {
>  return add_msr_bank_intpose(xc_handle, cpu_nr, MC_MSRINJ_F_INTERPOSE,
> -MCi_type_MISC, bank, val); 
> +MCi_type_MISC, bank, val);
>  }
>  
>  static int inject_mci_addr(xc_interface *xc_handle,
> - 

Re: [Xen-devel] [PATCH v2 2/4] tools/xen-mceinj: Fix code style

[Wei Liu]

On Wed, Sep 16, 2015 at 03:52:39PM +0800, Haozhong Zhang wrote:
> On Wed, Sep 16, 2015 at 08:45:58AM +0100, Wei Liu wrote:
> > On Wed, Sep 16, 2015 at 01:35:13PM +0800, Haozhong Zhang wrote:
> > > Remove trailing whitespaces in xen-mceinj.c.
> > > 
> > > Signed-off-by: Haozhong Zhang 
> > 
> > Acked-by: Wei Liu 
> > 
> > Haozhong, normally you should carry all the tags you received from the
> > last round unless there are substantive changes to your patch. If you're
> > unclear whether you should keep those tags, just ask for clarification.
> > 
> > Reviewers will check those tags to help determine whether they would
> > need to look at the patch.
> > 
> > Wei.
> 
> Got it. I'll resend this patchset w/ all tags soon. Thanks!
> 

There is no need to do that this time. :-)

It was just a reminder for you so that you know what to do next time.

Wei.

> - Haozhong Zhang

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel