[Xen-devel] "make world" clobbers doc/man{1, 5, 7, 8} but doesn't always receate them
Issuing a "make world" clobbers four directories within the source tree doc/man[1,5,7,8} as part of the "make clean" Those directories don't appear to be re-created during the "make dist" within my recent build. As the toplevel Makefile has make world: $(MAKE) clean $(MAKE) dist I found that by doing those two sperately, I was afforded an opportunity to re-create those directories make clean mkdir docs/man1 docs/man5 docs/man7 docs/man8 make dist. Should I need to do that, or is there a path, albeit one less trodden, in the build system, that can see a "make world" clean the dirs but not recreate them? Kevin ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [xen-unstable-smoke test] 135007: regressions - FAIL
flight 135007 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/135007/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 133991 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-armhf-armhf-xl 13 migrate-support-checkfail never pass test-armhf-armhf-xl 14 saverestore-support-checkfail never pass version targeted for testing: xen be3d5b30331d87e177744dbe23138b9ebcdc86f1 baseline version: xen cb70a26f78848fe45f593f7ebc9cfaac760a791b Last test of basis 133991 2019-03-22 15:00:46 Z 28 days Failing since134068 2019-03-25 12:00:51 Z 25 days 137 attempts Testing same since 134834 2019-04-15 19:00:48 Z4 days 31 attempts People who touched revisions under test: Alexandru Isaila Alexandru Stefan ISAILA Amit Singh Tomar Andrew Cooper Anthony PERARD Brian Woods Christian Lindig Doug Goldstein George Dunlap Igor Druzhinin Jan Beulich Juergen Gross Julien Grall Kevin Tian Lukas Juenger M A Young Norbert Manthey Oleksandr Andrushchenko Paul Durrant Pawel Wieczorkiewicz Petre Pircalabu Razvan Cojocaru Tamas K Lengyel Wei Liu Xiaochen Wang Xin Li jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386 fail test-amd64-amd64-libvirt pass sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2099 lines long.) ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] tools/Makefile: the qemu-xen-dir-remote directory in qemu-xen-dir-force-update target
On Fri, 19 Apr 2019 at 14:19, Kevin Buckley wrote: > > I am looking to build a Xen from a downloaded source tree at commit cb70a26 > > In the tools/Makefile, there is this target at Line 204 > > .PHONY: qemu-xen-dir-force-update > qemu-xen-dir-force-update: qemu-xen-dir-find > set -ex; \ > if [ "$(QEMU_UPSTREAM_REVISION)" ]; then \ > cd qemu-xen-dir-remote; \ > $(GIT) fetch origin; \ > $(GIT) reset --hard $(QEMU_UPSTREAM_REVISION); \ > fi > > however, i can't find any other mention of the directory > "qemu-xen-dir-remote;" > in the source tree, other than the removal of it in the same > Makefile's distclean > ... > > so where would it get created ? To answer this one myself: if one allows the Xen install to clone the QEMU installation then qemu-xen-dir-remote is named of the directory that gets created by a script, howver within the script the name comes from a ${QEMU_DIR}-remote construct, hence it not being visisble to a plain text search across the source tree, except at the point where the Makefile references it. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] Hypervisor build can't work without `python` (Was: Re: Xen commit 9b0bc91b3 possibly removed too much info from README)
On Fri, 19 Apr 2019 at 14:07, Kevin Buckley wrote: > > I am actually thinking of installing a Python 2 and making the link to > the bare /usr/bin/python point to that, just to see if I can get things > to build. So I did that and the hypervisor, tools and docs were all built and installed as expected. I have since gone back, removed all traces of Pythin 2 and performed the same build but against Python 3, as follows though recall that I am building this in a fairly basic LFS system and so don't have Git, nor connectivty to the QEMU Git repository. Mimic the cloning of the QEMU Git repo external to the LFS system and create a tar-ball for use inside LFS using the script from the Xen tar-ball. GIT=git scripts/git-checkout.sh git://xenbits.xen.org/qemu-xen.git master qemu-xen-dir cd qemu-xen-dir-remote/ git submodule init git submodule update dtc git submodule update capstone/ git submodule update ui/keycodemapdb cd .. tar cf qemu-xen-dir-de5b678ca-sub.tar qemu-xen-dir-remote bzip2 -9 qemu-xen-dir-de5b678ca-sub.tar Once inside the LFS system tar xf $XTRASRC/xen-cb70a26.tar.bz2 tar xf $XTRASRC/qemu-xen-dir-de5b678ca-sub.tar.bz2 cd xen-master As well as providing a bare "python" so that scripts within the sources that have such a hash-bang, I found that I also had to override things for the configure to complete: ln -s python3 /usr/bin/python PYTHON=/usr/bin/python3 \ ./configure --prefix=/usr\ --disable-seabios \ --disable-qemu-traditional \ --disable-rombios \ --disable-stubdom 2>&1 | tee ../config.log Issuing a "make world" here clobbers four directories doc/man[1,5,7,8} in the "make clean" that don't appear to be re-created during the "make dist", so those two makes" were done sperately so as to provide an opportunity to re-create those directories Note also that on an LFS system, which is 64-bit by default, there is no /usr/lib64, a subdir of which would be the default target for Xen's EFI_DIR variable. make clean mkdir docs/man1 docs/man5 docs/man7 docs/man8 make \ PYTHON=/usr/bin/python3 \ EFI_DIR=/usr/lib/efi \ QEMU_UPSTREAM_LOC=/usr/src/xen/qemu-xen-dir-remote \ dist2>&1 | tee ../make-dist.log make \ PYTHON=/usr/bin/python3 \ EFI_DIR=/usr/lib/efi \ QEMU_UPSTREAM_LOC=/usr/src/xen/qemu-xen-dir-remote \ install 2>&1 | tee ../make-install.log This appears to build and install the Xen hypervisor and the tools and docs as expected. I have noticed that installed files such as pygrub do have a hash-bang line that explcitly specifies /usr/bin/python3, so it would appear to have done the right thing as regards what it does with the user's overriding of "PYTHON". Hope that's of some (more) use, Kevin PS I'll flag up the internal doc directory clobbering in a seperate thread. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [xen-4.12-testing test] 134929: regressions - FAIL
flight 134929 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/134929/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken in 134568 build-arm64-pvopsbroken in 134568 build-arm64-xsm broken in 134568 build-arm644 host-install(4) broken in 134568 REGR. vs. 133989 build-arm64-pvops 4 host-install(4) broken in 134568 REGR. vs. 133989 build-arm64-xsm4 host-install(4) broken in 134568 REGR. vs. 133989 build-i386-libvirt6 libvirt-buildfail REGR. vs. 133989 Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-xsm 18 guest-start/debian.repeat fail in 134568 pass in 134653 test-armhf-armhf-xl-multivcpu 7 xen-bootfail in 134568 pass in 134929 test-amd64-amd64-xl-qemut-ws16-amd64 7 xen-boot fail in 134653 pass in 134929 test-amd64-amd64-xl-qcow217 guest-localmigrate/x10 fail pass in 134568 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 134568 n/a build-arm64-libvirt 1 build-check(1) blocked in 134568 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 134568 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 134568 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 134568 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 134568 n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 13 migrate-support-check fail in 134568 never pass test-amd64-i386-libvirt 13 migrate-support-check fail in 134568 never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail in 134568 never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail never pass test-amd64-i386-xl-pvshim12 guest-start fail never pass test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-checkfail never pass test-arm64-arm64-xl 14 saverestore-support-checkfail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-checkfail never pass test-arm64-arm64-xl-credit2 13 migrate-support-checkfail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-checkfail never pass test-arm64-arm64-xl-credit1 13 migrate-support-checkfail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-checkfail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-checkfail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail never pass test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-checkfail never pass test-armhf-armhf-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-libvirt 14 saverestore-support-checkfail never pass test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-checkfail never pass test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-checkfail never pass test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail never pass test-armhf-armhf-xl 13 migrate-support-checkfail never pass test-armhf-armhf-xl 14 saverestore-support-checkfail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-armhf-armhf-xl-credit1 13
[Xen-devel] [xen-unstable-smoke test] 135001: regressions - FAIL
flight 135001 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/135001/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 133991 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-armhf-armhf-xl 13 migrate-support-checkfail never pass test-armhf-armhf-xl 14 saverestore-support-checkfail never pass version targeted for testing: xen be3d5b30331d87e177744dbe23138b9ebcdc86f1 baseline version: xen cb70a26f78848fe45f593f7ebc9cfaac760a791b Last test of basis 133991 2019-03-22 15:00:46 Z 28 days Failing since134068 2019-03-25 12:00:51 Z 25 days 136 attempts Testing same since 134834 2019-04-15 19:00:48 Z4 days 30 attempts People who touched revisions under test: Alexandru Isaila Alexandru Stefan ISAILA Amit Singh Tomar Andrew Cooper Anthony PERARD Brian Woods Christian Lindig Doug Goldstein George Dunlap Igor Druzhinin Jan Beulich Juergen Gross Julien Grall Kevin Tian Lukas Juenger M A Young Norbert Manthey Oleksandr Andrushchenko Paul Durrant Pawel Wieczorkiewicz Petre Pircalabu Razvan Cojocaru Tamas K Lengyel Wei Liu Xiaochen Wang Xin Li jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386 fail test-amd64-amd64-libvirt pass sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2099 lines long.) ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH 1/6] xen: extend XEN_DOMCTL_memory_mapping to handle cacheability
On Tue, 26 Feb 2019, Julien Grall wrote: > Hi, > > On 26/02/2019 23:07, Stefano Stabellini wrote: > > Reuse the existing padding field to pass cacheability information about > > the memory mapping, specifically, whether the memory should be mapped as > > normal memory or as device memory (this is what we have today). > > > > Add a cacheability parameter to map_mmio_regions. 0 means device > > memory, which is what we have today. > > > > On ARM, map device memory as p2m_mmio_direct_dev (as it is already done > > today) and normal memory as p2m_ram_rw. > > > > On x86, return error if the cacheability requested is not device memory. > > > > Signed-off-by: Stefano Stabellini > > CC: jbeul...@suse.com > > CC: andrew.coop...@citrix.com > > --- > > xen/arch/arm/gic-v2.c| 3 ++- > > xen/arch/arm/p2m.c | 19 +-- > > xen/arch/arm/platforms/exynos5.c | 4 ++-- > > xen/arch/arm/platforms/omap5.c | 8 > > xen/arch/arm/vgic-v2.c | 2 +- > > xen/arch/arm/vgic/vgic-v2.c | 2 +- > > xen/arch/x86/hvm/dom0_build.c| 7 +-- > > xen/arch/x86/mm/p2m.c| 6 +- > > xen/common/domctl.c | 8 +--- > > xen/drivers/vpci/header.c| 3 ++- > > xen/include/public/domctl.h | 4 +++- > > xen/include/xen/p2m-common.h | 3 ++- > > 12 files changed, 49 insertions(+), 20 deletions(-) > > > > diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c > > index e7eb01f..1ea3da2 100644 > > --- a/xen/arch/arm/gic-v2.c > > +++ b/xen/arch/arm/gic-v2.c > > @@ -690,7 +690,8 @@ static int gicv2_map_hwdown_extra_mappings(struct > > domain *d) > > > > ret = map_mmio_regions(d, gaddr_to_gfn(v2m_data->addr), > > PFN_UP(v2m_data->size), > > - maddr_to_mfn(v2m_data->addr)); > > + maddr_to_mfn(v2m_data->addr), > > + CACHEABILITY_DEVMEM); > > if ( ret ) > > { > > printk(XENLOG_ERR "GICv2: Map v2m frame to d%d failed.\n", > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > > index 30cfb01..5b8fcc5 100644 > > --- a/xen/arch/arm/p2m.c > > +++ b/xen/arch/arm/p2m.c > > @@ -1068,9 +1068,24 @@ int unmap_regions_p2mt(struct domain *d, > > int map_mmio_regions(struct domain *d, > >gfn_t start_gfn, > >unsigned long nr, > > - mfn_t mfn) > > + mfn_t mfn, > > + uint32_t cache_policy) > > { > > -return p2m_insert_mapping(d, start_gfn, nr, mfn, p2m_mmio_direct_dev); > > +p2m_type_t t; > > + > > +switch ( cache_policy ) > > +{ > > +case CACHEABILITY_MEMORY: > > +t = p2m_ram_rw; > > Potentially, you want to clean the cache here. We have been talking about this and I have been looking through the code. I am still not exactly sure how to proceed. Is there a reason why cacheable reserved_memory pages should be treated differently from normal memory, in regards to cleaning the cache? It seems to me that they should be the same in terms of cache issues? Is there a place where we clean the dcache for normal pages, one that is not tied to p2m->clean_pte, which is different (it is there for iommu reasons)? ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [xen-unstable test] 134923: regressions - FAIL
flight 134923 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/134923/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 134763 build-i386-pvops 6 kernel-build fail REGR. vs. 134763 Tests which did not succeed, but are not blocking: test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-win10-i386 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-examine 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl1 build-check(1) blocked n/a test-amd64-i386-qemut-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-migrupgrade 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-qemut-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl-raw1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win10-i386 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-livepatch 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow217 guest-localmigrate/x10 fail like 134763 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 134763 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 134763 test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 134763 test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail like 134763 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stopfail like 134763 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stopfail like 134763 test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-checkfail never pass test-arm64-arm64-xl 13 migrate-support-checkfail never pass test-arm64-arm64-xl 14 saverestore-support-checkfail never pass test-arm64-arm64-xl-credit1 13 migrate-support-checkfail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-checkfail never pass test-arm64-arm64-xl-credit2 13 migrate-support-checkfail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-checkfail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 13 migrate-support-checkfail
Re: [Xen-devel] [PATCH 1/6] xen: extend XEN_DOMCTL_memory_mapping to handle cacheability
On Wed, 27 Feb 2019, Julien Grall wrote: > Hi Stefano, > > On 2/26/19 11:07 PM, Stefano Stabellini wrote: > > Reuse the existing padding field to pass cacheability information about > > the memory mapping, specifically, whether the memory should be mapped as > > normal memory or as device memory (this is what we have today). > > > > Add a cacheability parameter to map_mmio_regions. 0 means device > > memory, which is what we have today. > > > > On ARM, map device memory as p2m_mmio_direct_dev (as it is already done > > today) and normal memory as p2m_ram_rw. > > > > On x86, return error if the cacheability requested is not device memory. > > > > Signed-off-by: Stefano Stabellini > > CC: jbeul...@suse.com > > CC: andrew.coop...@citrix.com > > --- > > xen/arch/arm/gic-v2.c| 3 ++- > > xen/arch/arm/p2m.c | 19 +-- > > xen/arch/arm/platforms/exynos5.c | 4 ++-- > > xen/arch/arm/platforms/omap5.c | 8 > > xen/arch/arm/vgic-v2.c | 2 +- > > xen/arch/arm/vgic/vgic-v2.c | 2 +- > > xen/arch/x86/hvm/dom0_build.c| 7 +-- > > xen/arch/x86/mm/p2m.c| 6 +- > > xen/common/domctl.c | 8 +--- > > xen/drivers/vpci/header.c| 3 ++- > > xen/include/public/domctl.h | 4 +++- > > xen/include/xen/p2m-common.h | 3 ++- > > 12 files changed, 49 insertions(+), 20 deletions(-) > > > > diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c > > index e7eb01f..1ea3da2 100644 > > --- a/xen/arch/arm/gic-v2.c > > +++ b/xen/arch/arm/gic-v2.c > > @@ -690,7 +690,8 @@ static int gicv2_map_hwdown_extra_mappings(struct domain > > *d) > > ret = map_mmio_regions(d, gaddr_to_gfn(v2m_data->addr), > > PFN_UP(v2m_data->size), > > - maddr_to_mfn(v2m_data->addr)); > > + maddr_to_mfn(v2m_data->addr), > > + CACHEABILITY_DEVMEM); > > if ( ret ) > > { > > printk(XENLOG_ERR "GICv2: Map v2m frame to d%d failed.\n", > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > > index 30cfb01..5b8fcc5 100644 > > --- a/xen/arch/arm/p2m.c > > +++ b/xen/arch/arm/p2m.c > > @@ -1068,9 +1068,24 @@ int unmap_regions_p2mt(struct domain *d, > > int map_mmio_regions(struct domain *d, > >gfn_t start_gfn, > >unsigned long nr, > > - mfn_t mfn) > > + mfn_t mfn, > > + uint32_t cache_policy) > > Rather than extending map_mmio_regions, I would prefer if we kill this > function (and unmap_mmio_mmio_regions) and instead use map_regions_p2mt. > > This means the conversation to p2mt should be done in the DOMCTL handling. map_regions_p2mt is an arm specific function. map_mmio_regions is the common function across x86 and arm, called from common code. > > { > > -return p2m_insert_mapping(d, start_gfn, nr, mfn, p2m_mmio_direct_dev); > > +p2m_type_t t; > > + > > +switch ( cache_policy ) > > +{ > > +case CACHEABILITY_MEMORY: > > +t = p2m_ram_rw; > > +break; > > +case CACHEABILITY_DEVMEM: > > +t = p2m_mmio_direct_dev; > > +break; > > +default: > > +return -ENOSYS; > > We tend to use EOPNOTSUPP in such a case. Yes, OK ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH 3/6] libxl/xl: add cacheability option to iomem
On Wed, 27 Feb 2019, Julien Grall wrote: > Hi Stefano, > > On 2/26/19 11:07 PM, Stefano Stabellini wrote: > > Parse a new cacheability option for the iomem parameter, it can be > > "devmem" for device memory mappings, which is the default, or "memory" > > for normal memory mappings. > > > > Store the parameter in a new field in libxl_iomem_range. > > > > Pass the cacheability option to xc_domain_memory_mapping. > > > > Signed-off-by: Stefano Stabellini > > CC: ian.jack...@eu.citrix.com > > CC: wei.l...@citrix.com > > --- > > docs/man/xl.cfg.pod.5.in| 4 +++- > > tools/libxl/libxl_create.c | 12 +++- > > tools/libxl/libxl_types.idl | 7 +++ > > Extension of the libxl_types.idl should be companied with a new define in > libxl.h. So a toolstack can deal with multiple libxl version. I'll do > > tools/xl/xl_parse.c | 17 +++-- > > 4 files changed, 36 insertions(+), 4 deletions(-) > > > > diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in > > index b1c0be1..655008a 100644 > > --- a/docs/man/xl.cfg.pod.5.in > > +++ b/docs/man/xl.cfg.pod.5.in > > @@ -1222,7 +1222,7 @@ is given in hexadecimal format and may either be a > > range, e.g. C<2f8-2ff> > > It is recommended to only use this option for trusted VMs under > > administrator's control. > > -=item B > "IOMEM_START,NUM_PAGES[@GFN]", ...]> > > +=item B > "IOMEM_START,NUM_PAGES[@GFN],CACHEABILITY", ...]> > > Below you suggest the cacheability is option. However, the is not reflected > here. I think you want to put ',CACHEABILITY' between [] as it is done for > '@GFN'. Good point > > Allow auto-translated domains to access specific hardware I/O memory > > pages. > > @@ -1233,6 +1233,8 @@ B is not specified, the mapping will be > > performed using B > > as a start in the guest's address space, therefore performing a 1:1 > > mapping > > by default. > > All of these values must be given in hexadecimal format. > > +B can be "devmem" for device memory, the default if not > > +specified, or it can be "memory" for normal memory. > > I was planning to comment about the naming and documentation. But I will do it > in patch #1 where Jan already started a discussion about it. All right. I don't have good ideas about naming. I am happy to change. > > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > > index 352cd21..1da2670 100644 > > --- a/tools/xl/xl_parse.c > > +++ b/tools/xl/xl_parse.c > > @@ -1883,6 +1883,7 @@ void parse_config_data(const char *config_source, > > } > > for (i = 0; i < num_iomem; i++) { > > int used; > > +char cache[7]; > > buf = xlu_cfg_get_listitem (iomem, i); > > if (!buf) { > > @@ -1891,15 +1892,27 @@ void parse_config_data(const char *config_source, > > exit(1); > > } > > libxl_iomem_range_init(_info->iomem[i]); > > -ret = sscanf(buf, "%" SCNx64",%" SCNx64"%n@%" SCNx64"%n", > > +ret = sscanf(buf, "%" SCNx64",%" SCNx64"%n@%" SCNx64"%n,%6s%n", > >_info->iomem[i].start, > >_info->iomem[i].number, , > > - _info->iomem[i].gfn, ); > > + _info->iomem[i].gfn, , > > + cache, ); > > If I read it correctly, you will require the GFN to be specified in order to > get the "cacheability". Am I correct? Yes, I was lazy :-) I'll fix it. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [xen-unstable-smoke test] 134995: regressions - FAIL
flight 134995 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/134995/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 133991 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-armhf-armhf-xl 13 migrate-support-checkfail never pass test-armhf-armhf-xl 14 saverestore-support-checkfail never pass version targeted for testing: xen be3d5b30331d87e177744dbe23138b9ebcdc86f1 baseline version: xen cb70a26f78848fe45f593f7ebc9cfaac760a791b Last test of basis 133991 2019-03-22 15:00:46 Z 28 days Failing since134068 2019-03-25 12:00:51 Z 25 days 135 attempts Testing same since 134834 2019-04-15 19:00:48 Z4 days 29 attempts People who touched revisions under test: Alexandru Isaila Alexandru Stefan ISAILA Amit Singh Tomar Andrew Cooper Anthony PERARD Brian Woods Christian Lindig Doug Goldstein George Dunlap Igor Druzhinin Jan Beulich Juergen Gross Julien Grall Kevin Tian Lukas Juenger M A Young Norbert Manthey Oleksandr Andrushchenko Paul Durrant Pawel Wieczorkiewicz Petre Pircalabu Razvan Cojocaru Tamas K Lengyel Wei Liu Xiaochen Wang Xin Li jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386 fail test-amd64-amd64-libvirt pass sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2099 lines long.) ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [linux-3.18 test] 134917: regressions - FAIL
flight 134917 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/134917/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken in 134634 build-arm64-pvopsbroken in 134634 build-arm64 broken in 134634 build-arm644 host-install(4) broken in 134634 REGR. vs. 128858 build-arm64-xsm4 host-install(4) broken in 134634 REGR. vs. 128858 build-arm64-pvops 4 host-install(4) broken in 134634 REGR. vs. 128858 test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 128858 test-amd64-amd64-i386-pvgrub 7 xen-boot fail REGR. vs. 128858 test-amd64-i386-examine 8 reboot fail REGR. vs. 128858 test-amd64-amd64-xl-qemuu-debianhvm-amd64 7 xen-bootfail REGR. vs. 128858 test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 128858 test-amd64-amd64-amd64-pvgrub 7 xen-bootfail REGR. vs. 128858 test-amd64-amd64-qemuu-nested-intel 7 xen-boot fail REGR. vs. 128858 test-amd64-amd64-libvirt-xsm 7 xen-boot fail REGR. vs. 128858 test-amd64-amd64-xl-multivcpu 7 xen-bootfail REGR. vs. 128858 test-amd64-amd64-xl-shadow7 xen-boot fail REGR. vs. 128858 test-amd64-amd64-xl-qemuu-ovmf-amd64 7 xen-boot fail REGR. vs. 128858 test-amd64-amd64-xl 7 xen-boot fail REGR. vs. 128858 test-amd64-amd64-xl-xsm 7 xen-boot fail REGR. vs. 128858 test-amd64-amd64-xl-pvshim7 xen-boot fail REGR. vs. 128858 test-amd64-amd64-libvirt 7 xen-boot fail REGR. vs. 128858 test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 128858 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-boot fail REGR. vs. 128858 test-amd64-i386-libvirt 7 xen-boot fail REGR. vs. 128858 test-amd64-i386-xl7 xen-boot fail REGR. vs. 128858 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 128858 test-amd64-amd64-rumprun-amd64 7 xen-boot fail in 134634 REGR. vs. 128858 Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt 5 host-ping-check-native fail in 134634 pass in 134917 test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 16 guest-localmigrate/x10 fail in 134634 pass in 134917 test-armhf-armhf-xl-cubietruck 19 leak-check/check fail in 134758 pass in 134917 test-armhf-armhf-xl-credit1 19 leak-check/check fail in 134758 pass in 134917 test-amd64-amd64-xl-qcow217 guest-localmigrate/x10 fail pass in 134634 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-bootfail pass in 134758 test-amd64-i386-xl-raw7 xen-boot fail pass in 134758 test-amd64-amd64-pair10 xen-boot/src_host fail pass in 134758 test-amd64-amd64-pair11 xen-boot/dst_host fail pass in 134758 test-amd64-i386-pair 11 xen-boot/dst_host fail pass in 134758 test-amd64-i386-libvirt-pair 10 xen-boot/src_host fail pass in 134758 test-amd64-i386-libvirt-pair 11 xen-boot/dst_host fail pass in 134758 test-armhf-armhf-libvirt 16 guest-start/debian.repeat fail pass in 134758 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 7 xen-boot fail REGR. vs. 128858 Tests which did not succeed, but are not blocking: build-arm64-libvirt 1 build-check(1) blocked in 134634 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 13 migrate-support-check fail in 134634 never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail in 134634 never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail in 134758 never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail in 134758 never pass test-armhf-armhf-libvirt-raw 10 debian-di-installfail like 128841 test-armhf-armhf-xl-vhd 10 debian-di-installfail like 128841 test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 128858 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 128858 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 128858 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 128858
Re: [Xen-devel] BACKPORT Re: [PATCH 3/7] Arm/atomic: correct asm() constraints in build_add_sized()
On Wed, 13 Mar 2019, Julien Grall wrote: > On 13/03/2019 10:21, Jan Beulich wrote: > > > > > On 11.03.19 at 19:08, wrote: > > > On 11/03/2019 16:49, Jan Beulich wrote: > > > > The memory operand is an in/out one, and the auxiliary register gets > > > > written to early. > > > > > > > > Take the opportunity and also drop the redundant cast (the inline > > > > functions' parameters are already of the casted-to type). > > > > > > > > Signed-off-by: Jan Beulich > > > > > > I guess this is candidate for backporting. > > > > Btw, do you want me to queue this, or will you or Stefano want to > > take care? > > Stefano is taking care of backporting. Stefano, can you queue it for all the > tree you can backport to? Done, and sorry for the delay. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [xen-unstable-smoke test] 134992: regressions - FAIL
flight 134992 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/134992/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 133991 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-armhf-armhf-xl 13 migrate-support-checkfail never pass test-armhf-armhf-xl 14 saverestore-support-checkfail never pass version targeted for testing: xen be3d5b30331d87e177744dbe23138b9ebcdc86f1 baseline version: xen cb70a26f78848fe45f593f7ebc9cfaac760a791b Last test of basis 133991 2019-03-22 15:00:46 Z 28 days Failing since134068 2019-03-25 12:00:51 Z 25 days 134 attempts Testing same since 134834 2019-04-15 19:00:48 Z4 days 28 attempts People who touched revisions under test: Alexandru Isaila Alexandru Stefan ISAILA Amit Singh Tomar Andrew Cooper Anthony PERARD Brian Woods Christian Lindig Doug Goldstein George Dunlap Igor Druzhinin Jan Beulich Juergen Gross Julien Grall Kevin Tian Lukas Juenger M A Young Norbert Manthey Oleksandr Andrushchenko Paul Durrant Pawel Wieczorkiewicz Petre Pircalabu Razvan Cojocaru Tamas K Lengyel Wei Liu Xiaochen Wang Xin Li jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386 fail test-amd64-amd64-libvirt pass sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2099 lines long.) ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH 01/12] xen: clang: Support correctly cross-compile
On Fri, 29 Mar 2019, Jan Beulich wrote: > >>> On 29.03.19 at 10:41, wrote: > > On 28/03/2019 09:55, Jan Beulich wrote: > > On 27.03.19 at 19:45, wrote: > >>> Clang uses "-target" option for cross-compilation. > >> > >>> --- a/config/StdGNU.mk > >>> +++ b/config/StdGNU.mk > >>> @@ -1,8 +1,13 @@ > >>> AS = $(CROSS_COMPILE)as > >>> LD = $(CROSS_COMPILE)ld > >>> ifeq ($(clang),y) > >>> -CC = $(CROSS_COMPILE)clang > >>> -CXX= $(CROSS_COMPILE)clang++ > >>> +ifneq ($(CROSS_COMPILE),) > >>> +CC = clang -target $(CROSS_COMPILE:-=) > >>> +CXX= clang++ -target $(CROSS_COMPILE:-=) > >> > >> Is dropping dashes from the variable uniformly correct? If so, > >> could you please clarify in the commit message why that is? > > The target option requires the following format: > > > > --- > > > > In other places, we need the trailing dash as GNU tools are using the same > > format as above with a dash to separate the tool name. > > Oh, I'm sorry - I keep forgetting that the substitution form you > use only fiddles with trailing dashes. Of course I won't insist, but > I'd prefer the more obvious $(patsubst %-,%,$(CROSS_COMPILE)) > to be used instead, despite realizing that it's meaningfully longer. Either way to do variable manipulation is OK, but it would be good to add Julien's explanation of the -target expected format in the commit message. I don't have any other comments on this patch. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [xen-unstable-smoke test] 134988: regressions - FAIL
flight 134988 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/134988/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 133991 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-armhf-armhf-xl 13 migrate-support-checkfail never pass test-armhf-armhf-xl 14 saverestore-support-checkfail never pass version targeted for testing: xen be3d5b30331d87e177744dbe23138b9ebcdc86f1 baseline version: xen cb70a26f78848fe45f593f7ebc9cfaac760a791b Last test of basis 133991 2019-03-22 15:00:46 Z 28 days Failing since134068 2019-03-25 12:00:51 Z 25 days 133 attempts Testing same since 134834 2019-04-15 19:00:48 Z3 days 27 attempts People who touched revisions under test: Alexandru Isaila Alexandru Stefan ISAILA Amit Singh Tomar Andrew Cooper Anthony PERARD Brian Woods Christian Lindig Doug Goldstein George Dunlap Igor Druzhinin Jan Beulich Juergen Gross Julien Grall Kevin Tian Lukas Juenger M A Young Norbert Manthey Oleksandr Andrushchenko Paul Durrant Pawel Wieczorkiewicz Petre Pircalabu Razvan Cojocaru Tamas K Lengyel Wei Liu Xiaochen Wang Xin Li jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386 fail test-amd64-amd64-libvirt pass sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2099 lines long.) ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] Question regarding swiotlb-xen in Linux kernel
On 04/19/2019 01:47 PM, Juergen Gross wrote: > On 19/04/2019 00:31, Joe Jin wrote: >> On 4/18/19 2:09 PM, Boris Ostrovsky wrote: >>> On 4/18/19 3:36 AM, Juergen Gross wrote: I'm currently investigating a problem related to swiotlb-xen. With a specific driver a customer is capable to trigger a situation where a MFN is mapped to multiple dom0 PFNs at the same time. There is no guest involved, so this is not related to grants. Wit a debug kernel I have managed to track the inconsistency to a call of xen_destroy_contiguous_region() from xen_swiotlb_free_coherent() where the region was obviously not contiguous. xen_swiotlb_free_coherent() contains: if (((dev_addr + size - 1 <= dma_mask)) || range_straddles_page_boundary(phys, size)) xen_destroy_contiguous_region(phys, order); Shouldn't it be either: if (((dev_addr + size - 1 <= dma_mask)) && !range_straddles_page_boundary(phys, size)) xen_destroy_contiguous_region(phys, order); >>> >>> +Joe >>> >>> https://lists.xenproject.org/archives/html/xen-devel/2018-10/msg01920.html >>> >>> (The discussion happened in >>> https://lists.xenproject.org/archives/html/xen-devel/2018-10/msg01814.html) >>> >>> And looks like we dropped it. Or was there a reason we haven't picked it up? >> >> I remembered the concern was whether memory not from Xen. > > The current coding is wrong. > > I believe we should have at least a WARN_ONCE() in case > xen_swiotlb_free_coherent() is being called with non-contiguous memory. > And it should not call xen_destroy_contiguous_region() in that case. > > Joe, did you observe such cases? I'm asking because the backtraces I > have give me no clue _why_ the memory was non-contiguous. The calling > function allocated the memory via xen_swiotlb_alloc_coherent() and when > freeing it again it was not contiguous. > > Another topic is the question whether we should really call > xen_destroy_contiguous_region() when freeing the memory if there was no > need to use xen_create_contiguous_region() when allocating it. What would happen if guest domain is malicious? That is, guest (including dom0) my allocate unlimited MFN continuous memory and never exchange them back to xen. Would MFN continuous memory be used up? As a result, xen may not be able to boot new VM. Is this a sort of DoS attack? Dongli Zhang ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [qemu-mainline test] 134899: regressions - FAIL
flight 134899 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/134899/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-xsm 23 leak-check/check fail REGR. vs. 133909 test-amd64-amd64-xl-pvhv2-amd 23 leak-check/checkfail REGR. vs. 133909 test-amd64-amd64-amd64-pvgrub 22 leak-check/checkfail REGR. vs. 133909 build-i386-libvirt6 libvirt-buildfail REGR. vs. 133909 build-i386-pvops 6 kernel-build fail REGR. vs. 133909 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-xl1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win10-i386 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-raw1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 133909 test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 133909 test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail like 133909 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stopfail like 133909 test-arm64-arm64-xl-credit2 13 migrate-support-checkfail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-checkfail never pass test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-arm64-arm64-xl 13 migrate-support-checkfail never pass test-arm64-arm64-xl 14 saverestore-support-checkfail never pass test-arm64-arm64-xl-credit1 13 migrate-support-checkfail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-checkfail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail never pass test-armhf-armhf-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 13 migrate-support-checkfail never pass test-armhf-armhf-xl 13 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-checkfail never pass test-armhf-armhf-xl 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-credit1 13 migrate-support-checkfail never pass test-armhf-armhf-xl-credit1 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-checkfail never pass test-armhf-armhf-xl-rtds 13 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check
Re: [Xen-devel] Question regarding swiotlb-xen in Linux kernel
On 4/18/19 10:47 PM, Juergen Gross wrote: > On 19/04/2019 00:31, Joe Jin wrote: >> On 4/18/19 2:09 PM, Boris Ostrovsky wrote: >>> On 4/18/19 3:36 AM, Juergen Gross wrote: I'm currently investigating a problem related to swiotlb-xen. With a specific driver a customer is capable to trigger a situation where a MFN is mapped to multiple dom0 PFNs at the same time. There is no guest involved, so this is not related to grants. Wit a debug kernel I have managed to track the inconsistency to a call of xen_destroy_contiguous_region() from xen_swiotlb_free_coherent() where the region was obviously not contiguous. xen_swiotlb_free_coherent() contains: if (((dev_addr + size - 1 <= dma_mask)) || range_straddles_page_boundary(phys, size)) xen_destroy_contiguous_region(phys, order); Shouldn't it be either: if (((dev_addr + size - 1 <= dma_mask)) && !range_straddles_page_boundary(phys, size)) xen_destroy_contiguous_region(phys, order); >>> >>> +Joe >>> >>> https://lists.xenproject.org/archives/html/xen-devel/2018-10/msg01920.html >>> >>> (The discussion happened in >>> https://lists.xenproject.org/archives/html/xen-devel/2018-10/msg01814.html) >>> >>> And looks like we dropped it. Or was there a reason we haven't picked it up? >> >> I remembered the concern was whether memory not from Xen. > > The current coding is wrong. I agree with you, your patch same with I sent before, I'm good to have it. > > I believe we should have at least a WARN_ONCE() in case > xen_swiotlb_free_coherent() is being called with non-contiguous memory. > And it should not call xen_destroy_contiguous_region() in that case. It's potential issue, if alloc/free is not in pairs, it will be a problem. > > Joe, did you observe such cases? I'm asking because the backtraces I > have give me no clue _why_ the memory was non-contiguous. The calling > function allocated the memory via xen_swiotlb_alloc_coherent() and when > freeing it again it was not contiguous. Not sure if you have commit 7250f422 "xen-swiotlb: use actually allocated size on check physical continuous"? without this commit, it's possible, after apply the commit, we did not hit such kind cases. Thanks, Joe > > Another topic is the question whether we should really call > xen_destroy_contiguous_region() when freeing the memory if there was no > need to use xen_create_contiguous_region() when allocating it. > > > Juergen > ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [freebsd-master test] 134985: all pass - PUSHED
flight 134985 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/134985/ Perfect :-) All tests in this flight passed as required version targeted for testing: freebsd 55a254f77345437156ffb61a3e8bc7aa5d93d34a baseline version: freebsd 66dd3f2bd67f9380116d2d0210fef816b154bf7a Last test of basis 134811 2019-04-15 09:20:24 Z4 days Failing since134914 2019-04-17 09:19:04 Z2 days2 attempts Testing same since 134985 2019-04-19 09:19:04 Z0 days1 attempts People who touched revisions under test: adrian bde bdrewery cem cy emaste fsu gallatin gjb hselasky ian imp jhb jhibbits kevans kib kp manu mw oshogbo peterj pfg phk pkubaj rmacklem thj trasz jobs: build-amd64-freebsd-againpass build-amd64-freebsd pass build-amd64-xen-freebsd pass sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/freebsd.git 66dd3f2bd67..55a254f7734 55a254f77345437156ffb61a3e8bc7aa5d93d34a -> tested/master ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [xen-unstable-smoke test] 134986: regressions - FAIL
flight 134986 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/134986/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 133991 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-armhf-armhf-xl 13 migrate-support-checkfail never pass test-armhf-armhf-xl 14 saverestore-support-checkfail never pass version targeted for testing: xen be3d5b30331d87e177744dbe23138b9ebcdc86f1 baseline version: xen cb70a26f78848fe45f593f7ebc9cfaac760a791b Last test of basis 133991 2019-03-22 15:00:46 Z 27 days Failing since134068 2019-03-25 12:00:51 Z 25 days 132 attempts Testing same since 134834 2019-04-15 19:00:48 Z3 days 26 attempts People who touched revisions under test: Alexandru Isaila Alexandru Stefan ISAILA Amit Singh Tomar Andrew Cooper Anthony PERARD Brian Woods Christian Lindig Doug Goldstein George Dunlap Igor Druzhinin Jan Beulich Juergen Gross Julien Grall Kevin Tian Lukas Juenger M A Young Norbert Manthey Oleksandr Andrushchenko Paul Durrant Pawel Wieczorkiewicz Petre Pircalabu Razvan Cojocaru Tamas K Lengyel Wei Liu Xiaochen Wang Xin Li jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386 fail test-amd64-amd64-libvirt pass sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2099 lines long.) ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [xen-unstable-smoke test] 134983: regressions - FAIL
flight 134983 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/134983/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 133991 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-armhf-armhf-xl 13 migrate-support-checkfail never pass test-armhf-armhf-xl 14 saverestore-support-checkfail never pass version targeted for testing: xen be3d5b30331d87e177744dbe23138b9ebcdc86f1 baseline version: xen cb70a26f78848fe45f593f7ebc9cfaac760a791b Last test of basis 133991 2019-03-22 15:00:46 Z 27 days Failing since134068 2019-03-25 12:00:51 Z 24 days 131 attempts Testing same since 134834 2019-04-15 19:00:48 Z3 days 25 attempts People who touched revisions under test: Alexandru Isaila Alexandru Stefan ISAILA Amit Singh Tomar Andrew Cooper Anthony PERARD Brian Woods Christian Lindig Doug Goldstein George Dunlap Igor Druzhinin Jan Beulich Juergen Gross Julien Grall Kevin Tian Lukas Juenger M A Young Norbert Manthey Oleksandr Andrushchenko Paul Durrant Pawel Wieczorkiewicz Petre Pircalabu Razvan Cojocaru Tamas K Lengyel Wei Liu Xiaochen Wang Xin Li jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386 fail test-amd64-amd64-libvirt pass sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2099 lines long.) ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH 2/2 v2] x86/acpi: Improve suspend and resume process for Zhaoxin CPU
On 19/04/2019 09:50, FionaLi-oc wrote: > When executing SYSEXIT or SYSENTRY in Zhaoxin CPU, CPU needs to > save or restore a set of MSRs. > > Signed-off-by: FionaLi-oc Acked-by: Andrew Cooper I've pulled this into x86-next, and it will get committed when CI has been repaired and is working again. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [ovmf baseline-only test] 84039: trouble: blocked/broken
This run is configured for baseline tests only. flight 84039 ovmf real [real] http://osstest.xensource.com/osstest/logs/84039/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm broken build-i386 broken build-amd64-pvopsbroken build-i386-xsm broken build-amd64 broken build-i386-pvops broken Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-i386-libvirt1 build-check(1) blocked n/a build-amd64-pvops 4 host-install(4) broken baseline untested build-i3864 host-install(4) broken baseline untested build-i386-pvops 4 host-install(4) broken baseline untested build-amd64 4 host-install(4) broken baseline untested build-i386-xsm4 host-install(4) broken baseline untested build-amd64-xsm 4 host-install(4) broken baseline untested version targeted for testing: ovmf c2f643479eb3f00d930c461cdec3ba420a36072c baseline version: ovmf 0eccea3fbe2f6d4999d972d9310d4f2717f5100c Last test of basis84003 2019-04-17 04:56:21 Z2 days Testing same since84039 2019-04-19 07:29:26 Z0 days1 attempts People who touched revisions under test: Ard Biesheuvel Bret Barkelew Fan, ZhijuX Gary Lin Laszlo Ersek Zailiang Sun Zhichao Gao Zhiju.Fan jobs: build-amd64-xsm broken build-i386-xsm broken build-amd64 broken build-i386 broken build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvopsbroken build-i386-pvops broken test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked sg-report-flight on osstest.xs.citrite.net logs: /home/osstest/logs images: /home/osstest/images Logs, config files, etc. are available at http://osstest.xensource.com/osstest/logs Test harness code can be found at http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary broken-job build-amd64-xsm broken broken-job build-i386 broken broken-job build-amd64-pvops broken broken-job build-i386-xsm broken broken-job build-amd64 broken broken-job build-i386-pvops broken broken-step build-amd64-pvops host-install(4) broken-step build-i386 host-install(4) broken-step build-i386-pvops host-install(4) broken-step build-amd64 host-install(4) broken-step build-i386-xsm host-install(4) broken-step build-amd64-xsm host-install(4) Push not applicable. (No revision log; it would be 504 lines long.) ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [PATCH 2/2 v2] x86/acpi: Improve suspend and resume process for Zhaoxin CPU
When executing SYSEXIT or SYSENTRY in Zhaoxin CPU, CPU needs to save or restore a set of MSRs. Signed-off-by: FionaLi-oc --- xen/arch/x86/acpi/suspend.c | 6 -- xen/arch/x86/x86_64/traps.c | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/acpi/suspend.c b/xen/arch/x86/acpi/suspend.c index 9e69bf2..b0ef1c2 100644 --- a/xen/arch/x86/acpi/suspend.c +++ b/xen/arch/x86/acpi/suspend.c @@ -27,7 +27,8 @@ void save_rest_processor_state(void) rdmsrl(MSR_SHADOW_GS_BASE, saved_kernel_gs_base); rdmsrl(MSR_CSTAR, saved_cstar); rdmsrl(MSR_LSTAR, saved_lstar); -if ( boot_cpu_data.x86_vendor & (X86_VENDOR_INTEL | X86_VENDOR_CENTAUR) ) +if ( boot_cpu_data.x86_vendor & +(X86_VENDOR_INTEL | X86_VENDOR_CENTAUR | X86_VENDOR_SHANGHAI) ) { rdmsrl(MSR_IA32_SYSENTER_ESP, saved_sysenter_esp); rdmsrl(MSR_IA32_SYSENTER_EIP, saved_sysenter_eip); @@ -51,7 +52,8 @@ void restore_rest_processor_state(void) wrgsbase(saved_gs_base); wrmsrl(MSR_SHADOW_GS_BASE, saved_kernel_gs_base); -if ( boot_cpu_data.x86_vendor & (X86_VENDOR_INTEL | X86_VENDOR_CENTAUR) ) +if ( boot_cpu_data.x86_vendor & +(X86_VENDOR_INTEL | X86_VENDOR_CENTAUR | X86_VENDOR_SHANGHAI) ) { /* Recover sysenter MSRs */ wrmsrl(MSR_IA32_SYSENTER_ESP, saved_sysenter_esp); diff --git a/xen/arch/x86/x86_64/traps.c b/xen/arch/x86/x86_64/traps.c index 44af765..6506d6a 100644 --- a/xen/arch/x86/x86_64/traps.c +++ b/xen/arch/x86/x86_64/traps.c @@ -334,7 +334,8 @@ void subarch_percpu_traps_init(void) (unsigned long)lstar_enter); stub_va += offset; -if ( boot_cpu_data.x86_vendor & (X86_VENDOR_INTEL | X86_VENDOR_CENTAUR) ) +if ( boot_cpu_data.x86_vendor & +(X86_VENDOR_INTEL | X86_VENDOR_CENTAUR | X86_VENDOR_SHANGHAI) ) { /* SYSENTER entry. */ wrmsrl(MSR_IA32_SYSENTER_ESP, stack_bottom); -- 1.8.3.1 ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [linux-linus test] 134885: regressions - FAIL
flight 134885 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/134885/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow217 guest-localmigrate/x10 fail REGR. vs. 133580 build-armhf-pvops 6 kernel-build fail REGR. vs. 133580 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 133580 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 133580 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 133580 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 133580 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stopfail like 133580 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stopfail like 133580 test-amd64-amd64-libvirt-xsm 13 migrate-support-checkfail never pass test-amd64-i386-xl-pvshim12 guest-start fail never pass test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-amd64-i386-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-credit1 13 migrate-support-checkfail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-checkfail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-checkfail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-checkfail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-checkfail never pass test-arm64-arm64-xl 13 migrate-support-checkfail never pass test-arm64-arm64-xl 14 saverestore-support-checkfail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-checkfail never pass test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-i386-xl-qemuu-win10-i386 10 windows-install fail never pass test-amd64-amd64-xl-qemut-win10-i386 10 windows-installfail never pass test-amd64-i386-xl-qemut-win10-i386 10 windows-install fail never pass test-amd64-amd64-xl-qemuu-win10-i386 10 windows-installfail never pass version targeted for testing: linux444fe991353987c1c9bc5ab1f903d01f1b4ad415 baseline version: linux736706bee3298208343a76096370e4f6a5c55915 Last test of basis 133580 2019-03-04 19:53:09 Z 45 days Failing since133605 2019-03-05 20:03:14 Z 44 days 24 attempts Testing same since 134885 2019-04-16 22:01:49 Z2 days1 attempts 2280 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops
Re: [Xen-devel] [PATCH v5] x86/altp2m: Aggregate get entry and populate into common funcs
On 18.04.2019 21:42, Tamas K Lengyel wrote: > On Thu, Apr 18, 2019 at 11:02 AM George Dunlap > wrote: >> >> On 4/18/19 2:59 PM, Tamas K Lengyel wrote: >>> On Thu, Apr 18, 2019 at 3:53 AM George Dunlap >>> wrote: On 4/17/19 7:22 PM, Tamas K Lengyel wrote: > On Wed, Apr 17, 2019 at 1:15 AM Alexandru Stefan ISAILA > wrote: >> >> >> >> On 16.04.2019 18:07, George Dunlap wrote: >>> On 4/16/19 3:19 PM, Tamas K Lengyel wrote: On Tue, Apr 16, 2019 at 8:02 AM George Dunlap wrote: > > On 4/16/19 2:44 PM, Tamas K Lengyel wrote: >> On Tue, Apr 16, 2019 at 2:45 AM Alexandru Stefan ISAILA >> wrote: >>> >>> The code for getting the entry and then populating was repeated in >>> p2m_change_altp2m_gfn() and in p2m_set_altp2m_mem_access(). >>> >>> The code is now in one place with a bool param that lets the caller >>> choose >>> if it populates after get_entry(). >>> >>> If remapping is being done then both the old and new gfn's should be >>> unshared in the hostp2m for keeping things consistent. The page type >>> of old_gfn was already checked whether it's p2m_ram_rw and bail if >>> it >>> wasn't so functionality-wise this just simplifies things as a user >>> doesn't have to request unsharing manually before remapping. >>> Now, if the new_gfn is invalid it shouldn't query the hostp2m as >>> that is effectively a request to remove the entry from the altp2m. >>> But provided that scenario is used only when removing entries that >>> were previously remapped/copied to the altp2m, those entries already >>> went through P2M_ALLOC | P2M_UNSHARE before, so it won't have an >>> affect so the core function get_altp2m_entry() is calling >>> __get_gfn_type_access() with P2M_ALLOC | P2M_UNSHARE. >>> >>> altp2m_get_entry_direct() is also called in p2m_set_suppress_ve() >>> because on a new altp2m view the function will fail with invalid >>> mfn if >>> p2m->set_entry() was not called before. >>> >>> Signed-off-by: Alexandru Isaila >>> Signed-off-by: George Dunlap >>> Reviewed-by: George Dunlap >>> >>> --- >>> Changes since V4: >>> - Add altp2m to patch name >>> - Change func name from get_altp2m_entry() to >>> altp2m_get_entry(). >>> --- >>>xen/arch/x86/mm/mem_access.c | 30 ++--- >>>xen/arch/x86/mm/p2m.c| 84 >>> >>>xen/include/asm-x86/p2m.h| 17 >>>3 files changed, 66 insertions(+), 65 deletions(-) >>> >>> diff --git a/xen/arch/x86/mm/mem_access.c >>> b/xen/arch/x86/mm/mem_access.c >>> index a144bb0ce4..ddfe0169c0 100644 >>> --- a/xen/arch/x86/mm/mem_access.c >>> +++ b/xen/arch/x86/mm/mem_access.c >>> @@ -262,35 +262,11 @@ int p2m_set_altp2m_mem_access(struct domain >>> *d, struct p2m_domain *hp2m, >>>mfn_t mfn; >>>p2m_type_t t; >>>p2m_access_t old_a; >>> -unsigned int page_order; >>> -unsigned long gfn_l = gfn_x(gfn); >>>int rc; >>> >>> -mfn = ap2m->get_entry(ap2m, gfn, , _a, 0, NULL, NULL); >>> - >>> -/* Check host p2m if no valid entry in alternate */ >>> -if ( !mfn_valid(mfn) ) >>> -{ >>> - >>> -mfn = __get_gfn_type_access(hp2m, gfn_l, , _a, >>> -P2M_ALLOC | P2M_UNSHARE, >>> _order, 0); >>> - >>> -rc = -ESRCH; >>> -if ( !mfn_valid(mfn) || t != p2m_ram_rw ) >>> -return rc; >>> - >>> -/* If this is a superpage, copy that first */ >>> -if ( page_order != PAGE_ORDER_4K ) >>> -{ >>> -unsigned long mask = ~((1UL << page_order) - 1); >>> -gfn_t gfn2 = _gfn(gfn_l & mask); >>> -mfn_t mfn2 = _mfn(mfn_x(mfn) & mask); >>> - >>> -rc = ap2m->set_entry(ap2m, gfn2, mfn2, page_order, t, >>> old_a, 1); >>> -if ( rc ) >>> -return rc; >>> -} >>> -} >>> +rc = altp2m_get_entry_prepopulate(ap2m, gfn, , , _a); >>> +if ( rc ) >>> +return rc; >>> >>>/* >>> * Inherit the old suppress #VE bit value if it is already >>> set, or set it >>> diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c >>> index 9e81a30cc4..7bedfd593b 100644 >>> ---
[Xen-devel] [distros-debian-jessie test] 84037: trouble: blocked/broken
flight 84037 distros-debian-jessie real [real] http://osstest.xensource.com/osstest/logs/84037/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-i386 broken build-amd64-pvopsbroken build-armhf broken build-amd64 broken build-i386-pvops broken build-armhf-pvops 3 syslog-serverrunning build-armhf 3 syslog-serverrunning Tests which did not succeed, but are not blocking: test-amd64-i386-i386-jessie-netboot-pvgrub 1 build-check(1) blocked n/a test-amd64-i386-amd64-jessie-netboot-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-i386-jessie-netboot-pygrub 1 build-check(1) blocked n/a test-armhf-armhf-armhf-jessie-netboot-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-amd64-jessie-netboot-pvgrub 1 build-check(1) blocked n/a build-armhf-pvops 4 host-install(4) broken like 83925 build-armhf 4 host-install(4) broken like 83925 build-amd64-pvops 4 host-install(4) broken like 83925 build-amd64 4 host-install(4) broken like 83925 build-i386-pvops 4 host-install(4) broken like 83925 build-i3864 host-install(4) broken like 83925 build-armhf-pvops 5 capture-logs broken like 83925 build-armhf 5 capture-logs broken like 83925 baseline version: flight 83925 jobs: build-amd64 broken build-armhf broken build-i386 broken build-amd64-pvopsbroken build-armhf-pvopsbroken build-i386-pvops broken test-amd64-amd64-amd64-jessie-netboot-pvgrub blocked test-amd64-i386-i386-jessie-netboot-pvgrub blocked test-amd64-i386-amd64-jessie-netboot-pygrub blocked test-armhf-armhf-armhf-jessie-netboot-pygrub blocked test-amd64-amd64-i386-jessie-netboot-pygrub blocked sg-report-flight on osstest.xs.citrite.net logs: /home/osstest/logs images: /home/osstest/images Logs, config files, etc. are available at http://osstest.xensource.com/osstest/logs Test harness code can be found at http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary Push not applicable. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [xen-4.8-testing test] 134871: regressions - FAIL
flight 134871 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/134871/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 130965 build-i386-prev 6 xen-buildfail REGR. vs. 130965 build-amd64-prev 6 xen-buildfail REGR. vs. 130965 build-i386-xsm6 xen-buildfail REGR. vs. 130965 build-amd64 6 xen-buildfail REGR. vs. 130965 build-i3866 xen-buildfail REGR. vs. 130965 Tests which did not succeed, but are not blocking: test-amd64-i386-livepatch 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-xtf-amd64-amd64-51 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1)blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-i386-qemut-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-win10-i386 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win10-i386 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-debianhvm-amd64 1 build-check(1)blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-xtf-amd64-amd64-31 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl1 build-check(1) blocked n/a test-xtf-amd64-amd64-11 build-check(1) blocked n/a test-amd64-i386-qemut-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-amd64-pvgrub 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-migrupgrade 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win10-i386 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm 1 build-check(1)blocked n/a test-amd64-i386-xl-raw1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-xtf-amd64-amd64-21 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win10-i386 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1)
[Xen-devel] [xen-unstable-smoke test] 134980: regressions - FAIL
flight 134980 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/134980/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 133991 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-checkfail never pass test-armhf-armhf-xl 13 migrate-support-checkfail never pass test-armhf-armhf-xl 14 saverestore-support-checkfail never pass version targeted for testing: xen be3d5b30331d87e177744dbe23138b9ebcdc86f1 baseline version: xen cb70a26f78848fe45f593f7ebc9cfaac760a791b Last test of basis 133991 2019-03-22 15:00:46 Z 27 days Failing since134068 2019-03-25 12:00:51 Z 24 days 130 attempts Testing same since 134834 2019-04-15 19:00:48 Z3 days 24 attempts People who touched revisions under test: Alexandru Isaila Alexandru Stefan ISAILA Amit Singh Tomar Andrew Cooper Anthony PERARD Brian Woods Christian Lindig Doug Goldstein George Dunlap Igor Druzhinin Jan Beulich Juergen Gross Julien Grall Kevin Tian Lukas Juenger M A Young Norbert Manthey Oleksandr Andrushchenko Paul Durrant Pawel Wieczorkiewicz Petre Pircalabu Razvan Cojocaru Tamas K Lengyel Wei Liu Xiaochen Wang Xin Li jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386 fail test-amd64-amd64-libvirt pass sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2099 lines long.) ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [ovmf test] 134977: all pass - PUSHED
flight 134977 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/134977/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c2f643479eb3f00d930c461cdec3ba420a36072c baseline version: ovmf 0eccea3fbe2f6d4999d972d9310d4f2717f5100c Last test of basis 134889 2019-04-16 23:11:24 Z2 days Failing since134935 2019-04-18 01:11:23 Z1 days7 attempts Testing same since 134965 2019-04-18 18:41:35 Z0 days4 attempts People who touched revisions under test: Ard Biesheuvel Bret Barkelew Fan, ZhijuX Gary Lin Laszlo Ersek Zailiang Sun Zhichao Gao Zhiju.Fan jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvopspass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 0eccea3fbe..c2f643479e c2f643479eb3f00d930c461cdec3ba420a36072c -> xen-tested-master ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [linux-4.19 test] 134875: regressions - FAIL
flight 134875 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/134875/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken in 134615 build-arm64-xsm broken in 134615 build-arm64 broken in 134615 build-arm64-xsm4 host-install(4) broken in 134615 REGR. vs. 129313 build-arm644 host-install(4) broken in 134615 REGR. vs. 129313 build-arm64-pvops 4 host-install(4) broken in 134615 REGR. vs. 129313 test-arm64-arm64-examine11 examine-serial/bootloader fail REGR. vs. 129313 build-i386-pvops 6 kernel-build fail REGR. vs. 129313 build-armhf-pvops 6 kernel-build fail REGR. vs. 129313 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow217 guest-localmigrate/x10 fail pass in 134615 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 134615 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 134615 n/a build-arm64-libvirt 1 build-check(1) blocked in 134615 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 134615 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 134615 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 134615 n/a test-arm64-arm64-examine 1 build-check(1) blocked in 134615 n/a test-amd64-i386-examine 1 build-check(1) blocked n/a test-amd64-i386-qemut-rhel6hvm-amd 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-win10-i386 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-win7-amd64 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-ws16-amd64 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-qemut-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-raw1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-libvirt 13 migrate-support-check fail in 134615 never pass test-amd64-i386-xl-pvshim12 guest-start fail in 134615 never pass
[Xen-devel] tools/Makefile: the qemu-xen-dir-remote directory in qemu-xen-dir-force-update target
I am looking to build a Xen from a downloaded source tree at commit cb70a26 In the tools/Makefile, there is this target at Line 204 .PHONY: qemu-xen-dir-force-update qemu-xen-dir-force-update: qemu-xen-dir-find set -ex; \ if [ "$(QEMU_UPSTREAM_REVISION)" ]; then \ cd qemu-xen-dir-remote; \ $(GIT) fetch origin; \ $(GIT) reset --hard $(QEMU_UPSTREAM_REVISION); \ fi however, i can't find any other mention of the directory "qemu-xen-dir-remote;" in the source tree, other than the removal of it in the same Makefile's distclean target, vis: .PHONY: distclean distclean: subdirs-distclean clean rm -rf qemu-xen-traditional-dir qemu-xen-traditional-dir-remote rm -rf qemu-xen-dir qemu-xen-dir-remote qemu-xen-build rm -rf ../config/Tools.mk config.h config.log config.status \ config.cache autom4te.cache so where would it get created ? ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] Hypervisor build can't work without `python` (Was: Re: Xen commit 9b0bc91b3 possibly removed too much info from README)
On Wed, 17 Apr 2019 at 22:51, Wei Liu wrote: > > > Frankly I'm not a big fan of this approach -- you can potentially get > different toolchain depending on how you build stuff. I would rather > just document that for hypervisor build either python is available or > you should specify PYTHON= when invoking make. > > Wei. As I started all this off, I thought I'd add in a little bit more, as I think there may be more ot this than meets the eye, well, certainly my eye anyway. Clearly, many of the scripts in the tools part use python scripts that have a /usr/bin/env python approach to finding a "python" I therefore tried making a link from /usr/bin/python3 to /usr/bin/python and then ran the configure, WITHOUT defining a PYTHON ./configure --prefix=/usr \ --disable-seabios \ --disable-qemu-traditional \ --disable-rombios \ --disable-stubdom 2>&1 | tee ../config.log This failed whilst looking for Python.h So, even though I have the link, I have still been running the configure WITH a PYTHON being defined PYTHON=/usr/bin/python3 ./configure --prefix=/usr \ --disable-seabios \ --disable-qemu-traditional \ --disable-rombios \ --disable-stubdom 2>&1 | tee ../config.log and that does appear to configure things. My "make world" is still failing I am actually thinking of installing a Python 2 and making the link to the bare /usr/bin/python point to that, just to see if I can get things to build. Hope that's useful, Kevin PS I have another question about the /tools/Makefile but I'll ask that in another thread. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel