Re: [PATCH] tools/xenstored: Remove unused prototype
Hi Juergen, On 21/04/2021 08:39, Juergen Gross wrote: On 20.04.21 15:49, Julien Grall wrote: From: Julien Grall A prototype for dump_conn() has been present for quite a long time but there are no implementation. Even, AFAICT in the patch that introduced it. So drop it. Signed-off-by: Julien Grall Reviewed-by: Juergen Gross Thanks! I have committed it. Cheers, -- Julien Grall
Re: [PATCH] tools/xenstored: Remove unused prototype
On 20.04.21 15:49, Julien Grall wrote: From: Julien Grall A prototype for dump_conn() has been present for quite a long time but there are no implementation. Even, AFAICT in the patch that introduced it. So drop it. Signed-off-by: Julien Grall Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: application/pgp-keys OpenPGP_signature Description: OpenPGP digital signature
Re: [PATCH] tools/xenstored: Remove unused prototype
Hi Julien, On 20 Apr 2021, at 14:49, Julien Grall mailto:jul...@xen.org>> wrote: From: Julien Grall mailto:jgr...@amazon.com>> A prototype for dump_conn() has been present for quite a long time but there are no implementation. Even, AFAICT in the patch that introduced it. So drop it. Signed-off-by: Julien Grall mailto:jgr...@amazon.com>> Agree, no implementation of this exists so: Reviewed-by: Bertrand Marquis mailto:bertrand.marq...@arm.com>> Cheers Bertrand --- tools/xenstore/xenstored_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index d54a6042a9f7..591b28e4552f 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2085,7 +2085,6 @@ static struct option options[] = { #endif { NULL, 0, NULL, 0 } }; -extern void dump_conn(struct connection *conn); int dom0_domid = 0; int dom0_event = 0; int priv_domid = 0; -- 2.17.1
[PATCH] tools/xenstored: Remove unused prototype
From: Julien Grall A prototype for dump_conn() has been present for quite a long time but there are no implementation. Even, AFAICT in the patch that introduced it. So drop it. Signed-off-by: Julien Grall --- tools/xenstore/xenstored_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index d54a6042a9f7..591b28e4552f 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2085,7 +2085,6 @@ static struct option options[] = { #endif { NULL, 0, NULL, 0 } }; -extern void dump_conn(struct connection *conn); int dom0_domid = 0; int dom0_event = 0; int priv_domid = 0; -- 2.17.1