Re: [PATCH] xen/xsm: dummy.h: Fix MISRA C 2012 Directive 4.10 violation

2022-07-28 Thread Daniel P. Smith

On 7/27/22 11:19, Xenia Ragiadakou wrote:

Protect header file from being included more than once by adding ifndef guard.

Signed-off-by: Xenia Ragiadakou 
---
  xen/include/xsm/dummy.h | 5 +
  1 file changed, 5 insertions(+)

diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
index 77f27e7163..8671af1ba4 100644
--- a/xen/include/xsm/dummy.h
+++ b/xen/include/xsm/dummy.h
@@ -15,6 +15,9 @@
   *  value of action.
   */
  
+#ifndef __XEN_XSM_DUMMY_H__

+#define __XEN_XSM_DUMMY_H__
+
  #include 
  #include 
  #include 
@@ -843,3 +846,5 @@ static XSM_INLINE int cf_check xsm_domain_resource_map(
  XSM_ASSERT_ACTION(XSM_DM_PRIV);
  return xsm_default_action(action, current->domain, d);
  }
+
+#endif /* __XEN_XSM_DUMMY_H__ */


Acked-by: Daniel P. Smith 



Re: [PATCH] xen/xsm: dummy.h: Fix MISRA C 2012 Directive 4.10 violation

2022-07-28 Thread Luca Fancellu



> On 27 Jul 2022, at 16:19, Xenia Ragiadakou  wrote:
> 
> Protect header file from being included more than once by adding ifndef guard.
> 
> Signed-off-by: Xenia Ragiadakou 

It makes sense!

Reviewed-by: Luca Fancellu 





[PATCH] xen/xsm: dummy.h: Fix MISRA C 2012 Directive 4.10 violation

2022-07-27 Thread Xenia Ragiadakou
Protect header file from being included more than once by adding ifndef guard.

Signed-off-by: Xenia Ragiadakou 
---
 xen/include/xsm/dummy.h | 5 +
 1 file changed, 5 insertions(+)

diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
index 77f27e7163..8671af1ba4 100644
--- a/xen/include/xsm/dummy.h
+++ b/xen/include/xsm/dummy.h
@@ -15,6 +15,9 @@
  *  value of action.
  */
 
+#ifndef __XEN_XSM_DUMMY_H__
+#define __XEN_XSM_DUMMY_H__
+
 #include 
 #include 
 #include 
@@ -843,3 +846,5 @@ static XSM_INLINE int cf_check xsm_domain_resource_map(
 XSM_ASSERT_ACTION(XSM_DM_PRIV);
 return xsm_default_action(action, current->domain, d);
 }
+
+#endif /* __XEN_XSM_DUMMY_H__ */
-- 
2.34.1