Re: [PATCH 5/5] libxl: drop dead assignment to transaction variable from libxl__domain_make()

[Anthony PERARD]

On Mon, Jun 12, 2023 at 01:47:50PM +0200, Jan Beulich wrote:
> "t" is written first thing at the "retry_transaction" label.
> 
> Coverity ID: 1532321
> Fixes: 1057300109ea ("libxl: fix error handling (xenstore transaction leak) 
> in libxl__domain_make")
> Signed-off-by: Jan Beulich 

Acked-by: Anthony PERARD 

Thanks,

-- 
Anthony PERARD

Re: [PATCH 5/5] libxl: drop dead assignment to transaction variable from libxl__domain_make()

[Juergen Gross]

On 12.06.23 13:47, Jan Beulich wrote:

"t" is written first thing at the "retry_transaction" label.

Coverity ID: 1532321
Fixes: 1057300109ea ("libxl: fix error handling (xenstore transaction leak) in 
libxl__domain_make")
Signed-off-by: Jan Beulich 


Reviewed-by: Juergen Gross 


Juergen



OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

[PATCH 5/5] libxl: drop dead assignment to transaction variable from libxl__domain_make()

[Jan Beulich]

"t" is written first thing at the "retry_transaction" label.

Coverity ID: 1532321
Fixes: 1057300109ea ("libxl: fix error handling (xenstore transaction leak) in 
libxl__domain_make")
Signed-off-by: Jan Beulich 

--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -909,10 +909,8 @@ retry_transaction:
  strlen(dom_type));
 
 if (!xs_transaction_end(ctx->xsh, t, 0)) {
-if (errno == EAGAIN) {
-t = 0;
+if (errno == EAGAIN)
 goto retry_transaction;
-}
 LOGED(ERROR, *domid, "domain creation ""xenstore transaction commit 
failed");
 rc = ERROR_FAIL;
 goto out;