Re: [PATCH v3 03/34] xen: add support in public/hvm/save.h for PPC and RISC-V
On Thu, 2024-01-04 at 12:01 +0100, Jan Beulich wrote: > On 22.12.2023 16:12, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > Since you change how PPC is handled, this can't go without > description (i.e. > justification). I thought adding a comment in the code would be sufficient. I can include something similar in the commit message as well. ~ Oleksii > > > --- a/xen/include/public/hvm/save.h > > +++ b/xen/include/public/hvm/save.h > > @@ -89,8 +89,8 @@ DECLARE_HVM_SAVE_TYPE(END, 0, struct > > hvm_save_end); > > #include "../arch-x86/hvm/save.h" > > #elif defined(__arm__) || defined(__aarch64__) > > #include "../arch-arm/hvm/save.h" > > -#elif defined(__powerpc64__) > > -#include "../arch-ppc.h" > > +#elif defined(__powerpc64__) || defined(__riscv) > > +/* no specific header to include */ > > #else > > #error "unsupported architecture" > > #endif >
Re: [PATCH v3 03/34] xen: add support in public/hvm/save.h for PPC and RISC-V
On 22.12.2023 16:12, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko Since you change how PPC is handled, this can't go without description (i.e. justification). Jan > --- a/xen/include/public/hvm/save.h > +++ b/xen/include/public/hvm/save.h > @@ -89,8 +89,8 @@ DECLARE_HVM_SAVE_TYPE(END, 0, struct hvm_save_end); > #include "../arch-x86/hvm/save.h" > #elif defined(__arm__) || defined(__aarch64__) > #include "../arch-arm/hvm/save.h" > -#elif defined(__powerpc64__) > -#include "../arch-ppc.h" > +#elif defined(__powerpc64__) || defined(__riscv) > +/* no specific header to include */ > #else > #error "unsupported architecture" > #endif
[PATCH v3 03/34] xen: add support in public/hvm/save.h for PPC and RISC-V
Signed-off-by: Oleksii Kurochko --- Changes in V3: - update the commit message. - For PPC and RISC-V nothing to include in public/hvm/save.h, so just comment was added. --- Changes in V2: - remove copyright an the top of hvm/save.h as the header write now is a newly introduced empty header. --- xen/include/public/hvm/save.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/include/public/hvm/save.h b/xen/include/public/hvm/save.h index ff0048e5f8..31b5cd163b 100644 --- a/xen/include/public/hvm/save.h +++ b/xen/include/public/hvm/save.h @@ -89,8 +89,8 @@ DECLARE_HVM_SAVE_TYPE(END, 0, struct hvm_save_end); #include "../arch-x86/hvm/save.h" #elif defined(__arm__) || defined(__aarch64__) #include "../arch-arm/hvm/save.h" -#elif defined(__powerpc64__) -#include "../arch-ppc.h" +#elif defined(__powerpc64__) || defined(__riscv) +/* no specific header to include */ #else #error "unsupported architecture" #endif -- 2.43.0
