Re: [XEN PATCH 09/11] xen/param: address a violation of MISRA C:2012 Rule 8.2

2023-11-30 Thread Stefano Stabellini 
On Fri, 24 Nov 2023, Federico Serafini wrote:
> Add missing parameter name. No functional change.
> 
> Signed-off-by: Federico Serafini 

Reviewed-by: Stefano Stabellini

Re: [XEN PATCH 09/11] xen/param: address a violation of MISRA C:2012 Rule 8.2

2023-11-30 Thread Jan Beulich 
On 24.11.2023 15:03, Federico Serafini wrote:
> Add missing parameter name. No functional change.
> 
> Signed-off-by: Federico Serafini 

Acked-by: Jan Beulich 

> --- a/xen/include/xen/param.h
> +++ b/xen/include/xen/param.h
> @@ -22,7 +22,7 @@ struct kernel_param {
>  unsigned int len;
>  union {
>  void *var;
> -int (*func)(const char *);
> +int (*func)(const char *s);

Still I again wonder what good this name does us here.

Jan

[XEN PATCH 09/11] xen/param: address a violation of MISRA C:2012 Rule 8.2

2023-11-24 Thread Federico Serafini 
Add missing parameter name. No functional change.

Signed-off-by: Federico Serafini 
---
 xen/include/xen/param.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/xen/param.h b/xen/include/xen/param.h
index 93c3fe7cb7..9170455cde 100644
--- a/xen/include/xen/param.h
+++ b/xen/include/xen/param.h
@@ -22,7 +22,7 @@ struct kernel_param {
 unsigned int len;
 union {
 void *var;
-int (*func)(const char *);
+int (*func)(const char *s);
 } par;
 };
 
-- 
2.34.1