Re: [Xen-devel] [Minios-devel] [PATCH] mini-os: add a coding style file

2018-02-13 Thread Wei Liu
On Mon, Feb 12, 2018 at 11:59:23AM +0100, Juergen Gross wrote:
> On 09/11/17 13:45, Wei Liu wrote:
> > On Thu, Nov 09, 2017 at 01:35:49PM +0100, Juergen Gross wrote:
> >> On 09/11/17 13:31, Wei Liu wrote:
> >>> On Thu, Nov 09, 2017 at 01:10:12PM +0100, Juergen Gross wrote:
>  Since carving out Mini-OS from the Xen repository there hasn't been a
>  description of the preferred coding style. Copy the Xen CODING_STYLE
>  file.
> 
> >>>
> >>> I welcome such addition. I have no opinion in actual style used though.
> >>> I just want consistency. :-)
> >>
> >> Is this an Ack?
> >>
> > 
> > Yes.
> > 
> > Acked-by: Wei Liu 
> 
> So this is pending for 3 months now...
> 

Oops, sorry. You know why I didn't get to this earlier. :-)

This and other pending patches will be committed shortly.

Wei.

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [Minios-devel] [PATCH] mini-os: add a coding style file

2018-02-12 Thread Juergen Gross
On 09/11/17 13:45, Wei Liu wrote:
> On Thu, Nov 09, 2017 at 01:35:49PM +0100, Juergen Gross wrote:
>> On 09/11/17 13:31, Wei Liu wrote:
>>> On Thu, Nov 09, 2017 at 01:10:12PM +0100, Juergen Gross wrote:
 Since carving out Mini-OS from the Xen repository there hasn't been a
 description of the preferred coding style. Copy the Xen CODING_STYLE
 file.

>>>
>>> I welcome such addition. I have no opinion in actual style used though.
>>> I just want consistency. :-)
>>
>> Is this an Ack?
>>
> 
> Yes.
> 
> Acked-by: Wei Liu 

So this is pending for 3 months now...


Juergen

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel