Re: [Xen-devel] [Minios-devel] [PATCH RFC 00/16] Save/Restore Support for mini-OS PVH

2017-12-19 Thread Samuel Thibault 
About patch 16, 
"Replace xenstore and console pfns with the correspondent mfns"
seems exactly contrary to what the code does.
Apart from that,

Reviewed-by: Samuel Thibault 

Samuel

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [Minios-devel] [PATCH RFC 00/16] Save/Restore Support for mini-OS PVH

2017-12-19 Thread Samuel Thibault 
About patch 15, it seems your terminal is set to see tabs as 4 spaces.
Where tabs are used, the mini-os source code assumes 8 spaces. Avoid
using tabs, just use spaces :)

And, avoid

for (list = dev_list; list->next != NULL; list = list->next);

better write

for (list = dev_list; list->next != NULL; list = list->next)
;

to make it explicit that the loop is empty.

Also, 

 *ip = malloc(strlen(ldev->ip) + 1);
 strncpy(*ip, ldev->ip, strlen(ldev->ip) + 1);

can be a mere *ip = strdup(ldev->ip), can't it?

Apart from that,

Reviewed-by: Samuel Thibault 

Samuel

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [Minios-devel] [PATCH RFC 00/16] Save/Restore Support for mini-OS PVH

2017-12-19 Thread Samuel Thibault 
Again, I didn't find patch 11, so I got it from here

Bruno Alvisio, on mar. 19 déc. 2017 15:41:55 -0800, wrote:
> https://github.com/balvisio/mini-os/tree/feature/mini-os-suspend-support

There are indentation oddities bringing spurious hunks. Apart from that,

Reviewed-by: Samuel Thibault 

Samuel

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel