[Xen-devel] [PATCH] ALSA: xen-front: signdness bug in alsa_prepare()

2018-05-31 Thread Dan Carpenter 
"sndif_format" needs to be signed for the error handling to work.

Fixes: 1cee559351a7 ("ALSA: xen-front: Implement ALSA virtual sound driver")
Signed-off-by: Dan Carpenter 

diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
index 5041f83e98d2..43478f66954a 100644
--- a/sound/xen/xen_snd_front_alsa.c
+++ b/sound/xen/xen_snd_front_alsa.c
@@ -463,7 +463,7 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
 
if (!stream->is_open) {
struct snd_pcm_runtime *runtime = substream->runtime;
-   u8 sndif_format;
+   int sndif_format;
int ret;
 
sndif_format = to_sndif_format(runtime->format);

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] ALSA: xen-front: signdness bug in alsa_prepare()

2018-05-31 Thread Oleksandr Andrushchenko 

On 05/31/2018 09:25 AM, Dan Carpenter wrote:

"sndif_format" needs to be signed for the error handling to work.

Fixes: 1cee559351a7 ("ALSA: xen-front: Implement ALSA virtual sound driver")
Signed-off-by: Dan Carpenter 

diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
index 5041f83e98d2..43478f66954a 100644
--- a/sound/xen/xen_snd_front_alsa.c
+++ b/sound/xen/xen_snd_front_alsa.c
@@ -463,7 +463,7 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
  
  	if (!stream->is_open) {

struct snd_pcm_runtime *runtime = substream->runtime;
-   u8 sndif_format;
+   int sndif_format;
int ret;
  
  		sndif_format = to_sndif_format(runtime->format);

Thank you for your patch,
please see 
https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/sound/xen?h=for-next=014cea591afac9b3dae61793446f83d5be634203



___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel