Re: [Xen-devel] [PATCH] x86/pv: Use xmemdup() for cpuidmasks, rather than opencoding it

2018-08-16 Thread Roger Pau Monné 
On Wed, Aug 15, 2018 at 10:54:11AM +0100, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper 

Reviewed-by: Roger Pau Monné 

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/pv: Use xmemdup() for cpuidmasks, rather than opencoding it

2018-08-15 Thread Jan Beulich 
>>> On 15.08.18 at 11:58,  wrote:
> On Wed, Aug 15, 2018 at 10:54:11AM +0100, Andrew Cooper wrote:
>> Signed-off-by: Andrew Cooper 
> 
> Reviewed-by: Wei Liu 

Acked-by: Jan Beulich 




___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/pv: Use xmemdup() for cpuidmasks, rather than opencoding it

2018-08-15 Thread Wei Liu 
On Wed, Aug 15, 2018 at 10:54:11AM +0100, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper 

Reviewed-by: Wei Liu 

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH] x86/pv: Use xmemdup() for cpuidmasks, rather than opencoding it

2018-08-15 Thread Andrew Cooper 
Signed-off-by: Andrew Cooper 
---
CC: Jan Beulich 
CC: Wei Liu 
CC: Roger Pau Monné 
---
 xen/arch/x86/pv/domain.c | 10 +++---
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/xen/arch/x86/pv/domain.c b/xen/arch/x86/pv/domain.c
index 3230ac6..52108d4 100644
--- a/xen/arch/x86/pv/domain.c
+++ b/xen/arch/x86/pv/domain.c
@@ -240,13 +240,9 @@ int pv_domain_initialise(struct domain *d)
 goto fail;
 clear_page(d->arch.pv_domain.gdt_ldt_l1tab);
 
-if ( levelling_caps & ~LCAP_faulting )
-{
-d->arch.pv_domain.cpuidmasks = xmalloc(struct cpuidmasks);
-if ( !d->arch.pv_domain.cpuidmasks )
-goto fail;
-*d->arch.pv_domain.cpuidmasks = cpuidmask_defaults;
-}
+if ( levelling_caps & ~LCAP_faulting &&
+ (d->arch.pv_domain.cpuidmasks = xmemdup(&cpuidmask_defaults)) == NULL 
)
+goto fail;
 
 rc = create_perdomain_mapping(d, GDT_LDT_VIRT_START,
   GDT_LDT_MBYTES << (20 - PAGE_SHIFT),
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel