Re: [Xen-devel] [PATCH 11/34] xen/pt: io.c contains HVM only code
>>> On 17.08.18 at 17:12, wrote: > --- a/xen/drivers/passthrough/Makefile > +++ b/xen/drivers/passthrough/Makefile > @@ -4,6 +4,8 @@ subdir-$(CONFIG_X86) += x86 > subdir-$(CONFIG_ARM) += arm > > obj-y += iommu.o > -obj-$(CONFIG_X86) += io.o > +ifeq ($(CONFIG_X86),y) > +obj-$(CONFIG_HVM) += io.o > +endif What to do here depends on whether HVM is to become visible as a config option on ARM: If it doesn't, no ifeq() or alike is needed here at all. If it does, I'd favor using consistently the list approach, i.e. x86-y := ... x86-$(CONFIG_HVM) += io.o obj-$(CONFIG_X86) += $(x86-y) Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [PATCH 11/34] xen/pt: io.c contains HVM only code
We still need to test CONFIG_X86 because Arm also defines CONFIG_HVM. Signed-off-by: Wei Liu --- xen/drivers/passthrough/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/Makefile b/xen/drivers/passthrough/Makefile index 6087333..6b2d2e0 100644 --- a/xen/drivers/passthrough/Makefile +++ b/xen/drivers/passthrough/Makefile @@ -4,6 +4,8 @@ subdir-$(CONFIG_X86) += x86 subdir-$(CONFIG_ARM) += arm obj-y += iommu.o -obj-$(CONFIG_X86) += io.o +ifeq ($(CONFIG_X86),y) +obj-$(CONFIG_HVM) += io.o +endif obj-$(CONFIG_HAS_PCI) += pci.o obj-$(CONFIG_HAS_DEVICE_TREE) += device_tree.o -- git-series 0.9.1 ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
