Re: [Xen-devel] [PATCH RFC 07/15] xen/arm: increase MAX_MODULES

[Julien Grall]

Hi Doug,

On 06/07/18 03:10, Doug Goldstein wrote:

On Wed, Jun 13, 2018 at 03:15:10PM -0700, Stefano Stabellini wrote:

Xen boot modules need to account not just for Dom0 but also for a few
potential DomUs, each of them coming with their own kernel and initrd.
Increase MAX_MODULES to 32 to allow for more DomUs.

Signed-off-by: Stefano Stabellini 


Reviewed-by: Doug Goldstein 

Didn't see any comment on this so far so I figured I'd comment. This is
probably the least controversial patch and could just go in today.


The only reason I didn't comment this is because I wanted to see how the 
rest of the series go. The patch standalone is not something that is 
useful for Xen today as we will never have more than 5 modules. So I 
would rather wait the rest of the series before merging it.


Cheers,

--
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH RFC 07/15] xen/arm: increase MAX_MODULES

[Doug Goldstein]

On Wed, Jun 13, 2018 at 03:15:10PM -0700, Stefano Stabellini wrote:
> Xen boot modules need to account not just for Dom0 but also for a few
> potential DomUs, each of them coming with their own kernel and initrd.
> Increase MAX_MODULES to 32 to allow for more DomUs.
> 
> Signed-off-by: Stefano Stabellini 

Reviewed-by: Doug Goldstein 

Didn't see any comment on this so far so I figured I'd comment. This is
probably the least controversial patch and could just go in today.

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH RFC 07/15] xen/arm: increase MAX_MODULES

[Stefano Stabellini]

Xen boot modules need to account not just for Dom0 but also for a few
potential DomUs, each of them coming with their own kernel and initrd.
Increase MAX_MODULES to 32 to allow for more DomUs.

Signed-off-by: Stefano Stabellini 
---
 xen/include/asm-arm/setup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
index e190451..86aac0e 100644
--- a/xen/include/asm-arm/setup.h
+++ b/xen/include/asm-arm/setup.h
@@ -8,7 +8,7 @@
 
 #define NR_MEM_BANKS 128
 
-#define MAX_MODULES 5 /* Current maximum useful modules */
+#define MAX_MODULES 32 /* Current maximum useful modules */
 
 typedef enum {
 BOOTMOD_XEN,
-- 
1.9.1


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel