Re: [Xen-devel] [PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ with FreeBSD release targets

2017-12-05 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ 
with FreeBSD release targets"):
> On Tue, Dec 05, 2017 at 03:09:47PM +, Ian Jackson wrote:
> > Is that why you're not just updating osstest to expect the new
> > behaviour ?
> 
> Yes, I think it's more sensible to restore the previous behavior so
> that the same osstest script can be used to build FreeBSD from the
> master branch or the stable branches.

OK, jolly good.

Acked-by: Ian Jackson 

Ian.

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ with FreeBSD release targets

2017-12-05 Thread Roger Pau Monné
On Tue, Dec 05, 2017 at 03:09:47PM +, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ 
> with FreeBSD release targets"):
> > Due to a recent FreeBSD change the default output directory of the release
> > targets is changed to the object directory instead of the source
> > directory. Use WITHOUT_AUTO_OBJ to restore previous behavior. This is
> > harmless if used with previous versions, it will be ignored.
> 
> So the purpose of this is to make both versions of the build do the
> same thing, so osstest doesn't have to care ?
> 
> Is that why you're not just updating osstest to expect the new
> behaviour ?

Yes, I think it's more sensible to restore the previous behavior so
that the same osstest script can be used to build FreeBSD from the
master branch or the stable branches.

Roger.

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ with FreeBSD release targets

2017-12-05 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ with 
FreeBSD release targets"):
> Due to a recent FreeBSD change the default output directory of the release
> targets is changed to the object directory instead of the source
> directory. Use WITHOUT_AUTO_OBJ to restore previous behavior. This is
> harmless if used with previous versions, it will be ignored.

So the purpose of this is to make both versions of the build do the
same thing, so osstest doesn't have to care ?

Is that why you're not just updating osstest to expect the new
behaviour ?

Ian.

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel