Re: [Xen-devel] [PATCH v4 0/2] Refactor super page shattering
On 12/12/2019 13:16, Jan Beulich wrote: > On 12.12.2019 13:46, Hongyan Xia wrote: >> map_pages_to_xen and modify_xen_mappings use almost exactly the same >> page shattering logic, and the code is mingled with other PTE >> manipulations so it is less obvious that the intention is page >> shattering. Factor out the functions to make them reusable and to make >> the intention more obvious. >> >> Of course, there is not much difference between the shattering logic of >> each level, so we could further turn the per-level functions into a >> single macro, although this is not that simple since we have per-level >> functions and macros all over the place and there are slight differences >> between levels. Keep it per-level for now. > FWIW these look okay to me now, and I would give them my R-b without > if there wasn't the type safety issue. Andrew? There are correctness issues which I've pointed out, but WRT type safety, these look fine. ~Andrew ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v4 0/2] Refactor super page shattering
On 12.12.2019 13:46, Hongyan Xia wrote: > map_pages_to_xen and modify_xen_mappings use almost exactly the same > page shattering logic, and the code is mingled with other PTE > manipulations so it is less obvious that the intention is page > shattering. Factor out the functions to make them reusable and to make > the intention more obvious. > > Of course, there is not much difference between the shattering logic of > each level, so we could further turn the per-level functions into a > single macro, although this is not that simple since we have per-level > functions and macros all over the place and there are slight differences > between levels. Keep it per-level for now. FWIW these look okay to me now, and I would give them my R-b without if there wasn't the type safety issue. Andrew? Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
[Xen-devel] [PATCH v4 0/2] Refactor super page shattering
map_pages_to_xen and modify_xen_mappings use almost exactly the same page shattering logic, and the code is mingled with other PTE manipulations so it is less obvious that the intention is page shattering. Factor out the functions to make them reusable and to make the intention more obvious. Of course, there is not much difference between the shattering logic of each level, so we could further turn the per-level functions into a single macro, although this is not that simple since we have per-level functions and macros all over the place and there are slight differences between levels. Keep it per-level for now. tree: https://xenbits.xen.org/git-http/people/hx242/xen.git shatter-refactor_v4 --- Changes in v4: - helper functions now return bool instead of a random value. - rebase Changes in v3: - style and indentation fixes. Changes in v2: - rebase. - improve asm code. - avoid stale values when taking the lock. - move allocation of PTE tables inside the shatter function. Hongyan Xia (2): x86/mm: factor out the code for shattering an l3 PTE x86/mm: factor out the code for shattering an l2 PTE xen/arch/x86/mm.c | 194 +++--- 1 file changed, 98 insertions(+), 96 deletions(-) -- 2.17.1 ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
