Re: [Xen-devel] [PATCH v4 05/10] make it possible to enable/disable UART drivers

2018-06-01 Thread Jan Beulich 
>>> On 01.06.18 at 17:28,  wrote:
> On Fri, 1 Jun 2018, Jan Beulich wrote:
>> >>> On 31.05.18 at 23:48,  wrote:
>> > @@ -54,6 +54,7 @@ config HAS_SCIF
>> >  
>> >  config HAS_EHCI
>> >bool
>> > +  depends on X86
>> 
>> Just FTR: I won't NAK this, but I also won't ACK it.
> 
> Just this one line change, right? You would be fine with acking the rest
> of the patch? If so, then I only need Julien's ack?

Yes.

> FYI I am happy with anything regarding HAS_EHCI: I don't particularly
> care whether we make it available on ARM or not. As long as both Julien
> and you agree, I am fine with it.

Well, Julien and I don't agree, that's the whole point. But the disagreement
isn't bad enough to block this change, so I'm not against it going in with
someone else's ack.

Jan



___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 05/10] make it possible to enable/disable UART drivers

2018-06-01 Thread Stefano Stabellini 
On Fri, 1 Jun 2018, Jan Beulich wrote:
> >>> On 31.05.18 at 23:48,  wrote:
> > @@ -54,6 +54,7 @@ config HAS_SCIF
> >  
> >  config HAS_EHCI
> > bool
> > +   depends on X86
> 
> Just FTR: I won't NAK this, but I also won't ACK it.

Just this one line change, right? You would be fine with acking the rest
of the patch? If so, then I only need Julien's ack?

FYI I am happy with anything regarding HAS_EHCI: I don't particularly
care whether we make it available on ARM or not. As long as both Julien
and you agree, I am fine with it.

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 05/10] make it possible to enable/disable UART drivers

2018-06-01 Thread Jan Beulich 
>>> On 31.05.18 at 23:48,  wrote:
> @@ -54,6 +54,7 @@ config HAS_SCIF
>  
>  config HAS_EHCI
>   bool
> + depends on X86

Just FTR: I won't NAK this, but I also won't ACK it.

Jan



___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH v4 05/10] make it possible to enable/disable UART drivers

2018-05-31 Thread Stefano Stabellini 
All the UART drivers are silent options. Add one line descriptions so
that can be de/selected via menuconfig.

Add an x86 dependency to HAS_EHCI: EHCI PCI has not been used on ARM. In
fact, it depends on PCI, and moreover we have drivers for several
embedded UARTs for various ARM boards.

Signed-off-by: Stefano Stabellini 
CC: jbeul...@suse.com
CC: andrew.coop...@citrix.com
---
The next patch will take care of fixing arch dependencies.

Changes in v4:
- improve commit message
- remove prompt for HAS_EHCI

Changes in v3:
- NS16550 prompt if ARM

Changes in v2:
- make HAS_EHCI depend on x86
---
 xen/drivers/char/Kconfig | 15 ---
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
index cc78ec3..b1f07f8 100644
--- a/xen/drivers/char/Kconfig
+++ b/xen/drivers/char/Kconfig
@@ -1,11 +1,11 @@
 config HAS_NS16550
-   bool
+   bool "NS16550 UART driver" if ARM
default y
help
  This selects the 16550-series UART support. For most systems, say Y.
 
 config HAS_CADENCE_UART
-   bool
+   bool "Xilinx Cadence UART driver"
default y
depends on ARM_64
help
@@ -13,7 +13,7 @@ config HAS_CADENCE_UART
  based board, say Y.
 
 config HAS_MVEBU
-   bool
+   bool "Marvell MVEBU UART driver"
default y
depends on ARM_64
help
@@ -21,7 +21,7 @@ config HAS_MVEBU
  based board, say Y.
 
 config HAS_PL011
-   bool
+   bool "ARM PL011 UART driver"
default y
depends on ARM
help
@@ -29,7 +29,7 @@ config HAS_PL011
  an Integrator/PP2, Integrator/CP or Versatile platform, say Y.
 
 config HAS_EXYNOS4210
-   bool
+   bool "Samsung Exynos 4210 UART driver"
default y
depends on ARM_32
help
@@ -37,7 +37,7 @@ config HAS_EXYNOS4210
  Exynos based board, say Y.
 
 config HAS_OMAP
-   bool
+   bool "Texas Instruments OMAP UART driver"
default y
depends on ARM_32
help
@@ -45,7 +45,7 @@ config HAS_OMAP
  Instruments based CPU, say Y.
 
 config HAS_SCIF
-   bool
+   bool "SuperH SCI(F) UART driver"
default y
depends on ARM
help
@@ -54,6 +54,7 @@ config HAS_SCIF
 
 config HAS_EHCI
bool
+   depends on X86
help
  This selects the USB based EHCI debug port to be used as a UART. If
  you have an x86 based system with USB, say Y.
-- 
1.9.1


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel