Re: [Xen-devel] [PATCH] libxl: fix ARM build after 54ed251dc7
On Thu, Aug 16, 2018 at 08:41:55AM +0100, Andrew Cooper wrote: > On 16/08/2018 07:49, Jan Beulich wrote: > > Commit "tools: Rework xc_domain_create() to take a full > > xen_domctl_createdomain" failed to replace one further instance of > > xc_config in libxl__arch_domain_save_config(). > > > > Signed-off-by: Jan Beulich > > --- > > I have no environment set up to do cross tool stack builds, so the patch > > is solely based on osstest report and code inspection. > > Nor do I sadly, and we don't yet have this working in Travis/gitlab > which is that testing missed it. > > Acked-by: Andrew Cooper Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH] libxl: fix ARM build after 54ed251dc7
On 16/08/2018 07:49, Jan Beulich wrote: > Commit "tools: Rework xc_domain_create() to take a full > xen_domctl_createdomain" failed to replace one further instance of > xc_config in libxl__arch_domain_save_config(). > > Signed-off-by: Jan Beulich > --- > I have no environment set up to do cross tool stack builds, so the patch > is solely based on osstest report and code inspection. Nor do I sadly, and we don't yet have this working in Travis/gitlab which is that testing missed it. Acked-by: Andrew Cooper > > --- a/tools/libxl/libxl_arm.c > +++ b/tools/libxl/libxl_arm.c > @@ -125,7 +125,7 @@ int libxl__arch_domain_save_config(libxl__gc *gc, > return ERROR_FAIL; > } > > -state->clock_frequency = xc_config->clock_frequency; > +state->clock_frequency = config->arch.clock_frequency; > > return 0; > } > > ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
