Re: [Xen-devel] [PATCH] page-alloc: accompany BUG() with printk()
On 15/05/2019 11:09, Roger Pau Monné wrote: > On Wed, May 15, 2019 at 10:59:20AM +0100, Andrew Cooper wrote: >> On 15/05/2019 10:44, Roger Pau Monné wrote: >>> On Wed, May 15, 2019 at 02:44:07AM -0600, Jan Beulich wrote: Log information likely relevant for understanding why the BUG()s were >>> Why not use panic instead of printk + BUG? >> Because the backtrace is useful a lot of the time. > Oh, panic has no backtrace, that's not very useful. Maybe we could add > a panic_trace version to avoid having to do a printk + BUG. In any > case: TBH, It would be better for BUG() to take a printk-like , but arranging this to work is decidedly non-trivial, because it would have to be arranged from #UD context with some way of passing va_args() behind the scene. ~Andrew ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH] page-alloc: accompany BUG() with printk()
On Wed, May 15, 2019 at 10:59:20AM +0100, Andrew Cooper wrote: > On 15/05/2019 10:44, Roger Pau Monné wrote: > > On Wed, May 15, 2019 at 02:44:07AM -0600, Jan Beulich wrote: > >> Log information likely relevant for understanding why the BUG()s were > > Why not use panic instead of printk + BUG? > > Because the backtrace is useful a lot of the time. Oh, panic has no backtrace, that's not very useful. Maybe we could add a panic_trace version to avoid having to do a printk + BUG. In any case: Reviewed-by: Roger Pau Monné Thanks, Roger. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH] page-alloc: accompany BUG() with printk()
On 15/05/2019 09:44, Jan Beulich wrote: > Log information likely relevant for understanding why the BUG()s were > triggering. > > Requested-by: Andrew Cooper > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH] page-alloc: accompany BUG() with printk()
On 15/05/2019 10:44, Roger Pau Monné wrote: > On Wed, May 15, 2019 at 02:44:07AM -0600, Jan Beulich wrote: >> Log information likely relevant for understanding why the BUG()s were > Why not use panic instead of printk + BUG? Because the backtrace is useful a lot of the time. ~Andrew ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH] page-alloc: accompany BUG() with printk()
On Wed, May 15, 2019 at 02:44:07AM -0600, Jan Beulich wrote: > Log information likely relevant for understanding why the BUG()s were Why not use panic instead of printk + BUG? Thanks, Roger. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH] page-alloc: accompany BUG() with printk()
On Wed, May 15, 2019 at 02:44:07AM -0600, Jan Beulich wrote: > Log information likely relevant for understanding why the BUG()s were > triggering. > > Requested-by: Andrew Cooper > Signed-off-by: Jan Beulich > Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
