Re: [Xen-devel] [PATCH] tools/ocaml/libs/xc fix gcc-8 format-truncation warning

[Juergen Gross]

On 15/05/18 15:19, Wei Liu wrote:
> CC Juergen, I think this should be in 4.11
> 
> On Tue, May 15, 2018 at 11:48:43AM +1000, John Thomson wrote:
>>  CC   xenctrl_stubs.o
>> xenctrl_stubs.c: In function 'failwith_xc':
>> xenctrl_stubs.c:65:17: error: 'snprintf' output may be truncated before the 
>> last format character [-Werror=format-truncation=]
>>   "%d: %s: %s", error->code,
>>  ^
>> xenctrl_stubs.c:64:4: note: 'snprintf' output 6 or more bytes (assuming 
>> 1029) into a destination of size 1028
>> snprintf(error_str, sizeof(error_str),
>> ^~
>>   "%d: %s: %s", error->code,
>>   ~~
>>   xc_error_code_to_desc(error->code),
>>   ~~~
>>   error->message);
>>   ~~~
>> cc1: all warnings being treated as errors
>> make[8]: *** 
>> [/build/xen-git/src/xen/tools/ocaml/libs/xc/../../Makefile.rules:37: 
>> xenctrl_stubs.o] Error 1
>> m
>>
>> Signed-off-by: John Thomson 

Release-acked-by: Juergen Gross 


Juergen

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] tools/ocaml/libs/xc fix gcc-8 format-truncation warning

[Wei Liu]

CC Juergen, I think this should be in 4.11

On Tue, May 15, 2018 at 11:48:43AM +1000, John Thomson wrote:
>  CC   xenctrl_stubs.o
> xenctrl_stubs.c: In function 'failwith_xc':
> xenctrl_stubs.c:65:17: error: 'snprintf' output may be truncated before the 
> last format character [-Werror=format-truncation=]
>   "%d: %s: %s", error->code,
>  ^
> xenctrl_stubs.c:64:4: note: 'snprintf' output 6 or more bytes (assuming 1029) 
> into a destination of size 1028
> snprintf(error_str, sizeof(error_str),
> ^~
>   "%d: %s: %s", error->code,
>   ~~
>   xc_error_code_to_desc(error->code),
>   ~~~
>   error->message);
>   ~~~
> cc1: all warnings being treated as errors
> make[8]: *** 
> [/build/xen-git/src/xen/tools/ocaml/libs/xc/../../Makefile.rules:37: 
> xenctrl_stubs.o] Error 1
> m
> 
> Signed-off-by: John Thomson 
> ---
>  tools/ocaml/libs/xc/xenctrl_stubs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c 
> b/tools/ocaml/libs/xc/xenctrl_stubs.c
> index f97070c8b0..d4309ad97e 100644
> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c
> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
> @@ -54,7 +54,7 @@
>  
>  static void Noreturn failwith_xc(xc_interface *xch)
>  {
> - char error_str[1028];
> + char error_str[XC_MAX_ERROR_MSG_LEN + 6];
>   if (xch) {
>   const xc_error *error = xc_get_last_error(xch);
>   if (error->code == XC_ERROR_NONE)
> -- 
> 2.17.0
> 
> 
> ___
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] tools/ocaml/libs/xc fix gcc-8 format-truncation warning

[Christian Lindig]

> On 15 May 2018, at 02:48, John Thomson  
> wrote:
> 
> CC   xenctrl_stubs.o
> xenctrl_stubs.c: In function 'failwith_xc':
> xenctrl_stubs.c:65:17: error: 'snprintf' output may be truncated before the 
> last format character [-Werror=format-truncation=]
>  "%d: %s: %s", error->code,
> ^
> xenctrl_stubs.c:64:4: note: 'snprintf' output 6 or more bytes (assuming 1029) 
> into a destination of size 1028
>snprintf(error_str, sizeof(error_str),
>^~
>  "%d: %s: %s", error->code,
>  ~~
>  xc_error_code_to_desc(error->code),
>  ~~~
>  error->message);
>  ~~~
> cc1: all warnings being treated as errors
> make[8]: *** 
> [/build/xen-git/src/xen/tools/ocaml/libs/xc/../../Makefile.rules:37: 
> xenctrl_stubs.o] Error 1
> m
> 
> Signed-off-by: John Thomson 
> ---
> tools/ocaml/libs/xc/xenctrl_stubs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c 
> b/tools/ocaml/libs/xc/xenctrl_stubs.c
> index f97070c8b0..d4309ad97e 100644
> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c
> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
> @@ -54,7 +54,7 @@
> 
> static void Noreturn failwith_xc(xc_interface *xch)
> {
> - char error_str[1028];
> + char error_str[XC_MAX_ERROR_MSG_LEN + 6];
>   if (xch) {
>   const xc_error *error = xc_get_last_error(xch);
>   if (error->code == XC_ERROR_NONE)
> -- 
> 2.17.0
> 


Acked-by: Christian Lindig 


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel