Re: [Xen-devel] [PATCH] x86/altp2m: move altp2m_get_effective_entry() under CONFIG_HVM

2019-05-15 Thread Wei Liu 
On Wed, May 15, 2019 at 09:55:30AM +0100, George Dunlap wrote:
> On 5/15/19 7:53 AM, Wei Liu wrote:
> > On Tue, May 14, 2019 at 07:13:57PM +0300, Razvan Cojocaru wrote:
> >> All its callers live inside #ifdef CONFIG_HVM sections.
> >>
> >> Signed-off-by: Razvan Cojocaru 
> > 
> > Reviewed-by: Wei Liu 
> 
> Acked-by: George Dunlap 

Applied.

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/altp2m: move altp2m_get_effective_entry() under CONFIG_HVM

2019-05-15 Thread George Dunlap 
On 5/15/19 7:53 AM, Wei Liu wrote:
> On Tue, May 14, 2019 at 07:13:57PM +0300, Razvan Cojocaru wrote:
>> All its callers live inside #ifdef CONFIG_HVM sections.
>>
>> Signed-off-by: Razvan Cojocaru 
> 
> Reviewed-by: Wei Liu 

Acked-by: George Dunlap 

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/altp2m: move altp2m_get_effective_entry() under CONFIG_HVM

2019-05-15 Thread Wei Liu 
On Tue, May 14, 2019 at 07:13:57PM +0300, Razvan Cojocaru wrote:
> All its callers live inside #ifdef CONFIG_HVM sections.
> 
> Signed-off-by: Razvan Cojocaru 

Reviewed-by: Wei Liu 

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/altp2m: move altp2m_get_effective_entry() under CONFIG_HVM

2019-05-14 Thread Jan Beulich 
>>> On 14.05.19 at 18:13,  wrote:
> All its callers live inside #ifdef CONFIG_HVM sections.
> 
> Signed-off-by: Razvan Cojocaru 

Thanks!

> --- a/xen/include/asm-x86/p2m.h
> +++ b/xen/include/asm-x86/p2m.h
> @@ -514,6 +514,7 @@ static inline unsigned long mfn_to_gfn(struct domain *d, 
> mfn_t mfn)
>  return mfn_x(mfn);
>  }
>  
> +#ifdef CONFIG_HVM
>  #define AP2MGET_prepopulate true
>  #define AP2MGET_query false
>  
> @@ -525,6 +526,7 @@ static inline unsigned long mfn_to_gfn(struct domain *d, 
> mfn_t mfn)
>  int altp2m_get_effective_entry(struct p2m_domain *ap2m, gfn_t gfn, mfn_t 
> *mfn,
> p2m_type_t *t, p2m_access_t *a,
> bool prepopulate);
> +#endif
>  
>  /* Deadlock-avoidance scheme when calling get_gfn on different gfn's */
>  struct two_gfns {

I don't think these adjustments are strictly needed, but at least for
now they of course also don't hurt.

Jan



___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel