Re: [Xen-devel] [PATCH] x86/shadow: un-hide "full" auditing code
At 08:59 -0700 on 20 Nov (1542704343), Jan Beulich wrote: > In particular sh_oos_audit() has become stale due to changes elsewhere, > and the need for adjustment was not noticed because both "full audit" > flags are off in both release and debug builds. Switch away from pre- > processsor conditionals, thus exposing the code to the compiler at all > times. This obviously requires correcting the accumulated issues with > the so far hidden code. > > Note that shadow_audit_tables() now also gains an effect with "full > entry audit" mode disabled; the prior code structure suggests that this > was originally intended anyway. > > Signed-off-by: Jan Beulich Acked-by: Tim Deegan Thanks! Tim. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH] x86/shadow: un-hide "full" auditing code
On 20/11/2018 15:59, Jan Beulich wrote: > In particular sh_oos_audit() has become stale due to changes elsewhere, > and the need for adjustment was not noticed because both "full audit" > flags are off in both release and debug builds. Switch away from pre- > processsor conditionals, thus exposing the code to the compiler at all > times. This obviously requires correcting the accumulated issues with > the so far hidden code. > > Note that shadow_audit_tables() now also gains an effect with "full > entry audit" mode disabled; the prior code structure suggests that this > was originally intended anyway. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper This has been a low item on my todo list for years now. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
