Re: [Xen-devel] [PATCH] xen/arm: domain_build: Print the correct domain in initrd_load()

2019-10-01 Thread Stefano Stabellini 
On Thu, 15 Aug 2019, Julien Grall wrote:
> initrd_load() can be called by other domain than dom0. To avoid
> confusion in the log, print the correct domain.
> 
> Signed-off-by: Julien Grall 

Thanks the bug was really annoying.

Reviewed-by: Stefano Stabellini 


> ---
>  xen/arch/arm/domain_build.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 126374f603..33171081ea 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1818,8 +1818,8 @@ static void __init initrd_load(struct kernel_info 
> *kinfo)
>  paddr = mod->start;
>  len = mod->size;
>  
> -printk("Loading dom0 initrd from %"PRIpaddr" to 
> 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> -   paddr, load_addr, load_addr + len);
> +printk("Loading %pd initrd from %"PRIpaddr" to 
> 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> +   kinfo->d, paddr, load_addr, load_addr + len);
>  
>  /* Fix up linux,initrd-start and linux,initrd-end in /chosen */
>  node = fdt_path_offset(kinfo->fdt, "/chosen");
> -- 
> 2.11.0
> 

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen/arm: domain_build: Print the correct domain in initrd_load()

2019-08-16 Thread Julien Grall 



On 16/08/2019 17:32, Volodymyr Babchuk wrote:


Julien Grall writes:


initrd_load() can be called by other domain than dom0. To avoid
confusion in the log, print the correct domain.

Signed-off-by: Julien Grall 

Reviewed-by: Volodymyr Babchuk 

But why didn't you gathered all those patches into one patch series?


Because I couldn't be bothered to write a cover letter for it and
they don't depend on each other...

Cheers,

--
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen/arm: domain_build: Print the correct domain in initrd_load()

2019-08-16 Thread Volodymyr Babchuk 

Julien Grall writes:

> initrd_load() can be called by other domain than dom0. To avoid
> confusion in the log, print the correct domain.
>
> Signed-off-by: Julien Grall 
Reviewed-by: Volodymyr Babchuk 

But why didn't you gathered all those patches into one patch series?
> ---
>  xen/arch/arm/domain_build.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 126374f603..33171081ea 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1818,8 +1818,8 @@ static void __init initrd_load(struct kernel_info 
> *kinfo)
>  paddr = mod->start;
>  len = mod->size;
>  
> -printk("Loading dom0 initrd from %"PRIpaddr" to 
> 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> -   paddr, load_addr, load_addr + len);
> +printk("Loading %pd initrd from %"PRIpaddr" to 
> 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> +   kinfo->d, paddr, load_addr, load_addr + len);
>  
>  /* Fix up linux,initrd-start and linux,initrd-end in /chosen */
>  node = fdt_path_offset(kinfo->fdt, "/chosen");


-- 
Volodymyr Babchuk at EPAM
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel