Re: [Xen-devel] [PATCH 1/3] x86 / vmx: make apic_access_mfn type-safe
On 22.01.2020 15:05, Andrew Cooper wrote: > On 21/01/2020 12:00, Paul Durrant wrote: >> Use mfn_t rather than unsigned long and change previous tests against 0 to >> tests against INVALID_MFN (also introducing initialization to that value). >> >> Signed-off-by: Paul Durrant > > I'm afraid this breaks the idempotency of vmx_free_vlapic_mapping(), > which gets in the way of domain/vcpu create/destroy cleanup. > > Its fine to use 0 as the sentinel. And with this adjustment Reviewed-by: Jan Beulich Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH 1/3] x86 / vmx: make apic_access_mfn type-safe
On 21/01/2020 12:00, Paul Durrant wrote: > Use mfn_t rather than unsigned long and change previous tests against 0 to > tests against INVALID_MFN (also introducing initialization to that value). > > Signed-off-by: Paul Durrant I'm afraid this breaks the idempotency of vmx_free_vlapic_mapping(), which gets in the way of domain/vcpu create/destroy cleanup. Its fine to use 0 as the sentinel. ~Andrew ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH 1/3] x86 / vmx: make apic_access_mfn type-safe
> From: Paul Durrant > Sent: Tuesday, January 21, 2020 8:00 PM > > Use mfn_t rather than unsigned long and change previous tests against 0 to > tests against INVALID_MFN (also introducing initialization to that value). > > Signed-off-by: Paul Durrant Reviewed-by: Kevin Tian ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
