Re: [Xen-devel] [PATCH RFC v2 01/12] x86: cleanup processor.h

[Jan Beulich]

>>> On 22.01.18 at 15:25,  wrote:
> On 22/01/18 14:10, Juergen Gross wrote:
>> On 22/01/18 13:52, Jan Beulich wrote:
>> On 22.01.18 at 13:32,  wrote:
 Remove NSC/Cyrix CPU macros and current_text_addr() which are used
 nowhere.
>>> I agree doing the former, but I have a vague recollection that we've
>>> left the latter in place despite there not being any callers at present.
>> It isn't as if current_text_addr() would be rocket science. I'm quite
>> sure in case it is needed there will be enough brain power available to
>> build it either from scratch again or to find it in git.
>>
>> In case you really like it to stay I won't object, of course.
> 
> FWIW, I've disliked all the recent patches which have tried to use
> current_text_addr(), and I don't see it as a useful debugging utility
> either.
> 
> I would prefer to see it gone than to stay.

Well, okay then. The patch is independent of the other, actual
RFC stuff, so could go in right away.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH RFC v2 01/12] x86: cleanup processor.h

[Andrew Cooper]

On 22/01/18 14:10, Juergen Gross wrote:
> On 22/01/18 13:52, Jan Beulich wrote:
> On 22.01.18 at 13:32,  wrote:
>>> Remove NSC/Cyrix CPU macros and current_text_addr() which are used
>>> nowhere.
>> I agree doing the former, but I have a vague recollection that we've
>> left the latter in place despite there not being any callers at present.
> It isn't as if current_text_addr() would be rocket science. I'm quite
> sure in case it is needed there will be enough brain power available to
> build it either from scratch again or to find it in git.
>
> In case you really like it to stay I won't object, of course.

FWIW, I've disliked all the recent patches which have tried to use
current_text_addr(), and I don't see it as a useful debugging utility
either.

I would prefer to see it gone than to stay.

~Andrew

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH RFC v2 01/12] x86: cleanup processor.h

[Jan Beulich]

>>> On 22.01.18 at 13:32,  wrote:
> Remove NSC/Cyrix CPU macros and current_text_addr() which are used
> nowhere.

I agree doing the former, but I have a vague recollection that we've
left the latter in place despite there not being any callers at present.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel