Re: [Xen-devel] [PATCH v4 3/4] xen: refactor debugtrace data

2019-09-05 Thread Juergen Gross 

On 05.09.19 12:06, Jan Beulich wrote:

On 04.09.2019 15:46, Juergen Gross wrote:

--- a/xen/common/debugtrace.c
+++ b/xen/common/debugtrace.c
@@ -15,35 +15,41 @@
  #include 
  
  /* Send output direct to console, or buffer it? */

-static volatile int debugtrace_send_to_console;
+static volatile bool debugtrace_send_to_console;
  
-static char*debugtrace_buf; /* Debug-trace buffer */

-static unsigned int debugtrace_prd; /* Producer index */
-static unsigned int debugtrace_prd_last;
-static unsigned int debugtrace_kilobytes = 128, debugtrace_bytes;
-static unsigned int debugtrace_used;
+struct debugtrace_data {
+unsigned long bytes; /* Size of buffer. */
+unsigned long prd;   /* Producer index. */
+unsigned long prd_last;


I'd still like this change from int to long mentioned / justified
in the description. With this
Reviewed-by: Jan Beulich 


Okay, thanks.


Juergen


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 3/4] xen: refactor debugtrace data

2019-09-05 Thread Jan Beulich 
On 04.09.2019 15:46, Juergen Gross wrote:
> --- a/xen/common/debugtrace.c
> +++ b/xen/common/debugtrace.c
> @@ -15,35 +15,41 @@
>  #include 
>  
>  /* Send output direct to console, or buffer it? */
> -static volatile int debugtrace_send_to_console;
> +static volatile bool debugtrace_send_to_console;
>  
> -static char*debugtrace_buf; /* Debug-trace buffer */
> -static unsigned int debugtrace_prd; /* Producer index */
> -static unsigned int debugtrace_prd_last;
> -static unsigned int debugtrace_kilobytes = 128, debugtrace_bytes;
> -static unsigned int debugtrace_used;
> +struct debugtrace_data {
> +unsigned long bytes; /* Size of buffer. */
> +unsigned long prd;   /* Producer index. */
> +unsigned long prd_last;

I'd still like this change from int to long mentioned / justified
in the description. With this
Reviewed-by: Jan Beulich 

Jan

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel