Re: [Xen-ia64-devel] [Patch][2/2] cleanup warning of UC|WB attributepage

2007-05-24 Thread Alex Williamson
On Wed, 2007-05-23 at 20:08 +0900, Akio Takebe wrote:
 Hi,
 
 This patch cleanup the following warning.
 
 (XEN) mm.c:497:d0 Warning: UC to WB for mpaddr=

Hi Akio,

   Is this cleanup ok?

Signed-off-by: Akio Takebe [EMAIL PROTECTED]
Signed-off-by: Alex Williamson [EMAIL PROTECTED]
---

diff -r 301267d0db12 xen/arch/ia64/xen/mm.c
--- a/xen/arch/ia64/xen/mm.cThu May 24 14:43:14 2007 -0600
+++ b/xen/arch/ia64/xen/mm.cThu May 24 15:34:14 2007 -0600
@@ -492,9 +492,22 @@ u64 translate_domain_pte(u64 pteval, u64
   This can happen when domU tries to touch i/o
   port space.  Also prevents possible address
   aliasing issues.  */
-   if (!(mpaddr - IO_PORTS_PADDR  IO_PORTS_SIZE))
-   gdprintk(XENLOG_WARNING, Warning: UC to WB 
-for mpaddr=%lx\n, mpaddr);
+   if (!(mpaddr - IO_PORTS_PADDR  IO_PORTS_SIZE)) {
+   u64 ucwb;
+   
+   /*
+* If dom0 page has both UC  WB attributes
+* don't warn about attempted UC access.
+*/
+   ucwb = efi_mem_attribute(mpaddr, PAGE_SIZE);
+   ucwb = EFI_MEMORY_UC | EFI_MEMORY_WB;
+   ucwb ^= EFI_MEMORY_UC | EFI_MEMORY_WB;
+
+   if (d != dom0 || ucwb != 0)
+   gdprintk(XENLOG_WARNING, Warning: UC
+ to WB for mpaddr=%lx\n,
+mpaddr);
+   }
pteval = (pteval  ~_PAGE_MA_MASK) | _PAGE_MA_WB;
}
break;



___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel


[Xen-ia64-devel] [Patch][2/2] cleanup warning of UC|WB attributepage

2007-05-23 Thread Akio Takebe
Hi,

This patch cleanup the following warning.

(XEN) mm.c:497:d0 Warning: UC to WB for mpaddr=


Signed-off-by: Akio Takebe [EMAIL PROTECTED]

Best Regards

Akio Takebe


cleanup_warning_efi_ucwb.v3.patch
Description: Binary data
___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel