Re: [Xen-ia64-devel] [Patch] linux: need to set psr.ac inpage_fault
On Tue, 2008-03-25 at 10:08 +0900, Akio Takebe wrote: Ah, It's redundant. I remove the ifdef. PSR_DEFAULT_BITS is always defined. And even if PSR_DEFAULT_BITS == 0, sum 0x0 is harmless. Applied. Thanks, Alex -- Alex Williamson HP Open Source Linux Org. ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
Re: [Xen-ia64-devel] [Patch] linux: need to set psr.ac inpage_fault
Hi, Alex On Wed, 2008-03-19 at 22:46 +0900, Akio Takebe wrote: Hi, This patch fixes a different behavior from the original code. We need to set psr.ac. diff -r ba72914de93a arch/ia64/xen/xenivt.S --- a/arch/ia64/xen/xenivt.SWed Mar 05 17:29:05 2008 + +++ b/arch/ia64/xen/xenivt.SThu Mar 20 06:53:32 2008 +0900 @@ -696,16 +696,19 @@ ENTRY(page_fault) st4 [r3]=r14// vpsr.ic = 1 adds r3=8,r2// set up second base pointer ;; +#ifdef PSR_DEFAULT_BITS + sum PSR_DEFAULT_BITS +#endif How would we ever get here w/o PSR_DEFAULT_BITS defined? Thanks, I have tested with/without the patch, nothing happened. But I wanted to be the same as native linux. Best Regards, Akio Takebe ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
Re: [Xen-ia64-devel] [Patch] linux: need to set psr.ac inpage_fault
On Mon, 2008-03-24 at 18:49 +0900, Akio Takebe wrote: On Wed, 2008-03-19 at 22:46 +0900, Akio Takebe wrote: ;; +#ifdef PSR_DEFAULT_BITS + sum PSR_DEFAULT_BITS +#endif How would we ever get here w/o PSR_DEFAULT_BITS defined? Thanks, I have tested with/without the patch, nothing happened. But I wanted to be the same as native linux. Hi Akio, My comment is whether it's redundant to have the #ifdef PSR_DEFAULT_BITS surrounding setting the user mask. AFAICT, we can't get to this code w/o PSR_DEFAULT_BITS set, so it seems unnecessary to test for it. Thanks, Alex -- Alex Williamson HP Open Source Linux Org. ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
Re: [Xen-ia64-devel] [Patch] linux: need to set psr.ac inpage_fault
Hi, Alex On Mon, 2008-03-24 at 18:49 +0900, Akio Takebe wrote: On Wed, 2008-03-19 at 22:46 +0900, Akio Takebe wrote: ;; +#ifdef PSR_DEFAULT_BITS + sum PSR_DEFAULT_BITS +#endif How would we ever get here w/o PSR_DEFAULT_BITS defined? Thanks, I have tested with/without the patch, nothing happened. But I wanted to be the same as native linux. Hi Akio, My comment is whether it's redundant to have the #ifdef PSR_DEFAULT_BITS surrounding setting the user mask. AFAICT, we can't get to this code w/o PSR_DEFAULT_BITS set, so it seems unnecessary to test for it. Thanks, Ah, It's redundant. I remove the ifdef. PSR_DEFAULT_BITS is always defined. And even if PSR_DEFAULT_BITS == 0, sum 0x0 is harmless. Signed-off-by: Akio Takebe [EMAIL PROTECTED] Best Regards, Akio Takebe fix_set_psr_ac.2.patch Description: Binary data ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
