[Xen-ia64-devel] Re: [Xen-devel] Re: [PATCH] kexec: framework and i386 (Take XIV)

2007-05-31 Thread Akio Takebe 
Hi, Ian and Horms

I add the nmi=kdump option as Ian suggested.
What do you think about it?

Signed-off-by: Akio Takebe [EMAIL PROTECTED]
---

diff -r 089696e0c603 xen/arch/x86/traps.c
--- a/xen/arch/x86/traps.c  Thu May 17 11:42:46 2007 +0100
+++ b/xen/arch/x86/traps.c  Thu May 31 02:25:02 2007 +0900
@@ -1897,6 +1897,7 @@ asmlinkage void io_check_error(struct cp
 {
 case 'd': /* 'dom0' */
 nmi_dom0_report(_XEN_NMIREASON_io_error);
+case 'k': /* 'kdump' */
 case 'i': /* 'ignore' */
 break;
 default:  /* 'fatal' */
@@ -1916,6 +1917,8 @@ static void unknown_nmi_error(unsigned c
 {
 case 'd': /* 'dom0' */
 nmi_dom0_report(_XEN_NMIREASON_unknown);
+case 'k': /* 'kdump' */
+kexec_crash();
 case 'i': /* 'ignore' */
 break;
 default:  /* 'fatal' */


Best Regards,

Akio Takebe


___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel

[Xen-ia64-devel] Re: [Xen-devel] Re: [PATCH] kexec: framework and i386 (Take XIV)

2007-05-31 Thread Akio Takebe 
Hi, Keir

Hi, Keir

On 31/5/07 11:43, Akio Takebe [EMAIL PROTECTED] wrote:

 Hi, Ian and Horms
 
 I add the nmi=kdump option as Ian suggested.
 What do you think about it?

Won't the default fatal_trap() behaviour cause you to drop into kdump code
anyway? fatal_trap - panic - kexec_crash.

Oops, you're right.
All we do is just setting nmi=kdump.

Sorry, please ignore the previous mail.
Yes, as Keir said fatal_trap() should call panic.
All we do is just setting nmi=fatal.

Best Regards,

Akio Takebe


___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel

[Xen-ia64-devel] Re: [Xen-devel] Re: [PATCH] kexec: framework and i386 (Take XIV)

2007-05-28 Thread Akio Takebe 
Hi, Horms and Ian

Thank you for your reply, Horms.
I forgot Signed-off-by of the patch.

Signed-off-by: Horms [EMAIL PROTECTED]
Signed-off-by: Akio Takebe [EMAIL PROTECTED]

Is the Signed-off-by OK, Horms?

Best Regards,

Akio Takebe

[ Ian Campbell added to CC list ]

On Tue, Sep 05, 2006 at 06:45:35AM +0900, Akio Takebe wrote:
 Hi, Horms
 
 I tested the following patch with Horms kexec patch.
 
 My tests is:
   push NMI bottun after loading kdump kernel.
   
 The results is:
   OK, I could get vmcore


Hi Takebe-san,

this patch seems ok to me, but it seems that it never went into the
tree. Ian, what are your thoughts on it?

 diff -r b688d4a68a3e xen/arch/x86/traps.c
 --- a/xen/arch/x86/traps.c  Tue Aug 22 14:59:16 2006 +0100
 +++ b/xen/arch/x86/traps.c  Tue Sep 05 06:37:49 2006 +0900
 @@ -105,6 +105,8 @@ static int debug_stack_lines = 20;
  static int debug_stack_lines = 20;
  integer_param(debug_stack_lines, debug_stack_lines);
  
 +extern void crash_kexec(struct cpu_user_regs *regs);
 +
  #ifdef CONFIG_X86_32
  #define stack_words_per_line 8
  #define ESP_BEFORE_EXCEPTION(regs) ((unsigned long *)regs-esp)
 @@ -1611,8 +1613,10 @@ asmlinkage void do_nmi(struct cpu_user_r
  mem_parity_error(regs);
  else if ( reason  0x40 )
  io_check_error(regs);
 -else if ( !nmi_watchdog )
 +else if ( !nmi_watchdog ){
 +crash_kexec(NULL);
  unknown_nmi_error((unsigned char)(reason0xff));
 +}
  }
  }
  
 
 
 Best Regards,
 
 Akio Takebe


___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel

[Xen-ia64-devel] Re: [Xen-devel] Re: [PATCH] kexec: framework and i386 (Take XIV)

2007-05-28 Thread Horms 
On Mon, May 28, 2007 at 03:25:04PM +0900, Akio Takebe wrote:
 Hi, Horms and Ian
 
 Thank you for your reply, Horms.
 I forgot Signed-off-by of the patch.
 
 Signed-off-by: Horms [EMAIL PROTECTED]
 Signed-off-by: Akio Takebe [EMAIL PROTECTED]
 
 Is the Signed-off-by OK, Horms?

Actually, i think this might be better:

Acked-by: Simon Horman [EMAIL PROTECTED]

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel

[Xen-ia64-devel] Re: [Xen-devel] Re: [PATCH] kexec: framework and i386 (Take XIV)

2007-05-27 Thread Horms 
[ Ian Campbell added to CC list ]

On Tue, Sep 05, 2006 at 06:45:35AM +0900, Akio Takebe wrote:
 Hi, Horms
 
 I tested the following patch with Horms kexec patch.
 
 My tests is:
   push NMI bottun after loading kdump kernel.
   
 The results is:
   OK, I could get vmcore


Hi Takebe-san,

this patch seems ok to me, but it seems that it never went into the
tree. Ian, what are your thoughts on it?

 diff -r b688d4a68a3e xen/arch/x86/traps.c
 --- a/xen/arch/x86/traps.c  Tue Aug 22 14:59:16 2006 +0100
 +++ b/xen/arch/x86/traps.c  Tue Sep 05 06:37:49 2006 +0900
 @@ -105,6 +105,8 @@ static int debug_stack_lines = 20;
  static int debug_stack_lines = 20;
  integer_param(debug_stack_lines, debug_stack_lines);
  
 +extern void crash_kexec(struct cpu_user_regs *regs);
 +
  #ifdef CONFIG_X86_32
  #define stack_words_per_line 8
  #define ESP_BEFORE_EXCEPTION(regs) ((unsigned long *)regs-esp)
 @@ -1611,8 +1613,10 @@ asmlinkage void do_nmi(struct cpu_user_r
  mem_parity_error(regs);
  else if ( reason  0x40 )
  io_check_error(regs);
 -else if ( !nmi_watchdog )
 +else if ( !nmi_watchdog ){
 +crash_kexec(NULL);
  unknown_nmi_error((unsigned char)(reason0xff));
 +}
  }
  }
  
 
 
 Best Regards,
 
 Akio Takebe
 
 On Fri, Sep 01, 2006 at 05:45:59PM +0900, Akio Takebe wrote:
  Hi, Horms
  
  That seems like a good idea to me. Though I think you are missing { }.
  Can you test to see if this works?
  Oops, You're right. But I think unknown_nmi_error() is not called,
  because crash_kexec() is called before that.
  Sorry.
  In the only case of CONFIG_KEXEC=y, the above is right.
 
 Yes, I think that is the case. I will put your patch into the kexec
 series, as I think that it is a worthy addition.
 
 -- 
 Horms
   H: http://www.vergenet.net/~horms/
   W: http://www.valinux.co.jp/en/
 
 
 ___
 Xen-devel mailing list
 [EMAIL PROTECTED]
 http://lists.xensource.com/xen-devel

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel

[Xen-ia64-devel] Re: [Xen-devel] Re: [PATCH] kexec: framework and i386 (Take XIV)

2006-09-04 Thread Akio Takebe 
Hi, Horms

I tested the following patch with Horms kexec patch.

My tests is:
  push NMI bottun after loading kdump kernel.
  
The results is:
  OK, I could get vmcore

diff -r b688d4a68a3e xen/arch/x86/traps.c
--- a/xen/arch/x86/traps.c  Tue Aug 22 14:59:16 2006 +0100
+++ b/xen/arch/x86/traps.c  Tue Sep 05 06:37:49 2006 +0900
@@ -105,6 +105,8 @@ static int debug_stack_lines = 20;
 static int debug_stack_lines = 20;
 integer_param(debug_stack_lines, debug_stack_lines);
 
+extern void crash_kexec(struct cpu_user_regs *regs);
+
 #ifdef CONFIG_X86_32
 #define stack_words_per_line 8
 #define ESP_BEFORE_EXCEPTION(regs) ((unsigned long *)regs-esp)
@@ -1611,8 +1613,10 @@ asmlinkage void do_nmi(struct cpu_user_r
 mem_parity_error(regs);
 else if ( reason  0x40 )
 io_check_error(regs);
-else if ( !nmi_watchdog )
+else if ( !nmi_watchdog ){
+crash_kexec(NULL);
 unknown_nmi_error((unsigned char)(reason0xff));
+}
 }
 }
 


Best Regards,

Akio Takebe

On Fri, Sep 01, 2006 at 05:45:59PM +0900, Akio Takebe wrote:
 Hi, Horms
 
 That seems like a good idea to me. Though I think you are missing { }.
 Can you test to see if this works?
 Oops, You're right. But I think unknown_nmi_error() is not called,
 because crash_kexec() is called before that.
 Sorry.
 In the only case of CONFIG_KEXEC=y, the above is right.

Yes, I think that is the case. I will put your patch into the kexec
series, as I think that it is a worthy addition.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


___
Xen-devel mailing list
[EMAIL PROTECTED]
http://lists.xensource.com/xen-devel


___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel

[Xen-ia64-devel] Re: [Xen-devel] Re: [PATCH] kexec: framework and i386 (Take XIV)

2006-09-01 Thread Akio Takebe 
Hi, Horms

That seems like a good idea to me. Though I think you are missing { }.
Can you test to see if this works?
Oops, You're right. But I think unknown_nmi_error() is not called,
because crash_kexec() is called before that.
Sorry.
In the only case of CONFIG_KEXEC=y, the above is right.

Best Regards,

Akio Takebe


___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel